From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10429 invoked by alias); 25 Nov 2009 02:00:34 -0000 Received: (qmail 10411 invoked by uid 22791); 25 Nov 2009 02:00:31 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-px0-f175.google.com (HELO mail-px0-f175.google.com) (209.85.216.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Nov 2009 02:00:21 +0000 Received: by pxi5 with SMTP id 5so5088011pxi.12 for ; Tue, 24 Nov 2009 18:00:20 -0800 (PST) MIME-Version: 1.0 Received: by 10.142.66.13 with SMTP id o13mr745800wfa.307.1259114420222; Tue, 24 Nov 2009 18:00:20 -0800 (PST) In-Reply-To: References: <20090928160728.GB9003@adacore.com> <4AF07CF2.1050902@vmware.com> From: Hui Zhu Date: Wed, 25 Nov 2009 02:00:00 -0000 Message-ID: Subject: Re: [RFA] let record_resume fail immediately on error To: tromey@redhat.com Cc: "gdb-patches@sourceware.org" , Michael Snyder , Joel Brobecker Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00540.txt.bz2 Why "do_record_message" cannot be a caller? It be a caller in a long time. I call "record_message". You don't like it. I put it to "do_record_message". You don't like it too. I don't like use TRY_CATCH or catch_errors directly. Thanks, Hui On Wed, Nov 25, 2009 at 01:13, Tom Tromey wrote: >>>>>> ">" =3D=3D Hui Zhu writes: > >>> =A0static int >>> =A0do_record_message (struct regcache *regcache, >>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 enum target_signal signal) >>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 enum target_signal signal, int catch) > > This is still a very weird way to write what should be an ordinary > function call. > > Tom >