From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31211 invoked by alias); 24 Oct 2009 03:07:22 -0000 Received: (qmail 31203 invoked by uid 22791); 24 Oct 2009 03:07:21 -0000 X-SWARE-Spam-Status: No, hits=-0.2 required=5.0 tests=AWL,BAYES_00,HK_OBFDOM,HK_OBFDOMREQ,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-px0-f175.google.com (HELO mail-px0-f175.google.com) (209.85.216.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 24 Oct 2009 03:07:15 +0000 Received: by pxi5 with SMTP id 5so5576625pxi.12 for ; Fri, 23 Oct 2009 20:07:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.143.154.14 with SMTP id g14mr900454wfo.266.1256353634091; Fri, 23 Oct 2009 20:07:14 -0700 (PDT) In-Reply-To: <4AE1CF46.7030106@vmware.com> References: <4AE1CF46.7030106@vmware.com> From: Hui Zhu Date: Sat, 24 Oct 2009 03:07:00 -0000 Message-ID: Subject: Re: [RFA] Makefile.in, linux.mh: Move Process Record to NATDEPFILES To: Michael Snyder Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00609.txt.bz2 Sorry. I cannot agree with this patch. It make record to be the linux-special code. Thanks, Hui On Fri, Oct 23, 2009 at 23:44, Michael Snyder wrote: > Hey folks, we ran into a bunch of build problems because record.c > was being compiled in a lot of builds where it wasn't needed (or > tested). > > This change will make record.c be like gcore.c, in that it is only > built if the target config files explicitly call for it. > > For this patch, I've only included record.c for i386-linux. > We can add amd64-linux in a separate patch if we decide it is > ready. > > Michael > > > 2009-10-23 =A0Michael Snyder =A0 > > =A0 =A0 =A0 =A0* Makefile.in (COMMON_OBS): Remove record.o. > =A0 =A0 =A0 =A0(ALL_TARGET_OBS): Remove linux-record.o. > =A0 =A0 =A0 =A0config/i386/linux.h (NATDEPFILES): Add record.o, linux-rec= ord.o. > > Index: Makefile.in > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /cvs/src/src/gdb/Makefile.in,v > retrieving revision 1.1103 > diff -u -p -w -b -r1.1103 Makefile.in > --- Makefile.in 21 Oct 2009 14:14:56 -0000 =A0 =A0 =A01.1103 > +++ Makefile.in 23 Oct 2009 15:45:31 -0000 > @@ -531,8 +531,7 @@ ALL_TARGET_OBS =3D \ > =A0 =A0 =A0 =A0xcoffread.o \ > =A0 =A0 =A0 =A0symfile-mem.o \ > =A0 =A0 =A0 =A0corelow.o \ > - =A0 =A0 =A0 windows-tdep.o \ > - =A0 =A0 =A0 linux-record.o > + =A0 =A0 =A0 windows-tdep.o > > =A0# Host-dependent makefile fragment comes in here. > =A0@host_makefile_frag@ > @@ -834,7 +833,7 @@ COMMON_OBS =3D $(DEPFILES) $(CONFIG_OBS) $ > =A0 =A0 =A0 =A0solib.o solib-null.o \ > =A0 =A0 =A0 =A0prologue-value.o memory-map.o xml-support.o xml-syscall.o \ > =A0 =A0 =A0 =A0target-descriptions.o target-memory.o xml-tdesc.o xml-buil= tin.o \ > - =A0 =A0 =A0 inferior.o osdata.o gdb_usleep.o record.o \ > + =A0 =A0 =A0 inferior.o osdata.o gdb_usleep.o \ > =A0 =A0 =A0 =A0jit.o progspace.o > > =A0# Definitions for the syscall's XML files and dir > Index: config/i386/linux.mh > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /cvs/src/src/gdb/config/i386/linux.mh,v > retrieving revision 1.21 > diff -u -p -w -b -r1.21 linux.mh > --- config/i386/linux.mh =A0 =A0 =A0 =A014 Aug 2007 12:51:59 -0000 =A0 = =A0 =A01.21 > +++ config/i386/linux.mh =A0 =A0 =A0 =A023 Oct 2009 15:45:31 -0000 > @@ -4,7 +4,7 @@ NAT_FILE=3D nm-linux.h > =A0NATDEPFILES=3D inf-ptrace.o fork-child.o \ > =A0 =A0 =A0 =A0i386-nat.o i386-linux-nat.o \ > =A0 =A0 =A0 =A0proc-service.o linux-thread-db.o gcore.o \ > - =A0 =A0 =A0 linux-nat.o linux-fork.o > + =A0 =A0 =A0 linux-nat.o linux-fork.o linux-record.o record.o > > =A0# The dynamically loaded libthread_db needs access to symbols in the > =A0# gdb executable. > >