From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30616 invoked by alias); 23 Oct 2009 06:56:26 -0000 Received: (qmail 30605 invoked by uid 22791); 23 Oct 2009 06:56:25 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-pz0-f189.google.com (HELO mail-pz0-f189.google.com) (209.85.222.189) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 23 Oct 2009 06:56:21 +0000 Received: by pzk27 with SMTP id 27so4143041pzk.12 for ; Thu, 22 Oct 2009 23:56:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.248.40 with SMTP id v40mr788017wfh.203.1256280980246; Thu, 22 Oct 2009 23:56:20 -0700 (PDT) In-Reply-To: <4AE0B811.30604@vmware.com> References: <4ADCC1CE.1090304@vmware.com> <20091019200322.GD5282@adacore.com> <4AE0B811.30604@vmware.com> From: Hui Zhu Date: Fri, 23 Oct 2009 06:56:00 -0000 Message-ID: Subject: Re: [RFA] New testes for process record save/restore commands To: Michael Snyder , Paul Pluzhnikov Cc: Joel Brobecker , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00558.txt.bz2 Hi Michael, This testsuite will get fail with "consecutive-precsave.exp solib-precsave.exp until-precsave.exp". I checked the consecutive-precsave.exp, this issue is because: x /2i $pc =3D> 0x8048377 : mov 0x80495a4,%edx 0x804837d : mov 0x80495a8,%eax This is the new feature of gdb from Paul. Paul, could you add a switch for this "=3D>"? Thanks, Hui On Fri, Oct 23, 2009 at 03:52, Michael Snyder wrote: > Joel Brobecker wrote: >>> >>> 2009-10-19 =A0Michael Snyder =A0 >>> >>> =A0 =A0 =A0 =A0* gdb.reverse/break-precsave.exp: New test. >>> =A0 =A0 =A0 =A0* gdb.reverse/consecutive-precsave.exp: Ditto. >>> =A0 =A0 =A0 =A0* gdb.reverse/finish-precsave.exp: Ditto. >>> =A0 =A0 =A0 =A0* gdb.reverse/i386-precsave.exp: Ditto. >>> =A0 =A0 =A0 =A0* gdb.reverse/machinestate-precsave.exp: Ditto. >>> =A0 =A0 =A0 =A0* gdb.reverse/sigall-precsave.exp: Ditto. >>> =A0 =A0 =A0 =A0* gdb.reverse/solilb-precsave.exp: Ditto. >>> =A0 =A0 =A0 =A0* gdb.reverse/step-precsave.exp: Ditto. >>> =A0 =A0 =A0 =A0* gdb.reverse/until-precsave.exp: Ditto. >>> =A0 =A0 =A0 =A0* gdb.reverse/watch-precsave.exp: Ditto. >> >> I only quickly scanned the files, since they are essentially duplicates >> of already-existing testcases. I didn't expect to find anything, but >> I actually did notice a couple of things: >> >> =A0- Use of send_gdb/gdb_expect which should be replaced by >> gdb_test_multiple >> =A0 =A0(too bad we didn't catch those in the current ones when the testc= ases >> =A0 =A0were checked in) >> =A0- unnecessary "return 0" at the end of the script. >> >> I think we shouldn't put anything unnecessary in these files, as we tend >> to forget why we put them, and the next developer who, like me, writes >> testcase by copy/paste, will repeat the pattern because he's afraid of >> breaking something otherwise. > > OK, committed with *some* of the gdb_expects removed. > I'm not entirely sure how to remove some of them, and > I've no objection to anyone else banging on them. =A0;-) > > >