From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11907 invoked by alias); 20 Oct 2009 03:17:45 -0000 Received: (qmail 11897 invoked by uid 22791); 20 Oct 2009 03:17:44 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-pz0-f189.google.com (HELO mail-pz0-f189.google.com) (209.85.222.189) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Oct 2009 03:17:40 +0000 Received: by pzk27 with SMTP id 27so1700166pzk.12 for ; Mon, 19 Oct 2009 20:17:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.209.12 with SMTP id h12mr396011wfg.53.1256008659082; Mon, 19 Oct 2009 20:17:39 -0700 (PDT) In-Reply-To: References: <20090928160728.GB9003@adacore.com> <20091014021007.GO5272@adacore.com> <20091014024202.GQ5272@adacore.com> <20091015045834.GY5272@adacore.com> <20091015162326.GA5272@adacore.com> <4AD75806.9070705@vmware.com> From: Hui Zhu Date: Tue, 20 Oct 2009 03:17:00 -0000 Message-ID: Subject: Re: [RFA] let record_resume fail immediately on error To: Michael Snyder Cc: Joel Brobecker , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00461.txt.bz2 Update follow cvs-head. Please help me with it. Thanks, Hui 2009-10-20 Hui Zhu * record.c (record_resume_error): Deleted. (record_resume): Call record_message. (record_wait): Deleted record_resume_error. Set status when do_record_message need stop the inferior. --- record.c | 29 ++++++++++------------------- 1 file changed, 10 insertions(+), 19 deletions(-) --- a/record.c +++ b/record.c @@ -679,7 +679,6 @@ record_close (int quitting) } static int record_resume_step = 0; -static int record_resume_error; static void record_resume (struct target_ops *ops, ptid_t ptid, int step, @@ -689,15 +688,11 @@ record_resume (struct target_ops *ops, p if (!RECORD_IS_REPLAY) { - if (do_record_message (get_current_regcache (), signal)) - { - record_resume_error = 0; - } - else - { - record_resume_error = 1; - return; - } + struct record_message_args args; + + args.regcache = get_current_regcache (); + args.signal = signal; + record_message (&args); record_beneath_to_resume (record_beneath_to_resume_ops, ptid, 1, signal); } @@ -749,14 +744,6 @@ record_wait (struct target_ops *ops, if (!RECORD_IS_REPLAY) { - if (record_resume_error) - { - /* If record_resume get error, return directly. */ - status->kind = TARGET_WAITKIND_STOPPED; - status->value.sig = TARGET_SIGNAL_ABRT; - return inferior_ptid; - } - if (record_resume_step) { /* This is a single step. */ @@ -802,7 +789,11 @@ record_wait (struct target_ops *ops, Therefore we will not return to gdb. Record the insn and resume. */ if (!do_record_message (regcache, TARGET_SIGNAL_0)) - break; + { + status->kind = TARGET_WAITKIND_STOPPED; + status->value.sig = TARGET_SIGNAL_0; + break; + } record_beneath_to_resume (record_beneath_to_resume_ops, ptid, 1,