From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12278 invoked by alias); 15 Oct 2009 07:17:03 -0000 Received: (qmail 12265 invoked by uid 22791); 15 Oct 2009 07:17:02 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-pz0-f192.google.com (HELO mail-pz0-f192.google.com) (209.85.222.192) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Oct 2009 07:16:57 +0000 Received: by pzk30 with SMTP id 30so578033pzk.24 for ; Thu, 15 Oct 2009 00:16:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.143.129.7 with SMTP id g7mr798995wfn.43.1255591015350; Thu, 15 Oct 2009 00:16:55 -0700 (PDT) In-Reply-To: <20091015045834.GY5272@adacore.com> References: <4ABE5E8D.8080209@vmware.com> <20090928160728.GB9003@adacore.com> <20090929212910.GG6362@adacore.com> <20091014021007.GO5272@adacore.com> <20091014024202.GQ5272@adacore.com> <20091015045834.GY5272@adacore.com> From: Hui Zhu Date: Thu, 15 Oct 2009 07:17:00 -0000 Message-ID: Subject: Re: [RFA] let record_resume fail immediately on error To: Joel Brobecker Cc: Michael Snyder , "gdb-patches@sourceware.org" Content-Type: multipart/mixed; boundary=000e0cd72db67405d20475f410ff X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00332.txt.bz2 --000e0cd72db67405d20475f410ff Content-Type: text/plain; charset=ISO-8859-1 Content-length: 2024 Thanks Joel, I think stop with sigtrap looks not very well. So I change it to sigint. Please help me with it. Thanks, Hui 2009-10-15 Hui Zhu * record.c (record_resume_error): Deleted. (record_resume): Call record_message. (record_wait): Deleted record_resume_error. Set status when do_record_message need stop the inferior. --- record.c | 25 +++++++------------------ 1 file changed, 7 insertions(+), 18 deletions(-) --- a/record.c +++ b/record.c @@ -566,7 +566,6 @@ record_close (int quitting) } static int record_resume_step = 0; -static int record_resume_error; static void record_resume (struct target_ops *ops, ptid_t ptid, int step, @@ -576,15 +575,11 @@ record_resume (struct target_ops *ops, p if (!RECORD_IS_REPLAY) { - if (do_record_message (get_current_regcache (), signal)) - { - record_resume_error = 0; - } - else - { - record_resume_error = 1; - return; - } + struct record_message_args args; + + args.regcache = get_current_regcache (); + args.signal = signal; + record_message (&args); record_beneath_to_resume (record_beneath_to_resume_ops, ptid, 1, signal); } @@ -636,14 +631,6 @@ record_wait (struct target_ops *ops, if (!RECORD_IS_REPLAY) { - if (record_resume_error) - { - /* If record_resume get error, return directly. */ - status->kind = TARGET_WAITKIND_STOPPED; - status->value.sig = TARGET_SIGNAL_ABRT; - return inferior_ptid; - } - if (record_resume_step) { /* This is a single step. */ @@ -689,6 +676,8 @@ record_wait (struct target_ops *ops, if (!do_record_message (get_current_regcache (), TARGET_SIGNAL_0)) { + status->kind = TARGET_WAITKIND_STOPPED; + status->value.sig = TARGET_SIGNAL_INT; break; } record_beneath_to_resume (record_beneath_to_resume_ops, --000e0cd72db67405d20475f410ff Content-Type: text/plain; charset=US-ASCII; name="prec-fix-error-handler.txt" Content-Disposition: attachment; filename="prec-fix-error-handler.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g0t6nx9k0 Content-length: 2266 LS0tCiByZWNvcmQuYyB8ICAgMjUgKysrKysrKy0tLS0tLS0tLS0tLS0tLS0t LQogMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRp b25zKC0pCgotLS0gYS9yZWNvcmQuYworKysgYi9yZWNvcmQuYwpAQCAtNTY2 LDcgKzU2Niw2IEBAIHJlY29yZF9jbG9zZSAoaW50IHF1aXR0aW5nKQogfQog CiBzdGF0aWMgaW50IHJlY29yZF9yZXN1bWVfc3RlcCA9IDA7Ci1zdGF0aWMg aW50IHJlY29yZF9yZXN1bWVfZXJyb3I7CiAKIHN0YXRpYyB2b2lkCiByZWNv cmRfcmVzdW1lIChzdHJ1Y3QgdGFyZ2V0X29wcyAqb3BzLCBwdGlkX3QgcHRp ZCwgaW50IHN0ZXAsCkBAIC01NzYsMTUgKzU3NSwxMSBAQCByZWNvcmRfcmVz dW1lIChzdHJ1Y3QgdGFyZ2V0X29wcyAqb3BzLCBwCiAKICAgaWYgKCFSRUNP UkRfSVNfUkVQTEFZKQogICAgIHsKLSAgICAgIGlmIChkb19yZWNvcmRfbWVz c2FnZSAoZ2V0X2N1cnJlbnRfcmVnY2FjaGUgKCksIHNpZ25hbCkpCi0gICAg ICAgIHsKLSAgICAgICAgICByZWNvcmRfcmVzdW1lX2Vycm9yID0gMDsKLSAg ICAgICAgfQotICAgICAgZWxzZQotICAgICAgICB7Ci0gICAgICAgICAgcmVj b3JkX3Jlc3VtZV9lcnJvciA9IDE7Ci0gICAgICAgICAgcmV0dXJuOwotICAg ICAgICB9CisgICAgICBzdHJ1Y3QgcmVjb3JkX21lc3NhZ2VfYXJncyBhcmdz OworCisgICAgICBhcmdzLnJlZ2NhY2hlID0gZ2V0X2N1cnJlbnRfcmVnY2Fj aGUgKCk7CisgICAgICBhcmdzLnNpZ25hbCA9IHNpZ25hbDsKKyAgICAgIHJl Y29yZF9tZXNzYWdlICgmYXJncyk7CiAgICAgICByZWNvcmRfYmVuZWF0aF90 b19yZXN1bWUgKHJlY29yZF9iZW5lYXRoX3RvX3Jlc3VtZV9vcHMsIHB0aWQs IDEsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNpZ25hbCk7 CiAgICAgfQpAQCAtNjM2LDE0ICs2MzEsNiBAQCByZWNvcmRfd2FpdCAoc3Ry dWN0IHRhcmdldF9vcHMgKm9wcywKIAogICBpZiAoIVJFQ09SRF9JU19SRVBM QVkpCiAgICAgewotICAgICAgaWYgKHJlY29yZF9yZXN1bWVfZXJyb3IpCi0J ewotCSAgLyogSWYgcmVjb3JkX3Jlc3VtZSBnZXQgZXJyb3IsIHJldHVybiBk aXJlY3RseS4gICovCi0JICBzdGF0dXMtPmtpbmQgPSBUQVJHRVRfV0FJVEtJ TkRfU1RPUFBFRDsKLQkgIHN0YXR1cy0+dmFsdWUuc2lnID0gVEFSR0VUX1NJ R05BTF9BQlJUOwotCSAgcmV0dXJuIGluZmVyaW9yX3B0aWQ7Ci0JfQotCiAg ICAgICBpZiAocmVjb3JkX3Jlc3VtZV9zdGVwKQogCXsKIAkgIC8qIFRoaXMg aXMgYSBzaW5nbGUgc3RlcC4gICovCkBAIC02ODksNiArNjc2LDggQEAgcmVj b3JkX3dhaXQgKHN0cnVjdCB0YXJnZXRfb3BzICpvcHMsCiAJCSAgICAgIGlm ICghZG9fcmVjb3JkX21lc3NhZ2UgKGdldF9jdXJyZW50X3JlZ2NhY2hlICgp LAogCQkJCQkgICAgICBUQVJHRVRfU0lHTkFMXzApKQogCQkJeworICAgICAg ICAgICAgICAgICAgICAgICAgICBzdGF0dXMtPmtpbmQgPSBUQVJHRVRfV0FJ VEtJTkRfU1RPUFBFRDsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgc3Rh dHVzLT52YWx1ZS5zaWcgPSBUQVJHRVRfU0lHTkFMX0lOVDsKICAgICAgICAg ICAgICAgICAgICAgICAgICAgYnJlYWs7CiAJCQl9CiAJCSAgICAgIHJlY29y ZF9iZW5lYXRoX3RvX3Jlc3VtZSAocmVjb3JkX2JlbmVhdGhfdG9fcmVzdW1l X29wcywK --000e0cd72db67405d20475f410ff--