From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5125 invoked by alias); 10 Oct 2009 07:57:49 -0000 Received: (qmail 5113 invoked by uid 22791); 10 Oct 2009 07:57:49 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-px0-f202.google.com (HELO mail-px0-f202.google.com) (209.85.216.202) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 10 Oct 2009 07:57:44 +0000 Received: by pxi40 with SMTP id 40so7988950pxi.24 for ; Sat, 10 Oct 2009 00:57:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.67.39 with SMTP id p39mr303174wfa.204.1255161463073; Sat, 10 Oct 2009 00:57:43 -0700 (PDT) In-Reply-To: <20091010023344.GD5272@adacore.com> References: <1255095434-30271-1-git-send-email-freephp@gmail.com> <20091009172119.GA5272@adacore.com> <7d77a27d0910091838l76217714m92a55afc2fdf25f3@mail.gmail.com> <20091010023344.GD5272@adacore.com> From: Hui Zhu Date: Sat, 10 Oct 2009 07:57:00 -0000 Message-ID: Subject: Re: [PATCH] Add xgetbv/xsetbv instructions support for precord. To: Joel Brobecker , Jiang Jilin , Michael Snyder Cc: gdb-patches ml Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00204.txt.bz2 Thanks Jilin, Michael and Joel. I think this patch is very good. We can find the "xgetbv" and "xsetbv" in "Intel=AE 64 and IA-32 Architectures Software Developer=92s Manual Volume 2B: Instruction Set Reference, N-Z" Vol. 2B 4-509 and Vol. 2B 4-529. And I test this patch with reverse test, everything is OK. BTW, I think the prec code that handle "0f 01" is not very well. Jilin, do you interest with make this code better? Thanks, Hui On Sat, Oct 10, 2009 at 10:33, Joel Brobecker wrote: >> Sorry, but I don't know how to verify it, please help me with it. When >> I ran 'make check', it displayed some 'FAIL' messages even before my >> patch, and I noticed runtest uses >> /usr/share/dejagnu/baseboards/unix.exp, which is not given by >> http://sourceware.org/gdb/wiki/ReversibleDebugging. =A0How to use >> runtest to test precord.exp only? > > I will let Michael and Hui explain to you how to use the special > board file precord.exp. > > The FAILs are expected, as is simply impossible to mark all failures > for all platforms. =A0There are too many variables, such as your compiler, > your kernel, etc etc etc. =A0So what you need to do is run the testsuite > before and after your patch, saving the contents of gdb.sum after the > first run, and then do a comparison of the two files, to make sure > that your patch did not cause any unexpected change. =A0Some tests are > a little unpredictable, and cause you to see some apparent regressions > that may not be caused by your patch. You'll have to use your judgement > in these cases. > >> No, I don't have an FSF =A0assignment on file, but I'd like to. How to >> have an FSF assignment on file? > > I'll send you the form to fill in and send to the FSF immediately. > > -- > Joel >