From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19134 invoked by alias); 29 Sep 2009 02:33:19 -0000 Received: (qmail 19125 invoked by uid 22791); 29 Sep 2009 02:33:18 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-px0-f185.google.com (HELO mail-px0-f185.google.com) (209.85.216.185) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Sep 2009 02:33:11 +0000 Received: by pxi15 with SMTP id 15so5251429pxi.25 for ; Mon, 28 Sep 2009 19:33:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.195.7 with SMTP id s7mr274555wff.293.1254191590072; Mon, 28 Sep 2009 19:33:10 -0700 (PDT) In-Reply-To: <20090928160728.GB9003@adacore.com> References: <4AA5D713.1060305@vmware.com> <4AA68C92.7070905@vmware.com> <4ABE5E8D.8080209@vmware.com> <20090928160728.GB9003@adacore.com> From: Hui Zhu Date: Tue, 29 Sep 2009 02:33:00 -0000 Message-ID: Subject: Re: [RFA] let record_resume fail immediately on error To: Joel Brobecker Cc: Michael Snyder , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00902.txt.bz2 On Tue, Sep 29, 2009 at 00:07, Joel Brobecker wrote: >> With the fix error patch: > [...] >> (gdb) c >> Continuing. >> Process record doesn't support instruction rdtsc. >> Process record doesn't support instruction 0xf31 at address 0x8048352. >> main (argc=3D, argv=3D, >> envp=3D) at 4.c:14 >> 14 =A0 =A0 =A0 =A0 =A0 =A0asm ("rdtsc"); >> Process record: failed to record execution log. >> (gdb) >> Continuing. >> Process record doesn't support instruction rdtsc. >> Process record doesn't support instruction 0xf31 at address 0x8048352. >> main (argc=3D, argv=3D, >> envp=3D) at 4.c:14 >> 14 =A0 =A0 =A0 =A0 =A0 =A0asm ("rdtsc"); >> Process record: failed to record execution log. > > I am going to defer to Michael who understands the issues much better > than I do; I am a little confused by what you are suggesting. On the > one hand, I understand that the problem you're trying to deal with > is the case when the inferior exits. Are you talking about normal > exiting as well as abnormal exiting like in your case? In any event, > what you show in your example looks like a bandaid that will only > handle a specific situation: In other words, it works around the issue > because you no longer let the inferior exit. Sorry I didn't talk it very clear. Let me try it. Sometime, prec will get a error for example some insn didn't support. But it didn't affect the inferior, so customer can close the prec and keep debug the inferior. But prec has the bug that will make the inferior exit when get the error in prec part (like the example that I post in prev mail). It is not right because inferior is OK. So I make the patch for it. After patch the patch, the inferior will not exit in this prec part error. Thanks, Hui