From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13090 invoked by alias); 29 Sep 2009 02:07:28 -0000 Received: (qmail 13069 invoked by uid 22791); 29 Sep 2009 02:07:27 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-pz0-f189.google.com (HELO mail-pz0-f189.google.com) (209.85.222.189) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Sep 2009 02:07:20 +0000 Received: by pzk27 with SMTP id 27so2655086pzk.12 for ; Mon, 28 Sep 2009 19:07:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.75.5 with SMTP id x5mr278985wfa.197.1254190038095; Mon, 28 Sep 2009 19:07:18 -0700 (PDT) In-Reply-To: References: <4ABE96C8.6070702@vmware.com> <20090928155853.GA9003@adacore.com> <4AC0FD65.2080500@vmware.com> From: Hui Zhu Date: Tue, 29 Sep 2009 02:07:00 -0000 Message-ID: Subject: Re: Record segfault To: Marc Khouzam Cc: Joel Brobecker , gdb-patches ml , Michael Snyder Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00901.txt.bz2 On Tue, Sep 29, 2009 at 10:05, Hui Zhu wrote: > Checked in to 7.0 branch. > > Thanks for your help, Joel and Michael. Ah, sorry for it. And thanks a lot, Marc. :) Hui > > Hui > > On Tue, Sep 29, 2009 at 02:16, Michael Snyder wrote: >> Joel Brobecker wrote: >>> >>> Michael, >>> >>>> This seems fine to me. =A0Please check it into the main branch, >>>> but don't add it to the release branch unless Joel says it's OK. >>> >>> It seems like a worthwhile patch to have, since it fixes a SEGV >>> (right?). Are you confident about the patch? It seems relatively >>> straightforward. My only comment is that it eliminates a query >>> when the user types a record stop - is that desirable? I guess >>> it is: What are the chances of someone typing "record stop" and >>> not wanting to stop the recording session? >>> >>> In other words: I am ok with the patch being applied to the branch. >>> If you are, can you give Hui the go-ahead? >> >> OK, then, "go ahead", Hui. =A0 ;-) >> >