Re: [RFA] let record_resume fail immediately on error

Hui Zhu
2009-10-16T03:37:07Z

> Hui, try returning signal zero. GDB will just report that you
> stopped, without saying anything about a signal.
>
> Old trick of mine. ;-)

Cool! The signal 0 make the output like following:
The next instruction is syscall exit_group. It will make the program
exit. Do you want to stop the program?([y] or n)
Process record: inferior program stopped.

[process 25901] #1 stopped.
0xb7fe3405 in __kernel_vsyscall ()
(gdb) rc

Or:
Process record doesn't support instruction rdtsc.
Process record doesn't support instruction 0xf31 at address 0x8048391.
Process record: failed to record execution log.

[process 25947] #1 stopped.
main (argc=<value optimized out>, argv=<value optimized out>,
envp=<value optimized out>) at 2.c:16
16 asm ("rdtsc");

I make a new patch for it. Please help me with it.

Thanks,
Hui

2009-10-16 Hui Zhu <teawater@gmail.com>

* record.c (record_resume_error): Deleted.
(record_resume): Call record_message.
(record_wait): Deleted record_resume_error.
Set status when do_record_message need stop the inferior.
---
record.c | 25 +++++++------------------
1 file changed, 7 insertions(+), 18 deletions(-)

--- a/record.c
+++ b/record.c
@@ -643,7 +643,6 @@ record_close (int quitting)
}

static int record_resume_step = 0;
-static int record_resume_error;

static void
record_resume (struct target_ops *ops, ptid_t ptid, int step,
@@ -653,15 +652,11 @@ record_resume (struct target_ops *ops, p

if (!RECORD_IS_REPLAY)
{
- if (do_record_message (get_current_regcache (), signal))
- {
- record_resume_error = 0;
- }
- else
- {
- record_resume_error = 1;
- return;
- }
+ struct record_message_args args;
+
+ args.regcache = get_current_regcache ();
+ args.signal = signal;
+ record_message (&args);
record_beneath_to_resume (record_beneath_to_resume_ops, ptid, 1,
signal);
}
@@ -713,14 +708,6 @@ record_wait (struct target_ops *ops,

if (!RECORD_IS_REPLAY)
{
- if (record_resume_error)
- {
- /* If record_resume get error, return directly. */
- status->kind = TARGET_WAITKIND_STOPPED;
- status->value.sig = TARGET_SIGNAL_ABRT;
- return inferior_ptid;
- }
-
if (record_resume_step)
{
/* This is a single step. */
@@ -766,6 +753,8 @@ record_wait (struct target_ops *ops,
if (!do_record_message (get_current_regcache (),
TARGET_SIGNAL_0))
{
+ status->kind = TARGET_WAITKIND_STOPPED;
+ status->value.sig = TARGET_SIGNAL_0;
break;
}
record_beneath_to_resume (record_beneath_to_resume_ops,