Re: [RFA] let record_resume fail immediately on error

Hui Zhu
2009-09-08T07:23:43Z

The "record_resume_error" in gdb-cvs is to make user after get a error
of record_message, they can "record stop" close the record and keep
debug the inferior.

Thanks,
Hui

On Tue, Sep 8, 2009 at 14:58, Joel Brobecker<brobecker@adacore.com> wrote:
>>    if (!RECORD_IS_REPLAY)
>>      {
>>        if (do_record_message (get_current_regcache ()))
>> -        {
>> -          record_resume_error = 0;
>> -        }
>> -      else
>> -        {
>> -          record_resume_error = 1;
>> -          return;
>> -        }
>> +     internal_error (__FILE__, __LINE__,
>> +                     _("record_resume: do_record_message failed."));
>> +
>
> Forgive me if I'm wrong, as I don't know the record.c code at all, but
> I cannot help but think that the internal_error is suspicious here.
> Why is this an internal_error?
>
> --
> Joel
>