Re: [RFA] let record_resume fail immediately on error

Hui Zhu
2009-09-29T02:33:19Z

On Tue, Sep 29, 2009 at 00:07, Joel Brobecker <brobecker@adacore.com> wrote:
>> With the fix error patch:
> [...]
>> (gdb) c
>> Continuing.
>> Process record doesn't support instruction rdtsc.
>> Process record doesn't support instruction 0xf31 at address 0x8048352.
>> main (argc=<value optimized out>, argv=<value optimized out>,
>> envp=<value optimized out>) at 4.c:14
>> 14            asm ("rdtsc");
>> Process record: failed to record execution log.
>> (gdb)
>> Continuing.
>> Process record doesn't support instruction rdtsc.
>> Process record doesn't support instruction 0xf31 at address 0x8048352.
>> main (argc=<value optimized out>, argv=<value optimized out>,
>> envp=<value optimized out>) at 4.c:14
>> 14            asm ("rdtsc");
>> Process record: failed to record execution log.
>
> I am going to defer to Michael who understands the issues much better
> than I do; I am a little confused by what you are suggesting. On the
> one hand, I understand that the problem you're trying to deal with
> is the case when the inferior exits. Are you talking about normal
> exiting as well as abnormal exiting like in your case? In any event,
> what you show in your example looks like a bandaid that will only
> handle a specific situation: In other words, it works around the issue
> because you no longer let the inferior exit.

Sorry I didn't talk it very clear. Let me try it.

Sometime, prec will get a error for example some insn didn't support.
But it didn't affect the inferior, so customer can close the prec and
keep debug the inferior.

But prec has the bug that will make the inferior exit when get the
error in prec part (like the example that I post in prev mail). It is
not right because inferior is OK. So I make the patch for it.

After patch the patch, the inferior will not exit in this prec part error.

Thanks,
Hui