From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-66594-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 5574 invoked by alias); 8 Sep 2009 07:25:56 -0000
Received: (qmail 5516 invoked by uid 22791); 8 Sep 2009 07:25:55 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail-pz0-f181.google.com (HELO mail-pz0-f181.google.com) (209.85.222.181)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Sep 2009 07:25:46 +0000
Received: by pzk11 with SMTP id 11so1582852pzk.3         for <gdb-patches@sourceware.org>; Tue, 08 Sep 2009 00:25:44 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.142.202.21 with SMTP id z21mr592668wff.235.1252394744095; Tue,  	08 Sep 2009 00:25:44 -0700 (PDT)
In-Reply-To: <daef60380909080023q54fc9147k2a231615634e32c@mail.gmail.com>
References: <4AA5D713.1060305@vmware.com> <20090908065843.GO30677@adacore.com>  	<daef60380909080023q54fc9147k2a231615634e32c@mail.gmail.com>
From: Hui Zhu <teawater@gmail.com>
Date: Tue, 08 Sep 2009 07:25:00 -0000
Message-ID: <daef60380909080025i7961a0efh5fac61f742cf4769@mail.gmail.com>
Subject: Re: [RFA] let record_resume fail immediately on error
To: Joel Brobecker <brobecker@adacore.com>, Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-09/txt/msg00189.txt.bz2

If GDB call error in record_resume, user cannot keep debug the inferior.

Hui

On Tue, Sep 8, 2009 at 15:23, Hui Zhu<teawater@gmail.com> wrote:
> The "record_resume_error" in gdb-cvs is to make user after get a error
> of record_message, they can "record stop" close the record and keep
> debug the inferior.
>
> Thanks,
> Hui
>
> On Tue, Sep 8, 2009 at 14:58, Joel Brobecker<brobecker@adacore.com> wrote:
>>> =A0 =A0if (!RECORD_IS_REPLAY)
>>> =A0 =A0 =A0{
>>> =A0 =A0 =A0 =A0if (do_record_message (get_current_regcache ()))
>>> - =A0 =A0 =A0 =A0{
>>> - =A0 =A0 =A0 =A0 =A0record_resume_error =3D 0;
>>> - =A0 =A0 =A0 =A0}
>>> - =A0 =A0 =A0else
>>> - =A0 =A0 =A0 =A0{
>>> - =A0 =A0 =A0 =A0 =A0record_resume_error =3D 1;
>>> - =A0 =A0 =A0 =A0 =A0return;
>>> - =A0 =A0 =A0 =A0}
>>> + =A0 =A0 internal_error (__FILE__, __LINE__,
>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 _("record_resume: do_record_m=
essage failed."));
>>> +
>>
>> Forgive me if I'm wrong, as I don't know the record.c code at all, but
>> I cannot help but think that the internal_error is suspicious here.
>> Why is this an internal_error?
>>
>> --
>> Joel
>>
>