Re: [PATCH] Fix cygwin build error with i386-linux-tdep.c

Joel Brobecker
2009-09-05T21:15:55Z

> I could suggest casting it to (unsigned int), but it wouldn't
> really make any difference, would it? Mark -- Jiang -- would
> that make you guys more comfortable?

Short term, I'd rather see us read the syscall number as a signed
number since this is what record_linux_system_call expects. We can
decide whether to rationalize as a signed or unsigned as a separate
patch. I think Mark was OK with the patch I sent yesterday, except
that he said we should add a check against negative values.

There is also a cast that is unnecessary in the error message.
Hui can use %s/paddress rather than %d/cast.

--
Joel