Re: [PATCH] Fix cygwin build error with i386-linux-tdep.c

Mark Kettenis
2009-08-31T15:46:25Z

> From: Hui Zhu <teawater@gmail.com>
> Date: Mon, 31 Aug 2009 16:48:33 +0800
>
> On Mon, Aug 31, 2009 at 16:45, Jiang Jilin<freephp@gmail.com> wrote:
> >
> > I think it's not very sensible to cast unsigned to signed, think about
> > if the unsigned value is _very_ big.
> >
>
> This is syscall id, it will not _very_ big.

Jiang has a point here though. The cast is weird, and only there
because it seems you can't make up your mind whether syscall numbers
are signed or unsigned. Some bits of code use signed integers and
some use unsigned integers. Once that inconsistency is fixed, all
these problems will disappear.

Mark