Re: [PATCH] Fix cygwin build error with i386-linux-tdep.c

Hui Zhu
2009-08-30T15:00:56Z

On Sun, Aug 30, 2009 at 22:19, Andreas Schwab<schwab@linux-m68k.org> wrote:
> Mark Kettenis <mark.kettenis@xs4all.nl> writes:
>
>>> From: Hui Zhu <teawater@gmail.com>
>>> Date: Sun, 30 Aug 2009 21:15:22 +0800
>>>
>>> Index: gdb/i386-linux-tdep.c
>>> ===================================================================
>>> --- gdb.orig/i386-linux-tdep.c       2009-08-23 21:17:37.000000000 +0800
>>> +++ gdb/i386-linux-tdep.c    2009-08-30 20:19:53.828125000 +0800
>>> @@ -374,7 +374,7 @@
>>>    if (tmpu32 > 499)
>
> Also, magic numbers like this are bad as well.
>
> Andreas.

If you don't mind, please let me fix it step by step. Let me fix the
reg value issue firest. :)

Thanks,
Hui

>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
> "And now for something completely different."
>