From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12075 invoked by alias); 6 Sep 2009 04:15:58 -0000 Received: (qmail 12064 invoked by uid 22791); 6 Sep 2009 04:15:56 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_00,SARE_LWSHORTT,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-pz0-f185.google.com (HELO mail-pz0-f185.google.com) (209.85.222.185) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 06 Sep 2009 04:15:51 +0000 Received: by pzk15 with SMTP id 15so1792676pzk.24 for ; Sat, 05 Sep 2009 21:15:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.7.10 with SMTP id 10mr425855wfg.137.1252210549187; Sat, 05 Sep 2009 21:15:49 -0700 (PDT) In-Reply-To: <20090905211541.GC30677@adacore.com> References: <200908301356.n7UDuO4a006136@brahms.sibelius.xs4all.nl> <4AA2CAFA.809@vmware.com> <20090905211541.GC30677@adacore.com> From: Hui Zhu Date: Sun, 06 Sep 2009 04:15:00 -0000 Message-ID: Subject: Re: [PATCH] Fix cygwin build error with i386-linux-tdep.c To: Joel Brobecker Cc: Michael Snyder , Mark Kettenis , "gdb-patches@sourceware.org" , freephp@gmail.com Content-Type: multipart/mixed; boundary=00504502aca5f7e63c0472e0fc5c X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00141.txt.bz2 --00504502aca5f7e63c0472e0fc5c Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 2257 On Sun, Sep 6, 2009 at 05:15, Joel Brobecker wrote: >> I could suggest casting it to (unsigned int), but it wouldn't >> really make any difference, would it? =A0Mark -- Jiang -- would >> that make you guys more comfortable? > > Short term, I'd rather see us read the syscall number as a signed > number since this is what record_linux_system_call expects. We can > decide whether to rationalize as a signed or unsigned as a separate > patch. I think Mark was OK with the patch I sent yesterday, except > that he said we should add a check against negative values. > > There is also a cast that is unnecessary in the error message. > Hui can use %s/paddress rather than %d/cast. > > -- > Joel > Hi guys, I make a new patch according to your comment. Thanks, Hui 2009-09-06 Michael Snyder Joel Brobecker Hui Zhu * i386-linux-tdep.c (i386_linux_intx80_sysenter_record): Change regcache_raw_read to regcache_raw_read_signed. Index: i386-linux-tdep.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/i386-linux-tdep.c,v retrieving revision 1.66 diff -u -p -r1.66 i386-linux-tdep.c --- i386-linux-tdep.c 10 Aug 2009 03:04:44 -0000 1.66 +++ i386-linux-tdep.c 6 Sep 2009 02:12:15 -0000 @@ -367,18 +367,19 @@ static int i386_linux_intx80_sysenter_record (struct regcache *regcache) { int ret; - uint32_t tmpu32; + LONGEST syscall; - regcache_raw_read (regcache, I386_EAX_REGNUM, (gdb_byte *) &tmpu32); + regcache_raw_read_signed (regcache, I386_EAX_REGNUM, &syscall); - if (tmpu32 > 499) + if (syscall < 0 || syscall > 499) { printf_unfiltered (_("Process record and replay target doesn't " - "support syscall number %u\n"), tmpu32); + "support syscall number %s\n"), + plongest (syscall)); return -1; } - ret =3D record_linux_system_call (tmpu32, regcache, + ret =3D record_linux_system_call (syscall, regcache, &i386_linux_record_tdep); if (ret) return ret; --00504502aca5f7e63c0472e0fc5c Content-Type: text/plain; charset=US-ASCII; name="longest.txt" Content-Disposition: attachment; filename="longest.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fz99swd60 Content-length: 1473 SW5kZXg6IGkzODYtbGludXgtdGRlcC5jCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KUkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvaTM4Ni1saW51eC10ZGVw LmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNjYKZGlmZiAtdSAtcCAtcjEu NjYgaTM4Ni1saW51eC10ZGVwLmMKLS0tIGkzODYtbGludXgtdGRlcC5jCTEw IEF1ZyAyMDA5IDAzOjA0OjQ0IC0wMDAwCTEuNjYKKysrIGkzODYtbGludXgt dGRlcC5jCTYgU2VwIDIwMDkgMDI6MTI6MTUgLTAwMDAKQEAgLTM2NywxOCAr MzY3LDE5IEBAIHN0YXRpYyBpbnQKIGkzODZfbGludXhfaW50eDgwX3N5c2Vu dGVyX3JlY29yZCAoc3RydWN0IHJlZ2NhY2hlICpyZWdjYWNoZSkKIHsKICAg aW50IHJldDsKLSAgdWludDMyX3QgdG1wdTMyOworICBMT05HRVNUIHN5c2Nh bGw7CiAKLSAgcmVnY2FjaGVfcmF3X3JlYWQgKHJlZ2NhY2hlLCBJMzg2X0VB WF9SRUdOVU0sIChnZGJfYnl0ZSAqKSAmdG1wdTMyKTsKKyAgcmVnY2FjaGVf cmF3X3JlYWRfc2lnbmVkIChyZWdjYWNoZSwgSTM4Nl9FQVhfUkVHTlVNLCAm c3lzY2FsbCk7CiAKLSAgaWYgKHRtcHUzMiA+IDQ5OSkKKyAgaWYgKHN5c2Nh bGwgPCAwIHx8IHN5c2NhbGwgPiA0OTkpCiAgICAgewogICAgICAgcHJpbnRm X3VuZmlsdGVyZWQgKF8oIlByb2Nlc3MgcmVjb3JkIGFuZCByZXBsYXkgdGFy Z2V0IGRvZXNuJ3QgIgotICAgICAgICAgICAgICAgICAgICAgICAgICAgInN1 cHBvcnQgc3lzY2FsbCBudW1iZXIgJXVcbiIpLCB0bXB1MzIpOworICAgICAg ICAgICAgICAgICAgICAgICAgICAgInN1cHBvcnQgc3lzY2FsbCBudW1iZXIg JXNcbiIpLCAKKwkJCSBwbG9uZ2VzdCAoc3lzY2FsbCkpOwogICAgICAgcmV0 dXJuIC0xOwogICAgIH0KIAotICByZXQgPSByZWNvcmRfbGludXhfc3lzdGVt X2NhbGwgKHRtcHUzMiwgcmVnY2FjaGUsCisgIHJldCA9IHJlY29yZF9saW51 eF9zeXN0ZW1fY2FsbCAoc3lzY2FsbCwgcmVnY2FjaGUsCiAJCQkJICAmaTM4 Nl9saW51eF9yZWNvcmRfdGRlcCk7CiAgIGlmIChyZXQpCiAgICAgcmV0dXJu IHJldDsK --00504502aca5f7e63c0472e0fc5c--