From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-66366-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2239 invoked by alias); 30 Aug 2009 15:00:56 -0000
Received: (qmail 2227 invoked by uid 22791); 30 Aug 2009 15:00:55 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail-iw0-f183.google.com (HELO mail-iw0-f183.google.com) (209.85.223.183)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 30 Aug 2009 15:00:48 +0000
Received: by iwn13 with SMTP id 13so1435965iwn.12         for <gdb-patches@sourceware.org>; Sun, 30 Aug 2009 08:00:46 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.231.6.87 with SMTP id 23mr5088298iby.19.1251644446083; Sun, 30  	Aug 2009 08:00:46 -0700 (PDT)
In-Reply-To: <m2skf9mlio.fsf@igel.home>
References: <daef60380908300615u40f59a38t7d2c2f2252c5924d@mail.gmail.com>  	<200908301356.n7UDuO4a006136@brahms.sibelius.xs4all.nl> <m2skf9mlio.fsf@igel.home>
From: Hui Zhu <teawater@gmail.com>
Date: Sun, 30 Aug 2009 15:14:00 -0000
Message-ID: <daef60380908300800g1c9e847k40e43c319da4c86a@mail.gmail.com>
Subject: Re: [PATCH] Fix cygwin build error with i386-linux-tdep.c
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>, gdb-patches@sourceware.org, msnyder@vmware.com
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-08/txt/msg00565.txt.bz2

On Sun, Aug 30, 2009 at 22:19, Andreas Schwab<schwab@linux-m68k.org> wrote:
> Mark Kettenis <mark.kettenis@xs4all.nl> writes:
>
>>> From: Hui Zhu <teawater@gmail.com>
>>> Date: Sun, 30 Aug 2009 21:15:22 +0800
>>>
>>> Index: gdb/i386-linux-tdep.c
>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>>> --- gdb.orig/i386-linux-tdep.c =A0 =A0 =A0 2009-08-23 21:17:37.00000000=
0 +0800
>>> +++ gdb/i386-linux-tdep.c =A0 =A02009-08-30 20:19:53.828125000 +0800
>>> @@ -374,7 +374,7 @@
>>> =A0 =A0if (tmpu32 > 499)
>
> Also, magic numbers like this are bad as well.
>
> Andreas.

If you don't mind, please let me fix it step by step.  Let me fix the
reg value issue firest.  :)

Thanks,
Hui

>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint =3D 58CA 54C7 6D53 942B 1756 =A001D3 44D5 214B 8276 4=
ED5
> "And now for something completely different."
>