From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32556 invoked by alias); 22 Jul 2009 05:37:04 -0000 Received: (qmail 32537 invoked by uid 22791); 22 Jul 2009 05:37:02 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-pz0-f203.google.com (HELO mail-pz0-f203.google.com) (209.85.222.203) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Jul 2009 05:36:54 +0000 Received: by pzk41 with SMTP id 41so2658467pzk.12 for ; Tue, 21 Jul 2009 22:36:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.104.19 with SMTP id b19mr113512wfc.185.1248241013054; Tue, 21 Jul 2009 22:36:53 -0700 (PDT) In-Reply-To: <6D19CA8D71C89C43A057926FE0D4ADAA07C00028@ecamlmw720.eamcs.ericsson.se> References: <6D19CA8D71C89C43A057926FE0D4ADAA07C00000@ecamlmw720.eamcs.ericsson.se> <6D19CA8D71C89C43A057926FE0D4ADAA07C00028@ecamlmw720.eamcs.ericsson.se> From: Hui Zhu Date: Wed, 22 Jul 2009 08:55:00 -0000 Message-ID: Subject: Re: [PRecord] Memory gets set even if users responds 'n' to query To: Marc Khouzam Cc: Michael Snyder , gdb-patches ml Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00532.txt.bz2 Checked in. Thanks, Hui On Tue, Jul 21, 2009 at 11:38, Marc Khouzam wrot= e: >> -----Original Message----- >> From: Hui Zhu [mailto:teawater@gmail.com] >> Sent: July-20-09 11:19 PM >> To: Marc Khouzam; Michael Snyder >> Cc: gdb-patches ml >> Subject: Re: [PRecord] Memory gets set even if users responds >> 'n' to query >> >> Thanks Marc. >> >> This issue is because when user answer n, function record_xfer_partial >> return -1 will not really cancel the memory change operation. >> I make a patch to change it to error. >> >> And I have check the code about register, it works OK. =A0Because it >> already use error. >> >> Please help me review it. > > Thanks Hui, I have tested your fix and it works for me. > > marc >