From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4991 invoked by alias); 18 Jul 2009 03:04:44 -0000 Received: (qmail 4983 invoked by uid 22791); 18 Jul 2009 03:04:43 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from wf-out-1314.google.com (HELO wf-out-1314.google.com) (209.85.200.168) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 18 Jul 2009 03:04:37 +0000 Received: by wf-out-1314.google.com with SMTP id 23so384633wfg.24 for ; Fri, 17 Jul 2009 20:04:35 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.254.2 with SMTP id b2mr385107wfi.203.1247886275076; Fri, 17 Jul 2009 20:04:35 -0700 (PDT) In-Reply-To: <200907171559.n6HFxHTx013069@d12av02.megacenter.de.ibm.com> References: <20090711175407.GA18892@host0.dyn.jankratochvil.net> <200907171559.n6HFxHTx013069@d12av02.megacenter.de.ibm.com> From: Hui Zhu Date: Sat, 18 Jul 2009 05:45:00 -0000 Message-ID: Subject: Re: [commit] Fix mi-disassemble.exp regression To: Ulrich Weigand Cc: Jan Kratochvil , Eli Zaretskii , tromey@redhat.com, msnyder@vmware.com, dje@google.com, mark.kettenis@xs4all.nl, gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00444.txt.bz2 Oops, sorry to forget it. Thanks. Hui On Fri, Jul 17, 2009 at 23:59, Ulrich Weigand wrote: > Jan Kratochvil wrote: > >> On Sat, 11 Jul 2009 16:15:00 +0200, Hui Zhu wrote: >> > Fixed and checked-in. >> >> this check-in >> =A0 =A0 =A0 http://sourceware.org/ml/gdb-cvs/2009-07/msg00089.html >> =A0 =A0 =A0 http://sourceware.org/ml/gdb-cvs/2009-07/msg00092.html > [snip] >> causes a regression on {x86_64,x86_64-32,i686}-fedora11-linux-gnu. > > This is caused by this part of Hui's patch: > > --- a/mi/mi-cmd-disas.c > +++ b/mi/mi-cmd-disas.c > @@ -156,6 +156,6 @@ mi_cmd_disassemble (char *command, char > > =A0 gdb_disassembly (gdbarch, uiout, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 file_string, > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0mixed_source_and_assembly, how_many,= low, high); > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0DISASSEMBLY_SOURCE, how_many, low, h= igh); > > =A0} > > Note how the new code completely ignores the mixed_source_and_assembly > flag (which is set from the mixed_mode MI parameter). > > The following patch fixes this. > Tested on powerpc64-linux, committed to mainline. > > Bye, > Ulrich > > ChangeLog: > > =A0 =A0 =A0 =A0* mi/mi-cmd-disas.c (mi_cmd_disassemble): Respect mixed_mo= de flag. > > Index: gdb/mi/mi-cmd-disas.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /cvs/src/src/gdb/mi/mi-cmd-disas.c,v > retrieving revision 1.31 > diff -u -p -r1.31 mi-cmd-disas.c > --- gdb/mi/mi-cmd-disas.c =A0 =A0 =A0 11 Jul 2009 14:04:23 -0000 =A0 =A0 = =A01.31 > +++ gdb/mi/mi-cmd-disas.c =A0 =A0 =A0 17 Jul 2009 15:50:06 -0000 > @@ -156,6 +156,6 @@ mi_cmd_disassemble (char *command, char > > =A0 gdb_disassembly (gdbarch, uiout, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 file_string, > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0DISASSEMBLY_SOURCE, how_many, low, h= igh); > - > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0mixed_source_and_assembly? DISASSEMB= LY_SOURCE : 0, > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0how_many, low, high); > =A0} > > > -- > =A0Dr. Ulrich Weigand > =A0GNU Toolchain for Linux on System z and Cell BE > =A0Ulrich.Weigand@de.ibm.com >