From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-65425-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 25201 invoked by alias); 16 Jul 2009 02:42:07 -0000
Received: (qmail 25174 invoked by uid 22791); 16 Jul 2009 02:42:07 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail-px0-f183.google.com (HELO mail-px0-f183.google.com) (209.85.216.183)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 16 Jul 2009 02:41:56 +0000
Received: by pxi13 with SMTP id 13so2356232pxi.12         for <gdb-patches@sourceware.org>; Wed, 15 Jul 2009 19:41:53 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.142.155.13 with SMTP id c13mr2021866wfe.326.1247712113489;  	Wed, 15 Jul 2009 19:41:53 -0700 (PDT)
In-Reply-To: <4A5CE7DB.5090501@vmware.com>
References: <4A5CE7DB.5090501@vmware.com>
From: Hui Zhu <teawater@gmail.com>
Date: Thu, 16 Jul 2009 07:45:00 -0000
Message-ID: <daef60380907151941r4491b66k6ba8e5553cd48a4f@mail.gmail.com>
Subject: Re: [patch] fix for step-reverse.exp
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-07/txt/msg00404.txt.bz2

On Wed, Jul 15, 2009 at 04:17, Michael Snyder<msnyder@vmware.com> wrote:
> Hui's amd64 patch was failing this test, because the test
> neglects to allow for the possibility that the call instruction
> is not the first instruction on the line.
>
> Hui, try it now.
>

It works very cool. Thanks.  :)

Hui


>
> 2009-07-14 =A0Michael Snyder =A0<msnyder@vmware.com>
>
> =A0 =A0 =A0 =A0* gdb.reverse/step-reverse.exp (stepi into function call):
> =A0 =A0 =A0 =A0Call instruction may not be first instruction in the line.
> =A0 =A0 =A0 =A0(reverse stepi from a function call): Used wrong line numb=
er.
>
> Index: gdb.reverse/step-reverse.exp
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /cvs/src/src/gdb/testsuite/gdb.reverse/step-reverse.exp,v
> retrieving revision 1.1
> diff -u -p -r1.1 step-reverse.exp
> --- gdb.reverse/step-reverse.exp =A0 =A0 =A0 =A027 Jun 2009 18:49:20 -000=
0 =A0 =A0 =A01.1
> +++ gdb.reverse/step-reverse.exp =A0 =A0 =A0 =A014 Jul 2009 20:16:42 -0000
> @@ -104,6 +104,10 @@ gdb_test_multiple "stepi" "$test_message
> =A0 =A0 =A0 =A0send_gdb "stepi\n"
> =A0 =A0 =A0 =A0exp_continue
> =A0 =A0 }
> + =A0 =A0-re "STEPI TEST.*$gdb_prompt $" {
> + =A0 =A0 =A0 send_gdb "stepi\n"
> + =A0 =A0 =A0 exp_continue
> + =A0 =A0}
> =A0}
>
> =A0# stepi thru return of a function call
> @@ -168,7 +172,7 @@ gdb_test_multiple "stepi" "$test_message
>
> =A0# stepi backward out of a function call
>
> -set stepi_location =A0[gdb_get_line_number "FINISH TEST" "$srcfile"]
> +set stepi_location =A0[gdb_get_line_number "STEPI TEST" "$srcfile"]
> =A0set test_message "reverse stepi from a function call"
> =A0gdb_test_multiple "stepi" "$test_message" {
> =A0 =A0 -re "ARRIVED IN CALLEE.*$gdb_prompt $" {
> @@ -178,7 +182,7 @@ gdb_test_multiple "stepi" "$test_message
> =A0 =A0 =A0 =A0send_gdb "stepi\n"
> =A0 =A0 =A0 =A0exp_continue
> =A0 =A0 }
> - =A0 =A0-re "${hex}\[ \t\]*$stepi_location.*STEPI TEST.*$gdb_prompt $" {
> + =A0 =A0-re "${hex} in main .*:$stepi_location.*STEPI TEST.*$gdb_prompt =
$" {
> =A0 =A0 =A0 =A0send_gdb "stepi\n"
> =A0 =A0 =A0 =A0exp_continue
> =A0 =A0 }
>
>