From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29587 invoked by alias); 9 Jun 2009 02:18:07 -0000 Received: (qmail 29578 invoked by uid 22791); 9 Jun 2009 02:18:07 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_39,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-px0-f199.google.com (HELO mail-px0-f199.google.com) (209.85.216.199) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 09 Jun 2009 02:18:02 +0000 Received: by mail-px0-f199.google.com with SMTP id 37so3739922pxi.12 for ; Mon, 08 Jun 2009 19:18:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.204.11 with SMTP id b11mr2485781wfg.158.1244513881696; Mon, 08 Jun 2009 19:18:01 -0700 (PDT) In-Reply-To: References: Date: Tue, 09 Jun 2009 02:18:00 -0000 Message-ID: Subject: Re: [RFA] Patch to fix "reverse-next" command error From: Hui Zhu To: Michael Snyder Cc: Marc Khouzam , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00201.txt.bz2 Ping. On Mon, May 11, 2009 at 15:07, Hui Zhu wrote: > PING > > On Wed, May 6, 2009 at 14:00, Hui Zhu wrote: >> Hi Michael, >> >> I try this issue with cvs-head. =A0It still affect cvs-head. >> And I try the patch, it can fix this issue. =A0It's time close to 7.0 >> branch. =A0So could you please help me review it? >> >> The attachment is the new patch follow cvs-head. >> >> 2009-05-06 =A0Hui Zhu =A0 >> >> =A0 =A0 =A0 * infrun.c (handle_inferior_event): Make inferior step if it >> =A0 =A0 =A0 stepping over a function call in reverse , and stop at the >> =A0 =A0 =A0 start address of the function. >> >> Thanks, >> Hui >> >> On Thu, Jan 22, 2009 at 17:00, teawater wrote: >>> Hi guys, >>> >>> This patch is for bug in http://sourceware.org/ml/gdb/2009-01/msg00146.= html >>> >>> This issue is because sometime the inferior is already in function >>> start address (i.e. plt), set a breakpoint and continue will make >>> "reverse-next" work error. >>> >>> This patch make inferior step if it reverse step and stop at the >>> function start address. >>> It tested OK with process record patch and testsuite gdb.twreverse in >>> branch reverse-20081226-branch. >>> >>> 2009-01-22 =A0Hui Zhu =A0 >>> >>> =A0 =A0 =A0 =A0* infrun.c (handle_inferior_event): Make inferior step i= f it >>> =A0 =A0 =A0 =A0stepping over a function call in reverse , and stop at t= he >>> =A0 =A0 =A0 =A0start address of the function. >>> >>> OK for mainline? >>> >>> Thanks, >>> Hui >>> >> >