From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31673 invoked by alias); 9 Jun 2009 02:18:47 -0000 Received: (qmail 31665 invoked by uid 22791); 9 Jun 2009 02:18:46 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-px0-f199.google.com (HELO mail-px0-f199.google.com) (209.85.216.199) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 09 Jun 2009 02:18:37 +0000 Received: by mail-px0-f199.google.com with SMTP id 37so3739922pxi.12 for ; Mon, 08 Jun 2009 19:18:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.214.5 with SMTP id m5mr2396130wfg.266.1244513909385; Mon, 08 Jun 2009 19:18:29 -0700 (PDT) In-Reply-To: References: Date: Tue, 09 Jun 2009 02:18:00 -0000 Message-ID: Subject: Re: [RFA] Patch to fix "reverse-step" command error From: Hui Zhu To: Marc Khouzam , Michael Snyder Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00202.txt.bz2 PING On Mon, May 11, 2009 at 15:07, Hui Zhu wrote: > PING > > On Wed, May 6, 2009 at 16:13, Hui Zhu wrote: >> Hi Marc and Michael, >> >> Sorry I forget this issue just reproduce in SLED 10. >> >> I reproduced it with cvs-head and patch can fix it. =A0Michael, Please >> help me review it. >> >> The attachment is the new patch follow cvs-head. >> >> 2009-05-06 =A0Hui Zhu =A0 >> >> =A0 =A0 =A0 * infrun.c (handle_inferior_event): Make inferior insert >> =A0 =A0 =A0 breakpoint at right address or step in reverse and it stepped >> =A0 =A0 =A0 into dynsym resolve code. >> >> Thanks, >> Hui >> >> On Wed, May 6, 2009 at 13:31, Hui Zhu wrote: >>> Hi Marc, >>> >>> I cannot reproduce this issue with cvs-head. >>> Could you please help me test with this issue? >>> If both of us cannot reproduce this issue, =A0I think I can give up thi= s patch. >>> >>> Thanks, >>> Hui >>> >>> >>> On Mon, Mar 2, 2009 at 14:10, teawater wrote: >>>> Hi Michael, >>>> >>>> This patch is for bug in >>>> http://sourceware.org/ml/gdb-patches/2009-02/msg00246.html. >>>> >>>> The reason of bug is when inferior reverse exection into dynsym >>>> resolve code, gdb doesn't insert breakpoint in right address. >>>> It just happen in some distributions for example SLED. >>>> >>>> This patch make gdb insert breakpoint in right address or step in that= case. >>>> >>>> 2008-03-02 =A0Hui Zhu =A0 >>>> >>>> =A0 =A0 =A0 * infrun.c (handle_inferior_event): Make inferior insert >>>> =A0 =A0 =A0 breakpoint at right address or step in reverse and it step= ped >>>> =A0 =A0 =A0 into dynsym resolve code. >>>> >>>> Thanks, >>>> Hui >>>> >>> >> >