From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11944 invoked by alias); 5 Jun 2009 02:50:34 -0000 Received: (qmail 11934 invoked by uid 22791); 5 Jun 2009 02:50:32 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from wf-out-1314.google.com (HELO wf-out-1314.google.com) (209.85.200.174) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 05 Jun 2009 02:50:26 +0000 Received: by wf-out-1314.google.com with SMTP id 23so430442wfg.24 for ; Thu, 04 Jun 2009 19:50:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.241.15 with SMTP id o15mr1154587wfh.104.1244170225126; Thu, 04 Jun 2009 19:50:25 -0700 (PDT) In-Reply-To: <422342.45652.qm@web36201.mail.mud.yahoo.com> References: <422342.45652.qm@web36201.mail.mud.yahoo.com> Date: Fri, 05 Jun 2009 02:50:00 -0000 Message-ID: Subject: Re: Submition of i386.record.floating.point.patch From: Hui Zhu To: gdb-patches@sourceware.org Cc: paawan oza Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00090.txt.bz2 Could someone help us about this? Thanks, Hui On Fri, Jun 5, 2009 at 10:41, paawan oza wrote: > > Hi Hui, > I think, FCTRL, FTAG, FOP are part of i386 also. > for e.g. > FFREE insn, changes only tag register. > frstor affetcs whole FPU environment. > The FPU operating environment consists of the FPU control word, status wo= rd, tag > word, instruction pointer, data pointer, and last opcode. > we need them for i386 too. > I have sent the test_float.c in my previous mail, where you will find all= these registers getting changed and tested. > Regards, > Oza. > > > > --- On Fri, 6/5/09, Hui Zhu wrote: > >> From: Hui Zhu >> Subject: Re: Submition of i386.record.floating.point.patch >> To: "paawan oza" >> Cc: gdb-patches@sourceware.org >> Date: Friday, June 5, 2009, 3:48 AM >> >> diff -urN >> gdb.orig/i386-tdep.h gdb.new/i386-tdep.h >> >> --- gdb.orig/i386-tdep.h =A0 =A0 =A0 =A02009-05-17 >> 17:56:44.000000000 -0400 >> >> +++ gdb.new/i386-tdep.h 2009-05-31 >> 16:33:14.000000000 -0400 >> >> @@ -145,7 +145,22 @@ >> >> =A0 I386_ES_REGNUM, =A0 =A0 =A0 =A0 =A0 =A0 =A0/* %es */ >> >> =A0 I386_FS_REGNUM, =A0 =A0 =A0 =A0 =A0 =A0 =A0/* %fs */ >> >> =A0 I386_GS_REGNUM, =A0 =A0 =A0 =A0 =A0 =A0 =A0/* %gs */ >> >> - =A0I386_ST0_REGNUM =A0 =A0 =A0 =A0 =A0 =A0 =A0/* %st(0) >> */ >> >> + =A0I386_ST0_REGNUM, =A0 =A0 =A0 =A0 =A0 =A0 /* %st(0) >> */ >> >> + =A0I386_ST1_REGNUM, =A0 =A0 =A0 =A0 =A0 =A0 /* %st(1) >> */ >> >> + =A0I386_ST2_REGNUM, =A0 =A0 =A0 =A0 =A0 =A0 /* %st(2) >> */ >> >> + =A0I386_ST3_REGNUM, =A0 =A0 =A0 =A0 =A0 =A0 /* %st(3) >> */ >> >> + =A0I386_ST4_REGNUM, =A0 =A0 =A0 =A0 =A0 =A0 /* %st(4) >> */ >> >> + =A0I386_ST5_REGNUM, =A0 =A0 =A0 =A0 =A0 =A0 /* %st(5) >> */ >> >> + =A0I386_ST6_REGNUM, =A0 =A0 =A0 =A0 =A0 =A0 /* %st(6) >> */ >> >> + =A0I386_ST7_REGNUM, =A0 =A0 =A0 =A0 =A0 =A0 /* %st(7) >> */ >> >> + =A0I386_FCTRL, =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0/* >> floating point env regs : FCTRL-FOP */ >> >> + =A0I386_FSTAT, >> >> + =A0I386_FTAG, >> >> + =A0I386_FISEG, >> >> + =A0I386_FIOFF, >> >> + =A0I386_FOSEG, >> >> + =A0I386_FOOFF, >> >> + =A0I386_FOP >> >> =A0}; >> >> >> > >> > About this part, I think this is my mistake. =A0I >> didn't take fp work >> > for now very clear (Or I am still not clear with x86 >> fp). >> > FCTRL, FOP and so on are the fp reg of amd64. =A0For >> now, prec is still >> > not support amd64 (I am working on it). >> > And amd64's support are in amd64-tedp.... files. >> =A0Change i386_regnum >> > is not a good idea. >> > >> > I suggest you divide fp patch to 2 parts. One is for >> i386, the other for amd64. >> > For now, just send i386 patch for review. =A0And send >> amd64 patch when >> > prec support amd64. >> > >> > >> > >> >> What do you think about my idea? >> > > > >