From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-64200-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20902 invoked by alias); 4 Jun 2009 22:18:09 -0000
Received: (qmail 20894 invoked by uid 22791); 4 Jun 2009 22:18:08 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from wf-out-1314.google.com (HELO wf-out-1314.google.com) (209.85.200.173)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Jun 2009 22:18:01 +0000
Received: by wf-out-1314.google.com with SMTP id 23so392912wfg.24         for <gdb-patches@sourceware.org>; Thu, 04 Jun 2009 15:18:00 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.142.107.5 with SMTP id f5mr954184wfc.130.1244153880045; Thu,  	04 Jun 2009 15:18:00 -0700 (PDT)
In-Reply-To: <daef60380906012357p3a867ed0od25c248711cd4fb3@mail.gmail.com>
References: <315775.93336.qm@web36201.mail.mud.yahoo.com> 	 <daef60380906012357p3a867ed0od25c248711cd4fb3@mail.gmail.com>
Date: Thu, 04 Jun 2009 22:18:00 -0000
Message-ID: <daef60380906041518l49016150v340312252dad9511@mail.gmail.com>
Subject: Re: Submition of i386.record.floating.point.patch
From: Hui Zhu <teawater@gmail.com>
To: paawan oza <paawan1982@yahoo.com>
Cc: gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-06/txt/msg00087.txt.bz2

>> diff -urN gdb.orig/i386-tdep.h gdb.new/i386-tdep.h
>> --- gdb.orig/i386-tdep.h =A0 =A0 =A0 =A02009-05-17 17:56:44.000000000 -0=
400
>> +++ gdb.new/i386-tdep.h 2009-05-31 16:33:14.000000000 -0400
>> @@ -145,7 +145,22 @@
>> =A0 I386_ES_REGNUM, =A0 =A0 =A0 =A0 =A0 =A0 =A0/* %es */
>> =A0 I386_FS_REGNUM, =A0 =A0 =A0 =A0 =A0 =A0 =A0/* %fs */
>> =A0 I386_GS_REGNUM, =A0 =A0 =A0 =A0 =A0 =A0 =A0/* %gs */
>> - =A0I386_ST0_REGNUM =A0 =A0 =A0 =A0 =A0 =A0 =A0/* %st(0) */
>> + =A0I386_ST0_REGNUM, =A0 =A0 =A0 =A0 =A0 =A0 /* %st(0) */
>> + =A0I386_ST1_REGNUM, =A0 =A0 =A0 =A0 =A0 =A0 /* %st(1) */
>> + =A0I386_ST2_REGNUM, =A0 =A0 =A0 =A0 =A0 =A0 /* %st(2) */
>> + =A0I386_ST3_REGNUM, =A0 =A0 =A0 =A0 =A0 =A0 /* %st(3) */
>> + =A0I386_ST4_REGNUM, =A0 =A0 =A0 =A0 =A0 =A0 /* %st(4) */
>> + =A0I386_ST5_REGNUM, =A0 =A0 =A0 =A0 =A0 =A0 /* %st(5) */
>> + =A0I386_ST6_REGNUM, =A0 =A0 =A0 =A0 =A0 =A0 /* %st(6) */
>> + =A0I386_ST7_REGNUM, =A0 =A0 =A0 =A0 =A0 =A0 /* %st(7) */
>> + =A0I386_FCTRL, =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0/* floating point en=
v regs : FCTRL-FOP */
>> + =A0I386_FSTAT,
>> + =A0I386_FTAG,
>> + =A0I386_FISEG,
>> + =A0I386_FIOFF,
>> + =A0I386_FOSEG,
>> + =A0I386_FOOFF,
>> + =A0I386_FOP
>> =A0};
>>
>
> About this part, I think this is my mistake. =A0I didn't take fp work
> for now very clear (Or I am still not clear with x86 fp).
> FCTRL, FOP and so on are the fp reg of amd64. =A0For now, prec is still
> not support amd64 (I am working on it).
> And amd64's support are in amd64-tedp.... files. =A0Change i386_regnum
> is not a good idea.
>
> I suggest you divide fp patch to 2 parts. One is for i386, the other for =
amd64.
> For now, just send i386 patch for review. =A0And send amd64 patch when
> prec support amd64.
>
>
>

What do you think about my idea?