From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25591 invoked by alias); 22 May 2009 02:12:11 -0000 Received: (qmail 25578 invoked by uid 22791); 22 May 2009 02:12:09 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-px0-f199.google.com (HELO mail-px0-f199.google.com) (209.85.216.199) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 May 2009 02:12:04 +0000 Received: by pxi37 with SMTP id 37so1593831pxi.12 for ; Thu, 21 May 2009 19:12:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.110.57.5 with SMTP id f5mr89604tia.11.1242958321885; Thu, 21 May 2009 19:12:01 -0700 (PDT) In-Reply-To: <20090522004623.GI28993@ednor.casa.cgf.cx> References: <20090518153510.GA23052@ednor.casa.cgf.cx> <20090521152621.GA27524@ednor.casa.cgf.cx> <20090521173804.GA27866@ednor.casa.cgf.cx> <20090522004623.GI28993@ednor.casa.cgf.cx> Date: Fri, 22 May 2009 02:12:00 -0000 Message-ID: Subject: Re: [Prec/RFA] fix build error of prec in cygwin From: Hui Zhu To: gdb-patches ml , Hui Zhu Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00477.txt.bz2 On Fri, May 22, 2009 at 08:46, Christopher Faylor wrote: > On Fri, May 22, 2009 at 07:14:48AM +0800, Hui Zhu wrote: >>On Fri, May 22, 2009 at 01:38, Christopher Faylor =A0wrote: >>> On Fri, May 22, 2009 at 12:43:07AM +0800, Hui Zhu wrote: >>>>Thanks for you help me review my patch. ?Could you give me some help >>>>with it? ?Actually, try something with cygwin still a very hard thing >>>>for me. ?I just can use it in a notebook of other guy. ?And I had >>>>return it. ?Maybe you can make a patch for this bug. ?That will be very >>>>great for me. >>> >>>I don't see why this has anything to do with Cygwin. =A0?We're talking >>>about general principles here. =A0If you know C, which you obviously do, >>>then I don't really understand why this needs a lot of explanation. >>>Look at the places where you're using coercion with a format string and >>>just use the right format specifier instead. >> >>Because the patch must be work OK with cygwin. =A0Even if for the format. >>I think you must have a lot of good idea with it. =A0We need your help. >>That is very great for me. =A0Thanks a lot. > > No need to thank me yet. =A0I'll be happy to review your change when you > make the simple changes that I requested. =A0You can hold off thanking me > until then. About %u and sizeof, if without (int). It's OK with cygwin. But it cannot work OK with amd64. It will get: ../../src/gdb/linux-record.c: In function =91record_linux_system_call=92: ../../src/gdb/linux-record.c:551: warning: format =91%u=92 expects type =91unsigned int=92, but argument 4 has type =91long unsigned int=92 Could you give me some help with it? Hui