From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-63885-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17849 invoked by alias); 21 May 2009 02:39:06 -0000
Received: (qmail 17838 invoked by uid 22791); 21 May 2009 02:39:05 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from rv-out-0708.google.com (HELO rv-out-0708.google.com) (209.85.198.250)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 May 2009 02:39:01 +0000
Received: by rv-out-0708.google.com with SMTP id k29so263144rvb.48         for <multiple recipients>; Wed, 20 May 2009 19:38:59 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.110.28.15 with SMTP id b15mr41059tib.33.1242873538304; Wed, 20  	May 2009 19:38:58 -0700 (PDT)
In-Reply-To: <daef60380905181934j7ec54c1aj4f88a6e06387abfa@mail.gmail.com>
References: <daef60380905101031s1fd37293o1358d83357032492@mail.gmail.com> 	 <20090510174809.GA25909@ednor.casa.cgf.cx> 	 <daef60380905101107u25e55c38jaf05c7977adf57b6@mail.gmail.com> 	 <20090510235109.GD25909@ednor.casa.cgf.cx> 	 <daef60380905180143l63bcc007n9821638179ef84ec@mail.gmail.com> 	 <20090518153510.GA23052@ednor.casa.cgf.cx> 	 <daef60380905181934j7ec54c1aj4f88a6e06387abfa@mail.gmail.com>
Date: Thu, 21 May 2009 02:39:00 -0000
Message-ID: <daef60380905201938r24cc7f47x514753cdf89f8fcc@mail.gmail.com>
Subject: Re: [Prec/RFA] fix build error of prec in cygwin
From: Hui Zhu <teawater@gmail.com>
To: gdb-patches ml <gdb-patches@sourceware.org>,  	cgf-use-the-mailinglist-please@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-05/txt/msg00448.txt.bz2

Ping

On Tue, May 19, 2009 at 10:34, Hui Zhu <teawater@gmail.com> wrote:
>
> On Mon, May 18, 2009 at 23:35, Christopher Faylor
> <cgf-use-the-mailinglist-please@sourceware.org> wrote:
> > On Mon, May 18, 2009 at 04:43:36PM +0800, Hui Zhu wrote:
> >>On Mon, May 11, 2009 at 07:51, Christopher Faylor wrote:
> >>> So wouldn't that indicate that your format specifier is wrong and sho=
uld
> >>> be "%u" rather than "%d"? ?Coercion is something that should be avoid=
ed
> >>> unless it is absolutely necessary.
> >>>
> >>
> >>I changed it.
> >
> > It looks like this diff is against your previous version rather than CVS
> > so it is confusing. =A0But, it still seems like you're still coercing
> > using (int)len but now you're using %u. =A0So, it looks like you've just
> > swapped the problem.
>
> No, it based on cvs-head. Are you really try?
>
> With out (int) it will get:
> ../../src/gdb/linux-record.c: In function `record_linux_system_call':
> ../../src/gdb/linux-record.c:1787: warning: unsigned int format, long
> int arg (arg 4)
> make: *** [linux-record.o] Error 1
>
> In Cygwin.
>
> Thanks,
> Hui