From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23441 invoked by alias); 13 May 2009 16:31:02 -0000 Received: (qmail 23402 invoked by uid 22791); 13 May 2009 16:30:58 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.186) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 May 2009 16:30:51 +0000 Received: by ti-out-0910.google.com with SMTP id a1so79101tib.12 for ; Wed, 13 May 2009 09:30:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.110.21.17 with SMTP id 17mr82650tiu.52.1242232248698; Wed, 13 May 2009 09:30:48 -0700 (PDT) In-Reply-To: <200905131118.02697.pedro@codesourcery.com> References: <200905131118.02697.pedro@codesourcery.com> Date: Wed, 13 May 2009 16:31:00 -0000 Message-ID: Subject: Re: [RFA Precord] Disable process record in amd64 From: Hui Zhu To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00274.txt.bz2 On Wed, May 13, 2009 at 18:18, Pedro Alves wrote: > On Wednesday 13 May 2009 09:07:03, Hui Zhu wrote: >> Hi, >> >> The i386 process record can't work together with amd64 now. =A0So I make >> a patch to disable it in amd64. > > It would be better to move the `set_gdbarch_process_record (gdbarch, i386= _process_record)' > call to tdep files where precord will actually work --- in this > case, i386-linux-tdep.c --- instead of having i386-tdep.c assume > precord support. =A0We've done the exact same thing for displaced > stepping. > Maybe make i386_process_record support x86-64 is better. Forget this patch. Thanks, Hui