From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21093 invoked by alias); 10 May 2009 17:31:28 -0000 Received: (qmail 21082 invoked by uid 22791); 10 May 2009 17:31:27 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.186) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 10 May 2009 17:31:21 +0000 Received: by ti-out-0910.google.com with SMTP id a1so206126tib.12 for ; Sun, 10 May 2009 10:31:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.110.21.17 with SMTP id 17mr402899tiu.5.1241976678083; Sun, 10 May 2009 10:31:18 -0700 (PDT) Date: Sun, 10 May 2009 17:31:00 -0000 Message-ID: Subject: [Prec/RFA] fix build error of prec in cygwin From: Hui Zhu To: Michael Snyder , Pedro Alves Cc: gdb-patches@sourceware.org, Pierre Muller Content-Type: multipart/mixed; boundary=0016e652f642b76c9b0469923ab3 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00192.txt.bz2 --0016e652f642b76c9b0469923ab3 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 2882 Hi guys, This patch is to fix build error of prec in cgywin. Pierre had help me tested it both in 32bit and 64bit CORE_ADDR length. Please help me review it. 2009-05-11 Hui Zhu Add sys_fcntl argument interfaces to linux_record_tdep. * linux-record.h (linux_record_tdep): Add fcntl_F_GETLK, fcntl_F_GETLK64, fcntl_F_SETLK64 and fcntl_F_SETLKW64 to be interfaces. * i386-linux-tdep.c (I386_LINUX_RECORD_FCNTL_F_GETLK, I386_LINUX_RECORD_FCNTL_F_GETLK64, I386_LINUX_RECORD_FCNTL_F_SETLK64, I386_LINUX_RECORD_FCNTL_F_SETLKW64): New macros. The values of I386 Linux sys_fcntl arguments. (i386_linux_init_abi): Set macros values to linux_record_tdep. * linux-record.c (record_linux_system_call): Change to use the interface in linux_record_tdep in sys_fcntl and sys_fcntl64. * linux-record.c (record_linux_system_call): Fix the process record build error about type in CYGWIN. Thanks, Hui On Fri, May 8, 2009 at 20:11, Pierre Muller wrote: > I tested this both in 32bit and 64bit CORE_ADDR length. > > I can confirm that cygwin compilation is fixed in both > cases with that patch and hope it will be approved > rapidly. > > =A0Thanks, Hui. > > > Pierre Muller > Pascal language support maintainer for GDB > > > > >> -----Message d'origine----- >> De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- >> owner@sourceware.org] De la part de Hui Zhu >> Envoy=E9=A0: Friday, May 08, 2009 7:12 AM >> =C0=A0: Pierre Muller >> Cc=A0: gdb-patches@sourceware.org; Michael Snyder; Pedro Alves >> Objet=A0: Re: Process record and replay checked in to main trunk >> >> Hi Pierre, >> >> I make a patch to fix this bug, but I don't have cygwin. >> >> Could you please help me test this patch in cygwin? >> >> Thanks, >> Hui >> >> On Fri, May 8, 2009 at 07:06, Pedro Alves >> wrote: >> > On Thursday 07 May 2009 23:43:13, Michael Snyder wrote: >> >> Guessing it isn't implemented for 64 bit. >> > >> > I don't think that's the problem here. =A0Cygwin is 32-bit, and has >> > 32-bit ints. >> > >> >> ../../purecvs/gdb/linux-record.c:397: warning: unsigned int format, >> >> uint32_t arg >> > >> >> ../../purecvs/gdb/linux-record.c:629: warning: int format, uint32_t >> >> arg (arg >> > >> > Better use casts, or use plongest/pulongest/hex_string where >> appropriate? >> > >> >> Perhaps we should have a --disable-process-record config option? >> >> If only for a back-up plan? >> > >> > I think that would be more work than fixing this properly. =A0:-) >> > >> >> ../../purecvs/gdb/linux-record.c:1636: error: `F_GETLK64' undeclared >> >> (first use in this function) >> > >> > There are a bunch of RECORD_* macros defined on top of linux-record.c >> > to replace contants like these. =A0E.g., RECORD_Q_GETFMT. =A0Looks like >> > this case was just missed. >> > >> > -- >> > Pedro Alves >> > > > --0016e652f642b76c9b0469923ab3 Content-Type: text/plain; charset=US-ASCII; name="fix-prec-cygwin-build-error.txt" Content-Disposition: attachment; filename="fix-prec-cygwin-build-error.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fuk0ryb40 Content-length: 6011 LS0tCiBpMzg2LWxpbnV4LXRkZXAuYyB8ICAgMTQgKysrKysrKysrKysrKysK IGxpbnV4LXJlY29yZC5jICAgIHwgICAyOCArKysrKysrKysrKysrLS0tLS0t LS0tLS0tLS0tCiBsaW51eC1yZWNvcmQuaCAgICB8ICAgIDcgKysrKysrKwog MyBmaWxlcyBjaGFuZ2VkLCAzNCBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlv bnMoLSkKCi0tLSBhL2kzODYtbGludXgtdGRlcC5jCisrKyBiL2kzODYtbGlu dXgtdGRlcC5jCkBAIC01ODYsNiArNTg2LDE0IEBAIHN0YXRpYyBpbnQgaTM4 Nl9saW51eF9zY19yZWdfb2Zmc2V0W10gPQogI2RlZmluZSBJMzg2X0xJTlVY X1JFQ09SRF9JT0NUTF9USU9DU0hBWUVTRVNQCQkweDU0NUYKICNkZWZpbmUg STM4Nl9MSU5VWF9SRUNPUkRfSU9DVExfRklPUVNJWkUJCTB4NTQ2MAogCisv KiBUaGUgdmFsdWVzIG9mIHRoZSBzZWNvbmQgYXJndW1lbnQgb2Ygc3lzdGVt IGNhbGwgInN5c19mY250bCIKKyAgIGFuZCAic3lzX2ZjbnRsNjQiLiAgVGhl IHZhbHVlcyBvZiB0aGVzZSBtYWNyb3Mgd2VyZSBvYnRhaW5lZCBmcm9tCisg ICBMaW51eCBLZXJuZWwgc291cmNlLiAgKi8KKyNkZWZpbmUgSTM4Nl9MSU5V WF9SRUNPUkRfRkNOVExfRl9HRVRMSwkJCTUKKyNkZWZpbmUgSTM4Nl9MSU5V WF9SRUNPUkRfRkNOVExfRl9HRVRMSzY0CQkxMgorI2RlZmluZSBJMzg2X0xJ TlVYX1JFQ09SRF9GQ05UTF9GX1NFVExLNjQJCTEzCisjZGVmaW5lIEkzODZf TElOVVhfUkVDT1JEX0ZDTlRMX0ZfU0VUTEtXNjQJCTE0CisKIHN0YXRpYyB2 b2lkCiBpMzg2X2xpbnV4X2luaXRfYWJpIChzdHJ1Y3QgZ2RiYXJjaF9pbmZv IGluZm8sIHN0cnVjdCBnZGJhcmNoICpnZGJhcmNoKQogewpAQCAtNzgxLDYg Kzc4OSwxMiBAQCBpMzg2X2xpbnV4X2luaXRfYWJpIChzdHJ1Y3QgZ2RiYXJj aF9pbmZvCiAgICAgSTM4Nl9MSU5VWF9SRUNPUkRfSU9DVExfVElPQ1NIQVlF U0VTUDsKICAgaTM4Nl9saW51eF9yZWNvcmRfdGRlcC5pb2N0bF9GSU9RU0la RSA9IEkzODZfTElOVVhfUkVDT1JEX0lPQ1RMX0ZJT1FTSVpFOwogCisgIGkz ODZfbGludXhfcmVjb3JkX3RkZXAuZmNudGxfRl9HRVRMSyA9IEkzODZfTElO VVhfUkVDT1JEX0ZDTlRMX0ZfR0VUTEs7CisgIGkzODZfbGludXhfcmVjb3Jk X3RkZXAuZmNudGxfRl9HRVRMSzY0ID0gSTM4Nl9MSU5VWF9SRUNPUkRfRkNO VExfRl9HRVRMSzY0OworICBpMzg2X2xpbnV4X3JlY29yZF90ZGVwLmZjbnRs X0ZfU0VUTEs2NCA9IEkzODZfTElOVVhfUkVDT1JEX0ZDTlRMX0ZfU0VUTEs2 NDsKKyAgaTM4Nl9saW51eF9yZWNvcmRfdGRlcC5mY250bF9GX1NFVExLVzY0 ID0KKyAgICBJMzg2X0xJTlVYX1JFQ09SRF9GQ05UTF9GX1NFVExLVzY0Owor CiAgIGkzODZfbGludXhfcmVjb3JkX3RkZXAuYXJnMSA9IEkzODZfRUJYX1JF R05VTTsKICAgaTM4Nl9saW51eF9yZWNvcmRfdGRlcC5hcmcyID0gSTM4Nl9F Q1hfUkVHTlVNOwogICBpMzg2X2xpbnV4X3JlY29yZF90ZGVwLmFyZzMgPSBJ Mzg2X0VEWF9SRUdOVU07Ci0tLSBhL2xpbnV4LXJlY29yZC5jCisrKyBiL2xp bnV4LXJlY29yZC5jCkBAIC0zOTQsNyArMzk0LDcgQEAgcmVjb3JkX2xpbnV4 X3N5c3RlbV9jYWxsIChpbnQgbnVtLCBzdHJ1YwogCXsKIAkgIHByaW50Zl91 bmZpbHRlcmVkIChfKCJQcm9jZXNzIHJlY29yZCBhbmQgcmVwbGF5IHRhcmdl dCBkb2Vzbid0ICIKIAkJCSAgICAgICAic3VwcG9ydCBpb2N0bCByZXF1ZXN0 IDB4JTA4eC5cbiIpLAotCQkJICAgICB0bXB1MzIpOworCQkJICAgICAoaW50 KXRtcHUzMik7CiAJICByZXR1cm4gMTsKIAl9CiAgICAgICBicmVhazsKQEAg LTQwNCw3ICs0MDQsNyBAQCByZWNvcmRfbGludXhfc3lzdGVtX2NhbGwgKGlu dCBudW0sIHN0cnVjCiAgICAgICAvKiBYWFggKi8KICAgICAgIHJlZ2NhY2hl X3Jhd19yZWFkIChyZWdjYWNoZSwgdGRlcC0+YXJnMiwgKGdkYl9ieXRlICop ICYgdG1wdTMyKTsKICAgICBzeXNfZmNudGw6Ci0gICAgICBpZiAodG1wdTMy ID09IEZfR0VUTEspCisgICAgICBpZiAodG1wdTMyID09IHRkZXAtPmZjbnRs X0ZfR0VUTEspCiAJewogCSAgcmVnY2FjaGVfcmF3X3JlYWQgKHJlZ2NhY2hl LCB0ZGVwLT5hcmczLAogCQkJICAgICAoZ2RiX2J5dGUgKikgJiB0bXB1MzIp OwpAQCAtNjI2LDcgKzYyNiw3IEBAIHJlY29yZF9saW51eF9zeXN0ZW1fY2Fs bCAoaW50IG51bSwgc3RydWMKIAkJICAgICJJdCB3aWxsIGZyZWUgdGhlIG1l bW9yeSBhZGRyID0gMHglcyBsZW4gPSAlZC4gICIKIAkJICAgICJJdCB3aWxs IG1ha2UgcmVjb3JkIHRhcmdldCBnZXQgZXJyb3IuICAiCiAJCSAgICAiRG8g eW91IHdhbnQgdG8gc3RvcCB0aGUgcHJvZ3JhbT8iKSwKLQkJICBwYWRkcl9u eiAodG1wdTMyKSwgbGVuKTsKKwkJICBwYWRkcl9ueiAodG1wdTMyKSwgKGlu dClsZW4pOwogCXRhcmdldF90ZXJtaW5hbF9pbmZlcmlvciAoKTsKIAlpZiAo cSkKIAkgIHJldHVybiAxOwpAQCAtOTM1LDcgKzkzNSw3IEBAIHJlY29yZF9s aW51eF9zeXN0ZW1fY2FsbCAoaW50IG51bSwgc3RydWMKIAlkZWZhdWx0Ogog CSAgcHJpbnRmX3VuZmlsdGVyZWQgKF8oIlByb2Nlc3MgcmVjb3JkIGFuZCBy ZXBsYXkgdGFyZ2V0ICIKIAkJCSAgICAgICAiZG9lc24ndCBzdXBwb3J0IHNv Y2tldGNhbGwgY2FsbCAweCUwOHhcbiIpLAotCQkJICAgICB0bXB1MzIpOwor CQkJICAgICAoaW50KXRtcHUzMik7CiAJICByZXR1cm4gLTE7CiAJICBicmVh azsKIAl9CkBAIC0xNjMxLDIwICsxNjMxLDE3IEBAIHJlY29yZF9saW51eF9z eXN0ZW1fY2FsbCAoaW50IG51bSwgc3RydWMKICAgICAgIC8qIHN5c19mY250 bDY0ICovCiAgICAgY2FzZSAyMjE6CiAgICAgICByZWdjYWNoZV9yYXdfcmVh ZCAocmVnY2FjaGUsIHRkZXAtPmFyZzIsIChnZGJfYnl0ZSAqKSAmIHRtcHUz Mik7Ci0gICAgICBzd2l0Y2ggKHRtcHUzMikKLQl7Ci0JY2FzZSBGX0dFVExL NjQ6CisgICAgICBpZiAodG1wdTMyID09IHRkZXAtPmZjbnRsX0ZfR0VUTEs2 NCkKKyAgICAgICAgewogCSAgcmVnY2FjaGVfcmF3X3JlYWQgKHJlZ2NhY2hl LCB0ZGVwLT5hcmczLAogCQkJICAgICAoZ2RiX2J5dGUgKikgJiB0bXB1MzIp OwogCSAgaWYgKHJlY29yZF9hcmNoX2xpc3RfYWRkX21lbSAodG1wdTMyLCB0 ZGVwLT5zaXplX2Zsb2NrNjQpKQogCSAgICByZXR1cm4gLTE7Ci0JICBicmVh azsKLQljYXNlIEZfU0VUTEs2NDoKLQljYXNlIEZfU0VUTEtXNjQ6Ci0JICBi cmVhazsKLQlkZWZhdWx0OgorCX0KKyAgICAgIGVsc2UgaWYgKHRtcHUzMiAh PSB0ZGVwLT5mY250bF9GX1NFVExLNjQKKwkgICAgICAgJiYgdG1wdTMyICE9 IHRkZXAtPmZjbnRsX0ZfU0VUTEtXNjQpCisgICAgICAgIHsKIAkgIGdvdG8g c3lzX2ZjbnRsOwotCSAgYnJlYWs7CiAJfQogICAgICAgYnJlYWs7CiAKQEAg LTE3ODYsNyArMTc4Myw4IEBAIHJlY29yZF9saW51eF9zeXN0ZW1fY2FsbCAo aW50IG51bSwgc3RydWMKIAkJZnByaW50Zl91bmZpbHRlcmVkIChnZGJfc3Rk bG9nLAogCQkJCSAgICAiUHJvY2VzcyByZWNvcmQ6IGVycm9yIHJlYWRpbmcg bWVtb3J5ICIKIAkJCQkgICAgImF0IGFkZHIgPSAweCVzIGxlbiA9ICVkLlxu IiwKLQkJCQkgICAgcGFkZHJfbnogKHRtcHUzMiksIG5yICogdGRlcC0+c2l6 ZV9pbnQpOworCQkJCSAgICBwYWRkcl9ueiAodG1wdTMyKSwKKwkJCQkgICAg KGludCkobnIgKiB0ZGVwLT5zaXplX2ludCkpOwogCSAgICAgIHJldHVybiAt MTsKIAkgICAgfQogCSAgZm9yIChpID0gMDsgaSA8IG5yOyBpKyspCkBAIC0y MTk2LDcgKzIxOTQsNyBAQCByZWNvcmRfbGludXhfc3lzdGVtX2NhbGwgKGlu dCBudW0sIHN0cnVjCiAgICAgZGVmYXVsdDoKICAgICAgIHByaW50Zl91bmZp bHRlcmVkIChfKCJQcm9jZXNzIHJlY29yZCBhbmQgcmVwbGF5IHRhcmdldCBk b2Vzbid0ICIKIAkJCSAgICJzdXBwb3J0IHN5c2NhbGwgbnVtYmVyIDB4JTA4 eFxuIiksCi0JCQkgdG1wdTMyKTsKKwkJCSAoaW50KXRtcHUzMik7CiAgICAg ICByZXR1cm4gLTE7CiAgICAgICBicmVhazsKICAgICB9Ci0tLSBhL2xpbnV4 LXJlY29yZC5oCisrKyBiL2xpbnV4LXJlY29yZC5oCkBAIC0xNTgsNiArMTU4 LDEzIEBAIHN0cnVjdCBsaW51eF9yZWNvcmRfdGRlcAogICBpbnQgaW9jdGxf VElPQ1NIQVlFU0VTUDsKICAgaW50IGlvY3RsX0ZJT1FTSVpFOwogCisgIC8q IFRoZSB2YWx1ZXMgb2YgdGhlIHNlY29uZCBhcmd1bWVudCBvZiBzeXN0ZW0g Y2FsbCAic3lzX2ZjbnRsIgorICAgICBhbmQgInN5c19mY250bDY0Ii4gICov CisgIGludCBmY250bF9GX0dFVExLOworICBpbnQgZmNudGxfRl9HRVRMSzY0 OworICBpbnQgZmNudGxfRl9TRVRMSzY0OworICBpbnQgZmNudGxfRl9TRVRM S1c2NDsKKwogICAvKiBUaGUgbnVtYmVyIG9mIHRoZSByZWdpc3RlcnMgdGhh dCBhcmUgdXNlZCBhcyB0aGUgYXJndW1lbnRzIG9mCiAgICAgIGEgc3lzdGVt IGNhbGwuICAqLwogICBpbnQgYXJnMTsK --0016e652f642b76c9b0469923ab3--