From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20174 invoked by alias); 10 May 2009 17:28:16 -0000 Received: (qmail 20164 invoked by uid 22791); 10 May 2009 17:28:15 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.185) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 10 May 2009 17:28:08 +0000 Received: by ti-out-0910.google.com with SMTP id a1so206074tib.12 for ; Sun, 10 May 2009 10:28:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.110.11.4 with SMTP id 4mr339000tik.21.1241976485002; Sun, 10 May 2009 10:28:05 -0700 (PDT) In-Reply-To: <003201c9cfd6$0d96d6f0$28c484d0$@u-strasbg.fr> References: <001201c9cf62$8e2761a0$aa7624e0$@u-strasbg.fr> <4A036401.6060906@vmware.com> <200905080006.19166.pedro@codesourcery.com> <003201c9cfd6$0d96d6f0$28c484d0$@u-strasbg.fr> Date: Sun, 10 May 2009 17:28:00 -0000 Message-ID: Subject: Re: Process record and replay checked in to main trunk From: Hui Zhu To: Pierre Muller Cc: gdb-patches@sourceware.org, Michael Snyder , Pedro Alves Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00191.txt.bz2 Thanks Pierre. You help me a lot. :) Hui On Fri, May 8, 2009 at 20:11, Pierre Muller wrote: > I tested this both in 32bit and 64bit CORE_ADDR length. > > I can confirm that cygwin compilation is fixed in both > cases with that patch and hope it will be approved > rapidly. > > =A0Thanks, Hui. > > > Pierre Muller > Pascal language support maintainer for GDB > > > > >> -----Message d'origine----- >> De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- >> owner@sourceware.org] De la part de Hui Zhu >> Envoy=E9=A0: Friday, May 08, 2009 7:12 AM >> =C0=A0: Pierre Muller >> Cc=A0: gdb-patches@sourceware.org; Michael Snyder; Pedro Alves >> Objet=A0: Re: Process record and replay checked in to main trunk >> >> Hi Pierre, >> >> I make a patch to fix this bug, but I don't have cygwin. >> >> Could you please help me test this patch in cygwin? >> >> Thanks, >> Hui >> >> On Fri, May 8, 2009 at 07:06, Pedro Alves >> wrote: >> > On Thursday 07 May 2009 23:43:13, Michael Snyder wrote: >> >> Guessing it isn't implemented for 64 bit. >> > >> > I don't think that's the problem here. =A0Cygwin is 32-bit, and has >> > 32-bit ints. >> > >> >> ../../purecvs/gdb/linux-record.c:397: warning: unsigned int format, >> >> uint32_t arg >> > >> >> ../../purecvs/gdb/linux-record.c:629: warning: int format, uint32_t >> >> arg (arg >> > >> > Better use casts, or use plongest/pulongest/hex_string where >> appropriate? >> > >> >> Perhaps we should have a --disable-process-record config option? >> >> If only for a back-up plan? >> > >> > I think that would be more work than fixing this properly. =A0:-) >> > >> >> ../../purecvs/gdb/linux-record.c:1636: error: `F_GETLK64' undeclared >> >> (first use in this function) >> > >> > There are a bunch of RECORD_* macros defined on top of linux-record.c >> > to replace contants like these. =A0E.g., RECORD_Q_GETFMT. =A0Looks like >> > this case was just missed. >> > >> > -- >> > Pedro Alves >> > > >