From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5603 invoked by alias); 6 May 2009 06:01:38 -0000 Received: (qmail 5060 invoked by uid 22791); 6 May 2009 06:01:33 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_39,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.189) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 May 2009 06:01:00 +0000 Received: by ti-out-0910.google.com with SMTP id a1so527896tib.12 for ; Tue, 05 May 2009 23:00:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.110.62.4 with SMTP id k4mr61377tia.30.1241589656851; Tue, 05 May 2009 23:00:56 -0700 (PDT) In-Reply-To: References: Date: Wed, 06 May 2009 06:01:00 -0000 Message-ID: Subject: Re: [RFA] Patch to fix "reverse-next" command error From: Hui Zhu To: Michael Snyder Cc: Marc Khouzam , "gdb-patches@sourceware.org" Content-Type: multipart/mixed; boundary=001485f428987413b80469381eb5 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00103.txt.bz2 --001485f428987413b80469381eb5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1295 Hi Michael, I try this issue with cvs-head. It still affect cvs-head. And I try the patch, it can fix this issue. It's time close to 7.0 branch. So could you please help me review it? The attachment is the new patch follow cvs-head. 2009-05-06 Hui Zhu * infrun.c (handle_inferior_event): Make inferior step if it stepping over a function call in reverse , and stop at the start address of the function. Thanks, Hui On Thu, Jan 22, 2009 at 17:00, teawater wrote: > Hi guys, > > This patch is for bug in http://sourceware.org/ml/gdb/2009-01/msg00146.ht= ml > > This issue is because sometime the inferior is already in function > start address (i.e. plt), set a breakpoint and continue will make > "reverse-next" work error. > > This patch make inferior step if it reverse step and stop at the > function start address. > It tested OK with process record patch and testsuite gdb.twreverse in > branch reverse-20081226-branch. > > 2009-01-22 =A0Hui Zhu =A0 > > =A0 =A0 =A0 =A0* infrun.c (handle_inferior_event): Make inferior step if = it > =A0 =A0 =A0 =A0stepping over a function call in reverse , and stop at the > =A0 =A0 =A0 =A0start address of the function. > > OK for mainline? > > Thanks, > Hui > --001485f428987413b80469381eb5 Content-Type: text/plain; charset=US-ASCII; name="fix-reverse-plt-error.txt" Content-Disposition: attachment; filename="fix-reverse-plt-error.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fudmdzve1 Content-length: 1452 LS0tCiBpbmZydW4uYyB8ICAgMTkgKysrKysrKysrKysrKysrLS0tLQogMSBm aWxlIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0p CgotLS0gYS9pbmZydW4uYworKysgYi9pbmZydW4uYwpAQCAtMzU1OCwxMCAr MzU1OCwyMSBAQCBpbmZydW46IEJQU1RBVF9XSEFUX1NFVF9MT05HSk1QX1JF U1VNRSAoCiAJCSAga2VlcF9nb2luZyAoZWNzKTsKIAkJICByZXR1cm47CiAJ CX0KLQkgICAgICAvKiBOb3JtYWwgKHN0YXRpY2x5IGxpbmtlZCkgZnVuY3Rp b24gY2FsbCByZXR1cm4uICAqLwotCSAgICAgIGluaXRfc2FsICgmc3Jfc2Fs KTsKLQkgICAgICBzcl9zYWwucGMgPSBlY3MtPnN0b3BfZnVuY19zdGFydDsK LQkgICAgICBpbnNlcnRfc3RlcF9yZXN1bWVfYnJlYWtwb2ludF9hdF9zYWwg KHNyX3NhbCwgbnVsbF9mcmFtZV9pZCk7CisJICAgICAgaWYgKGVjcy0+c3Rv cF9mdW5jX3N0YXJ0ICE9IHN0b3BfcGMpCisJCXsKKwkJICAvKiBOb3JtYWwg KHN0YXRpY2x5IGxpbmtlZCkgZnVuY3Rpb24gY2FsbCByZXR1cm4uICAqLwor CQkgIGluaXRfc2FsICgmc3Jfc2FsKTsKKwkJICBzcl9zYWwucGMgPSBlY3Mt PnN0b3BfZnVuY19zdGFydDsKKwkJICBpbnNlcnRfc3RlcF9yZXN1bWVfYnJl YWtwb2ludF9hdF9zYWwgKHNyX3NhbCwgbnVsbF9mcmFtZV9pZCk7CisJCX0K KwkgICAgICBlbHNlCisJCXsKKwkJICAvKiBXZSBhcmUgc3RlcHBpbmcgb3Zl ciBhIGZ1bmN0aW9uIGNhbGwgaW4gcmV2ZXJzZSwgYW5kCisJICAgICAgICAg ICAgIHN0b3AgYXQgdGhlIHN0YXJ0IGFkZHJlc3Mgb2YgdGhlIGZ1bmN0aW9u LiAgR28gYmFjayB0bworCSAgICAgICAgICAgICBzaW5nbGUtc3RlcHBpbmcs IHdoaWNoIHNob3VsZCB0YWtlIHVzIGJhY2sgdG8gdGhlCisJICAgICAgICAg ICAgIGZ1bmN0aW9uIGNhbGwuICAqLworCQkgIGVjcy0+ZXZlbnRfdGhyZWFk LT5zdGVwcGluZ19vdmVyX2JyZWFrcG9pbnQgPSAxOworCQl9CiAJICAgIH0K IAkgIGVsc2UKIAkgICAgaW5zZXJ0X3N0ZXBfcmVzdW1lX2JyZWFrcG9pbnRf YXRfY2FsbGVyIChnZXRfY3VycmVudF9mcmFtZSAoKSk7Cg== --001485f428987413b80469381eb5--