Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hui Zhu <teawater@gmail.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org,
	Marc Khouzam <marc.khouzam@ericsson.com>,
	 	Michael Snyder <msnyder@vmware.com>,
	Thiago Jung Bauermann <bauerman@br.ibm.com>,
	Eli Zaretskii <eliz@gnu.org>,
	 	paawan1982@yahoo.com, Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: [RFA] Submit process record and replay fourth time, 5/8
Date: Wed, 22 Apr 2009 09:09:00 -0000	[thread overview]
Message-ID: <daef60380904220208k4238a0dcxf25aae079f83f6@mail.gmail.com> (raw)
In-Reply-To: <200904211432.48688.pedro@codesourcery.com>

>
> Is this in the last version?  This still has the problem with the
> NULL cleanup I've just explained.
>

The following fix it, this is the new version:

---
 infrun.c |   11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

--- a/infrun.c
+++ b/infrun.c
@@ -48,6 +48,7 @@
 #include "gdb_assert.h"
 #include "mi/mi-common.h"
 #include "event-top.h"
+#include "record.h"

 /* Prototypes for local functions */

@@ -603,7 +604,8 @@ use_displaced_stepping (struct gdbarch *
   return (((can_use_displaced_stepping == can_use_displaced_stepping_auto
 	    && non_stop)
 	   || can_use_displaced_stepping == can_use_displaced_stepping_on)
-	  && gdbarch_displaced_step_copy_insn_p (gdbarch));
+	  && gdbarch_displaced_step_copy_insn_p (gdbarch)
+	  && !RECORD_IS_USED);
 }

 /* Clean out any stray displaced stepping state.  */
@@ -2130,6 +2132,10 @@ adjust_pc_after_break (struct execution_
   if (software_breakpoint_inserted_here_p (breakpoint_pc)
       || (non_stop && moribund_breakpoint_here_p (breakpoint_pc)))
     {
+      struct cleanup *old_cleanups = NULL;
+      if (RECORD_IS_USED)
+	old_cleanups = record_gdb_operation_disable_set ();
+
       /* When using hardware single-step, a SIGTRAP is reported for both
 	 a completed single-step and a software breakpoint.  Need to
 	 differentiate between the two, as the latter needs adjusting
@@ -2153,6 +2159,9 @@ adjust_pc_after_break (struct execution_
 	  || !currently_stepping (ecs->event_thread)
 	  || ecs->event_thread->prev_pc == breakpoint_pc)
 	regcache_write_pc (regcache, breakpoint_pc);
+
+      if (RECORD_IS_USED)
+	do_cleanups (old_cleanups);
     }
 }


  reply	other threads:[~2009-04-22  9:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-21 16:03 Hui Zhu
2009-03-25  7:23 ` Hui Zhu
2009-04-15 17:04   ` Hui Zhu
2009-04-21 13:32     ` Pedro Alves
2009-04-22  9:09       ` Hui Zhu [this message]
2009-04-27 22:22         ` Pedro Alves
2009-04-28 10:03           ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=daef60380904220208k4238a0dcxf25aae079f83f6@mail.gmail.com \
    --to=teawater@gmail.com \
    --cc=bauerman@br.ibm.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=marc.khouzam@ericsson.com \
    --cc=mark.kettenis@xs4all.nl \
    --cc=msnyder@vmware.com \
    --cc=paawan1982@yahoo.com \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox