From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17245 invoked by alias); 23 Mar 2009 02:09:08 -0000 Received: (qmail 16571 invoked by uid 22791); 23 Mar 2009 02:09:07 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.186) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 Mar 2009 02:09:01 +0000 Received: by ti-out-0910.google.com with SMTP id a1so1166353tib.12 for ; Sun, 22 Mar 2009 19:08:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.110.43.20 with SMTP id q20mr2312594tiq.45.1237774138449; Sun, 22 Mar 2009 19:08:58 -0700 (PDT) In-Reply-To: <200903222122.n2MLMFr4011417@brahms.sibelius.xs4all.nl> References: <200903221647.10605.pedro@codesourcery.com> <200903222122.n2MLMFr4011417@brahms.sibelius.xs4all.nl> Date: Mon, 23 Mar 2009 02:12:00 -0000 Message-ID: Subject: Re: [RFA] Submit process record and replay fourth time, 7/8 From: Hui Zhu To: Mark Kettenis Cc: pedro@codesourcery.com, gdb-patches@sourceware.org, marc.khouzam@ericsson.com, msnyder@vmware.com, bauerman@br.ibm.com, eliz@gnu.org, paawan1982@yahoo.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00475.txt.bz2 On Mon, Mar 23, 2009 at 05:22, Mark Kettenis wrot= e: >> From: Pedro Alves >> Date: Sun, 22 Mar 2009 16:47:09 +0000 >> >> On Sunday 22 March 2009 16:43:36, Hui Zhu wrote: >> > About this part, I think it again. =A0I think keep it to macro is >> > better. =A0Because all of values can't be change. =A0Set them to varia= ble >> > just to make record linux code more friendly to other arch. =A0So I >> > think make it to macro is more clear. >> >> I don't think it's clearer at all. =A0I think it's just clutter. > > For what it is worth, I agree with Pedro here. =A0If there is a bunch of > constants like this that are only used once, adding #defines for them > is a bit counterproductive. > > Oh, and in one of the comments there is a space missing in Linux2.4. > > I think most of size between 2.4 and 2.6 are same because these variables are interface to user space. I will check them after p record checked-in. If I find some of them are not same, I will add a command can set it. Do you think it's OK? Thanks, Hui