From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10014 invoked by alias); 22 Mar 2009 17:01:45 -0000 Received: (qmail 9490 invoked by uid 22791); 22 Mar 2009 17:01:44 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.186) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 22 Mar 2009 17:01:39 +0000 Received: by ti-out-0910.google.com with SMTP id a1so1093223tib.12 for ; Sun, 22 Mar 2009 10:01:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.110.42.1 with SMTP id p1mr8918028tip.12.1237741295851; Sun, 22 Mar 2009 10:01:35 -0700 (PDT) In-Reply-To: <200903221647.10605.pedro@codesourcery.com> References: <200903221647.10605.pedro@codesourcery.com> Date: Sun, 22 Mar 2009 17:10:00 -0000 Message-ID: Subject: Re: [RFA] Submit process record and replay fourth time, 7/8 From: Hui Zhu To: Pedro Alves Cc: gdb-patches@sourceware.org, Mark Kettenis , marc.khouzam@ericsson.com, msnyder@vmware.com, bauerman@br.ibm.com, eliz@gnu.org, paawan1982@yahoo.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00459.txt.bz2 Sorry , I forget I need keep it for another function to increase the speed of record. I will move this define to some special head file in this function. So, please let me keep it. Thanks, Hui On Mon, Mar 23, 2009 at 00:47, Pedro Alves wrote: > On Sunday 22 March 2009 16:43:36, Hui Zhu wrote: >> About this part, I think it again. =A0I think keep it to macro is >> better. =A0Because all of values can't be change. =A0Set them to variable >> just to make record linux code more friendly to other arch. =A0So I >> think make it to macro is more clear. > > I don't think it's clearer at all. =A0I think it's just clutter. > > -- > Pedro Alves >