From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30344 invoked by alias); 16 Mar 2009 06:52:02 -0000 Received: (qmail 30333 invoked by uid 22791); 16 Mar 2009 06:52:01 -0000 X-SWARE-Spam-Status: No, hits=-0.6 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_34,J_CHICKENPOX_43,J_CHICKENPOX_44,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.186) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Mar 2009 06:51:55 +0000 Received: by ti-out-0910.google.com with SMTP id y8so1978009tia.12 for ; Sun, 15 Mar 2009 23:51:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.110.61.16 with SMTP id j16mr6998173tia.23.1237186311696; Sun, 15 Mar 2009 23:51:51 -0700 (PDT) In-Reply-To: References: Date: Mon, 16 Mar 2009 07:59:00 -0000 Message-ID: Subject: Re: [RFC] disassemble-next-line From: teawater To: Eli Zaretskii Cc: tromey@redhat.com, dje@google.com, pedro@codesourcery.com, drow@false.org, gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=001485f01e5ea1302e046536e293 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00251.txt.bz2 --001485f01e5ea1302e046536e293 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1537 Hi Eli, I had make the patches for code and doc. Please help me review it. Thanks, Hui On Fri, Mar 13, 2009 at 17:45, Eli Zaretskii wrote: >> Date: Fri, 13 Mar 2009 07:55:59 +0800 >> From: teawater >> Cc: Pedro Alves , Daniel Jacobowitz , >> =A0 =A0 =A0 "gdb-patches@sourceware.org" >> >> + =A0add_setshow_enum_cmd ("disassemble-next-line", class_run, >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 disassemble_next_line_enum, >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 &disassemble_next_line, _("\ >> +Set debugger's willingness to use disassemble-next-line."), _("\ >> +Show debugger's willingness to use disassemble-next-line."), _("\ > > This self-referential doc string is confusing. =A0I suggest to change to > something like this: > > =A0Set whether to disassemble next source line when execution stops. > > and similarly for Show. > >> +If ON, GDB will disassemble the next source line when execution\n\ >> +stops.\n\ > > =A0If ON, GDB will display disassembly of the next source line when\n\ > =A0execution of the program being debugged stops.\n\ > >> +If AUTO (which is the default) or the next source line cannot be\n\ >> +ascertained, the next instruction will be disassembled instead."), > > What does it mean ``the next source line cannot be ascertained''? > > In any case, instead of ``the next instruction will be disassembled > instead'', I suggest ``display disassembly of the next instruction > instead.'' > --001485f01e5ea1302e046536e293 Content-Type: text/plain; charset=US-ASCII; name="disassemble-next-line.txt" Content-Disposition: attachment; filename="disassemble-next-line.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fsct4kxa0 Content-length: 5263 LS0tCiBzdGFjay5jIHwgICA3OSArKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAxIGZp bGUgY2hhbmdlZCwgNzkgaW5zZXJ0aW9ucygrKQoKLS0tIGEvc3RhY2suYwor KysgYi9zdGFjay5jCkBAIC00NSw2ICs0NSw3IEBACiAjaW5jbHVkZSAidmFs cHJpbnQuaCIKICNpbmNsdWRlICJnZGJ0aHJlYWQuaCIKICNpbmNsdWRlICJj cC1zdXBwb3J0LmgiCisjaW5jbHVkZSAiZGlzYXNtLmgiCiAKICNpbmNsdWRl ICJnZGJfYXNzZXJ0LmgiCiAjaW5jbHVkZSA8Y3R5cGUuaD4KQEAgLTQ1Niw2 ICs0NTcsNTggQEAgc2V0X2N1cnJlbnRfc2FsX2Zyb21fZnJhbWUgKHN0cnVj dCBmcmFtZQogICAgIH0KIH0KIAorLyogSWYgT04sIEdEQiB3aWxsIGRpc3Bs YXkgZGlzYXNzZW1ibHkgb2YgdGhlIG5leHQgc291cmNlIGxpbmUgd2hlbgor ICAgZXhlY3V0aW9uIG9mIHRoZSBwcm9ncmFtIGJlaW5nIGRlYnVnZ2VkIHN0 b3BzLgorICAgSWYgQVVUTyAod2hpY2ggaXMgdGhlIGRlZmF1bHQpIG9yIHRo ZSBuZXh0IHNvdXJjZSBsaW5lIGNhbm5vdCBiZQorICAgYXNjZXJ0YWluZWQs IGRpc3BsYXkgZGlzYXNzZW1ibHkgb2YgdGhlIG5leHQgaW5zdHJ1Y3Rpb24K KyAgIGluc3RlYWQuICAqLworCitzdGF0aWMgZW51bSBhdXRvX2Jvb2xlYW4g ZGlzYXNzZW1ibGVfbmV4dF9saW5lOworCitzdGF0aWMgdm9pZAorc2hvd19k aXNhc3NlbWJsZV9uZXh0X2xpbmUgKHN0cnVjdCB1aV9maWxlICpmaWxlLCBp bnQgZnJvbV90dHksCisJCQkJIHN0cnVjdCBjbWRfbGlzdF9lbGVtZW50ICpj LAorCQkJCSBjb25zdCBjaGFyICp2YWx1ZSkKK3sKKyAgZnByaW50Zl9maWx0 ZXJlZCAoZmlsZSwgXygiXAorRGVidWdnZXIncyB3aWxsaW5nbmVzcyB0byB1 c2UgZGlzYXNzZW1ibGUtbmV4dC1saW5lIGlzICVzLlxuIiksCisgICAgICAg ICAgICAgICAgICAgIHZhbHVlKTsKK30KKworLyogU2hvdyBhc3NlbWJseSBj b2Rlczsgc3R1YiBmb3IgY2F0Y2hfZXJyb3JzLiAgKi8KKworc3RydWN0IGdk Yl9kaXNhc3NlbWJseV9zdHViX2FyZ3MKK3sKKyAgaW50IGhvd19tYW55Owor ICBDT1JFX0FERFIgbG93OworICBDT1JFX0FERFIgaGlnaDsKK307CisKK3N0 YXRpYyB2b2lkCitnZGJfZGlzYXNzZW1ibHlfc3R1YiAodm9pZCAqYXJncykK K3sKKyAgc3RydWN0IGdkYl9kaXNhc3NlbWJseV9zdHViX2FyZ3MgKnAgPSBh cmdzOworICBnZGJfZGlzYXNzZW1ibHkgKHVpb3V0LCAwLCAwLCBwLT5ob3df bWFueSwgcC0+bG93LCBwLT5oaWdoKTsKK30KKworLyogVXNlIFRSWV9DQVRD SCB0byBjYXRjaCB0aGUgZXhjZXB0aW9uIGZyb20gdGhlIGdkYl9kaXNhc3Nl bWJseQorICAgYmVjYXVzZSBpdCB3aWxsIGJlIGJyb2tlbiBieSBmaWx0ZXIg c29tZXRpbWUuICAqLworCitzdGF0aWMgdm9pZAorZG9fZ2RiX2Rpc2Fzc2Vt Ymx5IChpbnQgaG93X21hbnksIENPUkVfQUREUiBsb3csIENPUkVfQUREUiBo aWdoKQoreworICB2b2xhdGlsZSBzdHJ1Y3QgZ2RiX2V4Y2VwdGlvbiBleGNl cHRpb247CisgIHN0cnVjdCBnZGJfZGlzYXNzZW1ibHlfc3R1Yl9hcmdzIGFy Z3M7CisKKyAgYXJncy5ob3dfbWFueSA9IGhvd19tYW55OworICBhcmdzLmxv dyA9IGxvdzsKKyAgYXJncy5oaWdoID0gaGlnaDsKKyAgVFJZX0NBVENIIChl eGNlcHRpb24sIFJFVFVSTl9NQVNLX0FMTCkKKyAgICB7CisgICAgICBnZGJf ZGlzYXNzZW1ibHlfc3R1YiAoJmFyZ3MpOworICAgIH0KK30KKwogLyogUHJp bnQgaW5mb3JtYXRpb24gYWJvdXQgZnJhbWUgRlJBTUUuICBUaGUgb3V0cHV0 IGlzIGZvcm1hdCBhY2NvcmRpbmcKICAgIHRvIFBSSU5UX0xFVkVMIGFuZCBQ UklOVF9XSEFUIGFuZCBQUklOVCBBUkdTLiAgVGhlIG1lYW5pbmcgb2YKICAg IFBSSU5UX1dIQVQgaXM6CkBAIC01MzMsNiArNTg2LDEzIEBAIHByaW50X2Zy YW1lX2luZm8gKHN0cnVjdCBmcmFtZV9pbmZvICpmcmEKIAogICBzb3VyY2Vf cHJpbnQgPSAocHJpbnRfd2hhdCA9PSBTUkNfTElORSB8fCBwcmludF93aGF0 ID09IFNSQ19BTkRfTE9DKTsKIAorICAvKiBJZiBkaXNhc3NlbWJsZS1uZXh0 LWxpbmUgaXMgc2V0IHRvIGF1dG8gb3Igb24gYW5kIGRvZXNuJ3QgaGF2ZQor ICAgICB0aGUgbGluZSBkZWJ1ZyBtZXNzYWdlcyBmb3IgJHBjLCBvdXRwdXQg Y3VycmVudCBpbnN0cnVjdGlvbnMuICAqLworICBpZiAoKGRpc2Fzc2VtYmxl X25leHRfbGluZSA9PSBBVVRPX0JPT0xFQU5fQVVUTworICAgICAgIHx8IGRp c2Fzc2VtYmxlX25leHRfbGluZSA9PSBBVVRPX0JPT0xFQU5fVFJVRSkKKyAg ICAgICYmIHNvdXJjZV9wcmludCAmJiAhc2FsLnN5bXRhYikKKyAgICBkb19n ZGJfZGlzYXNzZW1ibHkgKDEsIGdldF9mcmFtZV9wYyAoZnJhbWUpLCBnZXRf ZnJhbWVfcGMgKGZyYW1lKSArIDEpOworCiAgIGlmIChzb3VyY2VfcHJpbnQg JiYgc2FsLnN5bXRhYikKICAgICB7CiAgICAgICBpbnQgZG9uZSA9IDA7CkBA IC01NjksNiArNjI5LDExIEBAIHByaW50X2ZyYW1lX2luZm8gKHN0cnVjdCBm cmFtZV9pbmZvICpmcmEKIAkgICAgICBwcmludF9zb3VyY2VfbGluZXMgKHNh bC5zeW10YWIsIHNhbC5saW5lLCBzYWwubGluZSArIDEsIDApOwogCSAgICB9 CiAJfQorCisgICAgICAvKiBJZiBkaXNhc3NlbWJsZS1uZXh0LWxpbmUgaXMg c2V0IHRvIG9uIGFuZCB0aGVyZSBpcyBsaW5lCisgICAgICAgICBtZXNzYWdl cywgb3V0cHV0IGFzc2VtYmx5IGNvZGVzIGZvciBuZXh0IGxpbmUuICAqLwor ICAgICAgaWYgKGRpc2Fzc2VtYmxlX25leHRfbGluZSA9PSBBVVRPX0JPT0xF QU5fVFJVRSkKKwlkb19nZGJfZGlzYXNzZW1ibHkgKC0xLCBnZXRfZnJhbWVf cGMgKGZyYW1lKSwgc2FsLmVuZCk7CiAgICAgfQogCiAgIGlmIChwcmludF93 aGF0ICE9IExPQ0FUSU9OKQpAQCAtMjA3MSw2ICsyMTM2LDIwIEBAIFVzYWdl OiBmdW5jIDxuYW1lPlxuIikpOwogCQkJXygiU2hvdyBwcmludGluZyBvZiBu b24tc2NhbGFyIGZyYW1lIGFyZ3VtZW50cyIpLAogCQkJTlVMTCwgTlVMTCwg TlVMTCwgJnNldHByaW50bGlzdCwgJnNob3dwcmludGxpc3QpOwogCisgIGFk ZF9zZXRzaG93X2F1dG9fYm9vbGVhbl9jbWQgKCJkaXNhc3NlbWJsZS1uZXh0 LWxpbmUiLCBjbGFzc19zdGFjaywKKwkJCSAgICAgICAgJmRpc2Fzc2VtYmxl X25leHRfbGluZSwgXygiXAorU2V0IHdoZXRoZXIgdG8gZGlzYXNzZW1ibGUg bmV4dCBzb3VyY2UgbGluZSB3aGVuIGV4ZWN1dGlvbiBzdG9wcy4iKSwgXygi XAorU2hvdyB3aGV0aGVyIHRvIGRpc2Fzc2VtYmxlIG5leHQgc291cmNlIGxp bmUgd2hlbiBleGVjdXRpb24gc3RvcHMuIiksIF8oIlwKK0lmIE9OLCBHREIg d2lsbCBkaXNwbGF5IGRpc2Fzc2VtYmx5IG9mIHRoZSBuZXh0IHNvdXJjZSBs aW5lIHdoZW5cblwKK2V4ZWN1dGlvbiBvZiB0aGUgcHJvZ3JhbSBiZWluZyBk ZWJ1Z2dlZCBzdG9wcy5cblwKK0lmIEFVVE8gKHdoaWNoIGlzIHRoZSBkZWZh dWx0KSBvciB0aGUgbmV4dCBzb3VyY2UgbGluZSBjYW5ub3QgYmVcblwKK2Fz Y2VydGFpbmVkLCBkaXNwbGF5IGRpc2Fzc2VtYmx5IG9mIHRoZSBuZXh0IGlu c3RydWN0aW9uXG5cCitpbnN0ZWFkLiIpLAorCQkJICAgICAgICBOVUxMLAor CQkJICAgICAgICBzaG93X2Rpc2Fzc2VtYmxlX25leHRfbGluZSwKKwkJCSAg ICAgICAgJnNldGxpc3QsICZzaG93bGlzdCk7CisgIGRpc2Fzc2VtYmxlX25l eHRfbGluZSA9IEFVVE9fQk9PTEVBTl9BVVRPOworCiAjaWYgMAogICBhZGRf Y21kICgiYmFja3RyYWNlLWxpbWl0IiwgY2xhc3Nfc3RhY2ssIHNldF9iYWNr dHJhY2VfbGltaXRfY29tbWFuZCwgXyhcCiAiU3BlY2lmeSBtYXhpbXVtIG51 bWJlciBvZiBmcmFtZXMgZm9yIFwiYmFja3RyYWNlXCIgdG8gcHJpbnQgYnkg ZGVmYXVsdC4iKSwK --001485f01e5ea1302e046536e293 Content-Type: text/plain; charset=US-ASCII; name="disassemble-next-line-doc.txt" Content-Disposition: attachment; filename="disassemble-next-line-doc.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fsct4s741 Content-length: 1977 LS0tCiBkb2MvZ2RiLnRleGluZm8gfCAgIDE3ICsrKysrKysrKysrKysrKyst CiAxIGZpbGUgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlv bigtKQoKLS0tIGEvZG9jL2dkYi50ZXhpbmZvCisrKyBiL2RvYy9nZGIudGV4 aW5mbwpAQCAtNTkxMCw3ICs1OTEwLDkgQEAgZGlyZWN0b3JpZXMgaW4gb25l IGNvbW1hbmQuCiAKIFlvdSBjYW4gdXNlIHRoZSBjb21tYW5kIEBjb2Rle2lu Zm8gbGluZX0gdG8gbWFwIHNvdXJjZSBsaW5lcyB0byBwcm9ncmFtCiBhZGRy ZXNzZXMgKGFuZCB2aWNlIHZlcnNhKSwgYW5kIHRoZSBjb21tYW5kIEBjb2Rl e2Rpc2Fzc2VtYmxlfSB0byBkaXNwbGF5Ci1hIHJhbmdlIG9mIGFkZHJlc3Nl cyBhcyBtYWNoaW5lIGluc3RydWN0aW9ucy4gIFdoZW4gcnVuIHVuZGVyIEBz Y3tnbnV9IEVtYWNzCithIHJhbmdlIG9mIGFkZHJlc3NlcyBhcyBtYWNoaW5l IGluc3RydWN0aW9ucy4gIFlvdSBjYW4gdXNlIHRoZSBjb21tYW5kCitAY29k ZXtzZXQgZGlzYXNzZW1ibGUtbmV4dC1saW5lfSB0byBzZXQgd2hldGhlciB0 byBkaXNhc3NlbWJsZSBuZXh0Citzb3VyY2UgbGluZSB3aGVuIGV4ZWN1dGlv biBzdG9wcy4gIFdoZW4gcnVuIHVuZGVyIEBzY3tnbnV9IEVtYWNzCiBtb2Rl LCB0aGUgQGNvZGV7aW5mbyBsaW5lfSBjb21tYW5kIGNhdXNlcyB0aGUgYXJy b3cgdG8gcG9pbnQgdG8gdGhlCiBsaW5lIHNwZWNpZmllZC4gIEFsc28sIEBj b2Rle2luZm8gbGluZX0gcHJpbnRzIGFkZHJlc3NlcyBpbiBzeW1ib2xpYyBm b3JtIGFzCiB3ZWxsIGFzIGhleC4KQEAgLTYwNDAsNiArNjA0MiwxOSBAQCBh c3NlbWJsZXJzIGZvciB4ODYtYmFzZWQgdGFyZ2V0cy4KIFNob3cgdGhlIGN1 cnJlbnQgc2V0dGluZyBvZiB0aGUgZGlzYXNzZW1ibHkgZmxhdm9yLgogQGVu ZCB0YWJsZQogCitAdGFibGUgQGNvZGUKK0BraW5kZXggc2V0IGRpc2Fzc2Vt YmxlLW5leHQtbGluZQorQGtpbmRleCBzaG93IGRpc2Fzc2VtYmxlLW5leHQt bGluZQorQGl0ZW0gc2V0IGRpc2Fzc2VtYmxlLW5leHQtbGluZQorQGl0ZW14 IHNob3cgZGlzYXNzZW1ibGUtbmV4dC1saW5lCitDb250cm9sIHdoZXRoZXIg b3Igbm90IEB2YWx1ZXtHREJOfSB3aWxsIGRpc2Fzc2VtYmxlIG5leHQgc291 cmNlIGxpbmUKK3doZW4gZXhlY3V0aW9uIHN0b3BzLiAgSWYgT04sIEdEQiB3 aWxsIGRpc3BsYXkgZGlzYXNzZW1ibHkgb2YgdGhlIG5leHQKK3NvdXJjZSBs aW5lIHdoZW4gZXhlY3V0aW9uIG9mIHRoZSBwcm9ncmFtIGJlaW5nIGRlYnVn Z2VkIHN0b3BzLgorSWYgQVVUTyAod2hpY2ggaXMgdGhlIGRlZmF1bHQpIG9y IHRoZSBuZXh0IHNvdXJjZSBsaW5lIGNhbm5vdCBiZQorYXNjZXJ0YWluZWQs IGRpc3BsYXkgZGlzYXNzZW1ibHkgb2YgdGhlIG5leHQgaW5zdHJ1Y3Rpb24K K2luc3RlYWQuCitAZW5kIHRhYmxlCisKIAogQG5vZGUgRGF0YQogQGNoYXB0 ZXIgRXhhbWluaW5nIERhdGEK --001485f01e5ea1302e046536e293--