From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13894 invoked by alias); 13 Mar 2009 03:10:13 -0000 Received: (qmail 13869 invoked by uid 22791); 13 Mar 2009 03:10:08 -0000 X-SWARE-Spam-Status: No, hits=-0.7 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_34,J_CHICKENPOX_43,J_CHICKENPOX_44,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.184) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Mar 2009 03:10:01 +0000 Received: by ti-out-0910.google.com with SMTP id y8so1267176tia.12 for ; Thu, 12 Mar 2009 20:09:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.110.10.16 with SMTP id 16mr1191052tij.27.1236913798343; Thu, 12 Mar 2009 20:09:58 -0700 (PDT) In-Reply-To: <200903130020.46530.pedro@codesourcery.com> References: <200903130020.46530.pedro@codesourcery.com> Date: Fri, 13 Mar 2009 05:54:00 -0000 Message-ID: Subject: Re: [RFC] disassemble-next-line From: teawater To: Pedro Alves Cc: gdb-patches@sourceware.org, Tom Tromey , Eli Zaretskii , Doug Evans , Daniel Jacobowitz Content-Type: multipart/mixed; boundary=0016e652f64c916c7c0464f76f6a X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00195.txt.bz2 --0016e652f64c916c7c0464f76f6a Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 893 Hi Pedro. The enum auto_boolean and add_setshow_auto_boolean_cmd is cool. Thanks for you remind me. I had changed it. Do you think it's OK? Thanks, Hui On Fri, Mar 13, 2009 at 08:20, Pedro Alves wrote: >> --- a/stack.c >> +++ b/stack.c >> >> +/* Enum strings for "set|show disassemble-next-line". =A0*/ >> + >> +static const char disassemble_next_line_auto[] =3D "auto"; >> +static const char disassemble_next_line_on[] =3D "on"; >> +static const char disassemble_next_line_off[] =3D "off"; >> +static const char *disassemble_next_line_enum[] =3D >> +{ >> + =A0disassemble_next_line_auto, >> + =A0disassemble_next_line_on, >> + =A0disassemble_next_line_off, >> + =A0NULL, >> +}; > > Please make this an `enum auto_boolean' / AUTO_BOOLEAN_AUTO, and > register the "disassemble-next-line" command with > add_setshow_auto_boolean_cmd instead. > > -- > Pedro Alves > --0016e652f64c916c7c0464f76f6a Content-Type: text/plain; charset=US-ASCII; name="disassemble-next-line.txt" Content-Disposition: attachment; filename="disassemble-next-line.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fs8atocw0 Content-length: 5112 LS0tCiBzdGFjay5jIHwgICA3NyArKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAxIGZp bGUgY2hhbmdlZCwgNzcgaW5zZXJ0aW9ucygrKQoKLS0tIGEvc3RhY2suYwor KysgYi9zdGFjay5jCkBAIC00NSw2ICs0NSw3IEBACiAjaW5jbHVkZSAidmFs cHJpbnQuaCIKICNpbmNsdWRlICJnZGJ0aHJlYWQuaCIKICNpbmNsdWRlICJj cC1zdXBwb3J0LmgiCisjaW5jbHVkZSAiZGlzYXNtLmgiCiAKICNpbmNsdWRl ICJnZGJfYXNzZXJ0LmgiCiAjaW5jbHVkZSA8Y3R5cGUuaD4KQEAgLTQ1Niw2 ICs0NTcsNTcgQEAgc2V0X2N1cnJlbnRfc2FsX2Zyb21fZnJhbWUgKHN0cnVj dCBmcmFtZQogICAgIH0KIH0KIAorLyogSWYgT04sIEdEQiB3aWxsIGRpc2Fz c2VtYmxlIHRoZSBuZXh0IHNvdXJjZSBsaW5lIHdoZW4gZXhlY3V0aW9uCisg ICBzdG9wcy4KKyAgIElmIEFVVE8gKHdoaWNoIGlzIHRoZSBkZWZhdWx0KSBv ciB0aGUgbmV4dCBzb3VyY2UgbGluZSBjYW5ub3QgYmUKKyAgIGFzY2VydGFp bmVkLCB0aGUgbmV4dCBpbnN0cnVjdGlvbiB3aWxsIGJlIGRpc2Fzc2VtYmxl ZCBpbnN0ZWFkLiAgKi8KKworc3RhdGljIGVudW0gYXV0b19ib29sZWFuIGRp c2Fzc2VtYmxlX25leHRfbGluZTsKKworc3RhdGljIHZvaWQKK3Nob3dfZGlz YXNzZW1ibGVfbmV4dF9saW5lIChzdHJ1Y3QgdWlfZmlsZSAqZmlsZSwgaW50 IGZyb21fdHR5LAorCQkJCSBzdHJ1Y3QgY21kX2xpc3RfZWxlbWVudCAqYywK KwkJCQkgY29uc3QgY2hhciAqdmFsdWUpCit7CisgIGZwcmludGZfZmlsdGVy ZWQgKGZpbGUsIF8oIlwKK0RlYnVnZ2VyJ3Mgd2lsbGluZ25lc3MgdG8gdXNl IGRpc2Fzc2VtYmxlLW5leHQtbGluZSBpcyAlcy5cbiIpLAorICAgICAgICAg ICAgICAgICAgICB2YWx1ZSk7Cit9CisKKy8qIFNob3cgYXNzZW1ibHkgY29k ZXM7IHN0dWIgZm9yIGNhdGNoX2Vycm9ycy4gICovCisKK3N0cnVjdCBnZGJf ZGlzYXNzZW1ibHlfc3R1Yl9hcmdzCit7CisgIGludCBob3dfbWFueTsKKyAg Q09SRV9BRERSIGxvdzsKKyAgQ09SRV9BRERSIGhpZ2g7Cit9OworCitzdGF0 aWMgdm9pZAorZ2RiX2Rpc2Fzc2VtYmx5X3N0dWIgKHZvaWQgKmFyZ3MpCit7 CisgIHN0cnVjdCBnZGJfZGlzYXNzZW1ibHlfc3R1Yl9hcmdzICpwID0gYXJn czsKKyAgZ2RiX2Rpc2Fzc2VtYmx5ICh1aW91dCwgMCwgMCwgcC0+aG93X21h bnksIHAtPmxvdywgcC0+aGlnaCk7Cit9CisKKy8qIFVzZSBUUllfQ0FUQ0gg dG8gY2F0Y2ggdGhlIGV4Y2VwdGlvbiBmcm9tIHRoZSBnZGJfZGlzYXNzZW1i bHkKKyAgIGJlY2F1c2UgaXQgd2lsbCBiZSBicm9rZW4gYnkgZmlsdGVyIHNv bWV0aW1lLiAgKi8KKworc3RhdGljIHZvaWQKK2RvX2dkYl9kaXNhc3NlbWJs eSAoaW50IGhvd19tYW55LCBDT1JFX0FERFIgbG93LCBDT1JFX0FERFIgaGln aCkKK3sKKyAgdm9sYXRpbGUgc3RydWN0IGdkYl9leGNlcHRpb24gZXhjZXB0 aW9uOworICBzdHJ1Y3QgZ2RiX2Rpc2Fzc2VtYmx5X3N0dWJfYXJncyBhcmdz OworCisgIGFyZ3MuaG93X21hbnkgPSBob3dfbWFueTsKKyAgYXJncy5sb3cg PSBsb3c7CisgIGFyZ3MuaGlnaCA9IGhpZ2g7CisgIFRSWV9DQVRDSCAoZXhj ZXB0aW9uLCBSRVRVUk5fTUFTS19BTEwpCisgICAgeworICAgICAgZ2RiX2Rp c2Fzc2VtYmx5X3N0dWIgKCZhcmdzKTsKKyAgICB9Cit9CisKIC8qIFByaW50 IGluZm9ybWF0aW9uIGFib3V0IGZyYW1lIEZSQU1FLiAgVGhlIG91dHB1dCBp cyBmb3JtYXQgYWNjb3JkaW5nCiAgICB0byBQUklOVF9MRVZFTCBhbmQgUFJJ TlRfV0hBVCBhbmQgUFJJTlQgQVJHUy4gIFRoZSBtZWFuaW5nIG9mCiAgICBQ UklOVF9XSEFUIGlzOgpAQCAtNTMzLDYgKzU4NSwxMyBAQCBwcmludF9mcmFt ZV9pbmZvIChzdHJ1Y3QgZnJhbWVfaW5mbyAqZnJhCiAKICAgc291cmNlX3By aW50ID0gKHByaW50X3doYXQgPT0gU1JDX0xJTkUgfHwgcHJpbnRfd2hhdCA9 PSBTUkNfQU5EX0xPQyk7CiAKKyAgLyogSWYgZGlzYXNzZW1ibGUtbmV4dC1s aW5lIGlzIHNldCB0byBhdXRvIG9yIG9uIGFuZCBkb2Vzbid0IGhhdmUKKyAg ICAgdGhlIGxpbmUgZGVidWcgbWVzc2FnZXMgZm9yICRwYywgb3V0cHV0IGN1 cnJlbnQgaW5zdHJ1Y3Rpb25zLiAgKi8KKyAgaWYgKChkaXNhc3NlbWJsZV9u ZXh0X2xpbmUgPT0gQVVUT19CT09MRUFOX0FVVE8KKyAgICAgICB8fCBkaXNh c3NlbWJsZV9uZXh0X2xpbmUgPT0gQVVUT19CT09MRUFOX1RSVUUpCisgICAg ICAmJiBzb3VyY2VfcHJpbnQgJiYgIXNhbC5zeW10YWIpCisgICAgZG9fZ2Ri X2Rpc2Fzc2VtYmx5ICgxLCBnZXRfZnJhbWVfcGMgKGZyYW1lKSwgZ2V0X2Zy YW1lX3BjIChmcmFtZSkgKyAxKTsKKwogICBpZiAoc291cmNlX3ByaW50ICYm IHNhbC5zeW10YWIpCiAgICAgewogICAgICAgaW50IGRvbmUgPSAwOwpAQCAt NTY5LDYgKzYyOCwxMSBAQCBwcmludF9mcmFtZV9pbmZvIChzdHJ1Y3QgZnJh bWVfaW5mbyAqZnJhCiAJICAgICAgcHJpbnRfc291cmNlX2xpbmVzIChzYWwu c3ltdGFiLCBzYWwubGluZSwgc2FsLmxpbmUgKyAxLCAwKTsKIAkgICAgfQog CX0KKworICAgICAgLyogSWYgZGlzYXNzZW1ibGUtbmV4dC1saW5lIGlzIHNl dCB0byBvbiBhbmQgdGhlcmUgaXMgbGluZQorICAgICAgICAgbWVzc2FnZXMs IG91dHB1dCBhc3NlbWJseSBjb2RlcyBmb3IgbmV4dCBsaW5lLiAgKi8KKyAg ICAgIGlmIChkaXNhc3NlbWJsZV9uZXh0X2xpbmUgPT0gQVVUT19CT09MRUFO X1RSVUUpCisJZG9fZ2RiX2Rpc2Fzc2VtYmx5ICgtMSwgZ2V0X2ZyYW1lX3Bj IChmcmFtZSksIHNhbC5lbmQpOwogICAgIH0KIAogICBpZiAocHJpbnRfd2hh dCAhPSBMT0NBVElPTikKQEAgLTIwNjIsNiArMjEyNiwxOSBAQCBVc2FnZTog ZnVuYyA8bmFtZT5cbiIpKTsKIAkJCV8oIlNob3cgcHJpbnRpbmcgb2Ygbm9u LXNjYWxhciBmcmFtZSBhcmd1bWVudHMiKSwKIAkJCU5VTEwsIE5VTEwsIE5V TEwsICZzZXRwcmludGxpc3QsICZzaG93cHJpbnRsaXN0KTsKIAorICBhZGRf c2V0c2hvd19hdXRvX2Jvb2xlYW5fY21kICgiZGlzYXNzZW1ibGUtbmV4dC1s aW5lIiwgY2xhc3Nfc3RhY2ssCisJCQkgICAgICAgICZkaXNhc3NlbWJsZV9u ZXh0X2xpbmUsIF8oIlwKK1NldCBkZWJ1Z2dlcidzIHdpbGxpbmduZXNzIHRv IHVzZSBkaXNhc3NlbWJsZS1uZXh0LWxpbmUuIiksIF8oIlwKK1Nob3cgZGVi dWdnZXIncyB3aWxsaW5nbmVzcyB0byB1c2UgZGlzYXNzZW1ibGUtbmV4dC1s aW5lLiIpLCBfKCJcCitJZiBPTiwgR0RCIHdpbGwgZGlzYXNzZW1ibGUgdGhl IG5leHQgc291cmNlIGxpbmUgd2hlbiBleGVjdXRpb25cblwKK3N0b3BzLlxu XAorSWYgQVVUTyAod2hpY2ggaXMgdGhlIGRlZmF1bHQpIG9yIHRoZSBuZXh0 IHNvdXJjZSBsaW5lIGNhbm5vdCBiZVxuXAorYXNjZXJ0YWluZWQsIHRoZSBu ZXh0IGluc3RydWN0aW9uIHdpbGwgYmUgZGlzYXNzZW1ibGVkIGluc3RlYWQu IiksCisJCQkgICAgICAgIE5VTEwsCisJCQkgICAgICAgIHNob3dfZGlzYXNz ZW1ibGVfbmV4dF9saW5lLAorCQkJICAgICAgICAmc2V0bGlzdCwgJnNob3ds aXN0KTsKKyAgZGlzYXNzZW1ibGVfbmV4dF9saW5lID0gQVVUT19CT09MRUFO X0FVVE87CisKICNpZiAwCiAgIGFkZF9jbWQgKCJiYWNrdHJhY2UtbGltaXQi LCBjbGFzc19zdGFjaywgc2V0X2JhY2t0cmFjZV9saW1pdF9jb21tYW5kLCBf KFwKICJTcGVjaWZ5IG1heGltdW0gbnVtYmVyIG9mIGZyYW1lcyBmb3IgXCJi YWNrdHJhY2VcIiB0byBwcmludCBieSBkZWZhdWx0LiIpLAo= --0016e652f64c916c7c0464f76f6a--