From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6469 invoked by alias); 10 Mar 2009 14:31:50 -0000 Received: (qmail 6461 invoked by uid 22791); 10 Mar 2009 14:31:49 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_44,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.190) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Mar 2009 14:31:39 +0000 Received: by ti-out-0910.google.com with SMTP id y8so1346747tia.12 for ; Tue, 10 Mar 2009 07:31:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.110.84.7 with SMTP id h7mr11056530tib.33.1236695496255; Tue, 10 Mar 2009 07:31:36 -0700 (PDT) In-Reply-To: <200903091931.07316.pedro@codesourcery.com> References: <200903032039.57204.pedro@codesourcery.com> <200903091931.07316.pedro@codesourcery.com> Date: Tue, 10 Mar 2009 17:03:00 -0000 Message-ID: Subject: Re: [RFA] Submit process record and replay third time, 3/9 From: teawater To: Pedro Alves Cc: gdb-patches@sourceware.org, Marc Khouzam Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00142.txt.bz2 Hi Pedro, On Tue, Mar 10, 2009 at 03:31, Pedro Alves wrote: > On Wednesday 04 March 2009 03:41:59, teawater wrote: > >> >> +# For the process record and replay target. >> >> +M:int:process_record:CORE_ADDR addr:addr >> > >> > You'll need to extend this comment a little further. =A0What is this >> > callback really for? =A0E.g., what is it supposed to do? =A0These thin= gs >> > should be documented here. >> >> What about the following: >> # Record a execution log of instruction at address addr. > > How about something more descriptive like: > > /* Parse the instruction at ADDR storing in the record execution log > =A0 the registers and memory ranges that will be affected when the > =A0 instruction executes, along with their current values. =A0Return -1 > =A0 if something goes wrong, 0 otherwise. =A0*/ It's more better than mine. I will use it. > >> By the way, process_record_dasm is so ugly name. =A0Do you have some ide= a with it? > > No, sorry, because I don't know what "dasm" means. Maybe delay it until I post a arch code that use it is better. :) Thanks for you help. Hui