Re: [RFA] Submit process record and replay third time, 3/9

teawater
2009-03-09T06:01:08Z

Hi Pedro,

Sorry to disturb you.
Could you please help me review it?

Thanks,
Hui

On Wed, Mar 4, 2009 at 11:41, teawater <teawater@gmail.com> wrote:
>
> Thanks Pedro,
>
> To get your mail is great for me.  :)
>
> On Wed, Mar 4, 2009 at 04:39, Pedro Alves <pedro@codesourcery.com> wrote:
> > Hi Hui,
> >
> > Sorry for the delay in getting back to this.
> >
> > On Monday 23 February 2009 09:20:13, teawater wrote:
> >
> >> ---
> >>  gdbarch.sh |    4 ++++
> >>  1 file changed, 4 insertions(+)
> >>
> >> --- a/gdbarch.sh
> >> +++ b/gdbarch.sh
> >> @@ -709,6 +709,10 @@ F:char *:static_transform_name:char *nam
> >>  # Set if the address in N_SO or N_FUN stabs may be zero.
> >>  v:int:sofun_address_maybe_missing:::0:0::0
> >>
> >> +# For the process record and replay target.
> >> +M:int:process_record:CORE_ADDR addr:addr
> >
> > You'll need to extend this comment a little further.  What is this
> > callback really for?  E.g., what is it supposed to do?  These things
> > should be documented here.
>
> What about the following:
> # Record a execution log of instruction at address addr.
>
>
> >
> > About the interface itself, would it be possible to adjust the
> > interface to make this callback's implementations not call record.c
> > functions, but instead have record.c work only with the results of
> > this callback?
>
> Are you mean i386_process_record doesn't call the function in record.c?
> That is so hard.  A lot of this record is same for each arch.  So I
> encapsulation them to be some function.
> For example,  record_arch_list_add_reg and record_arch_list_add_mem.
> Another arch will need it in the future.
> So, do you think it's ok?
>
>
> >
> >> +M:void:process_record_dasm:void
> >> +
> >
> > I'm puzzled by this one.  What's this for?  I can't see it being
> > used anywhere, did I miss something?  What's "dasm"?  If its not
> > used for anything yet, let's remove it for now.
> >
> In replay mode, gdb will call gdbarch_process_record_dasm to let arch
> special code analyzes the current instruction and do some replay job.
> It will make record speed up and decrease the memory use.
>
> It just support by mips arch, but mips precord code is removed now.
> So I will removed it and add it back when some arch support it.
>
> By the way, process_record_dasm is so ugly name.  Do you have some idea with it?
>
>
> Thanks,
> Hui