Re: [RFA] Submit process record and replay third time, 3/9

Pedro Alves
2009-01-23T15:34:24Z

On Friday 23 January 2009 14:56:03, teawater wrote:

> Do you think I need change:
> if (record_debug > 1)
> {
> fprintf_unfiltered (gdb_stdlog,
> "Process record: record_arch_list_add 0x%s.\n",
> paddr_nz ((CORE_ADDR)rec));
> }
> to:
> if (record_debug > 1)
> fprintf_unfiltered (gdb_stdlog,
> "Process record: record_arch_list_add 0x%s.\n",
> paddr_nz ((CORE_ADDR)rec));

Yes, thank you, but please be sure to keep correct tab/spacing.

But..., I just noticed that ``rec'' is a pointer to memory in GDB.
Don't ever cast those to CORE_ADDR, which is *target* address.

If you think these debug messages are important to keep, then please
change this and all similar cases to use host_address_to_string
instead of paddr*.

--
Pedro Alves