Re: [RFA] Submit process record and replay third time, 3/9

teawater
2009-03-10T14:31:50Z

Hi Pedro,

On Tue, Mar 10, 2009 at 03:31, Pedro Alves <pedro@codesourcery.com> wrote:
> On Wednesday 04 March 2009 03:41:59, teawater wrote:
>
>> >> +# For the process record and replay target.
>> >> +M:int:process_record:CORE_ADDR addr:addr
>> >
>> > You'll need to extend this comment a little further.  What is this
>> > callback really for?  E.g., what is it supposed to do?  These things
>> > should be documented here.
>>
>> What about the following:
>> # Record a execution log of instruction at address addr.
>
> How about something more descriptive like:
>
> /* Parse the instruction at ADDR storing in the record execution log
>   the registers and memory ranges that will be affected when the
>   instruction executes, along with their current values.  Return -1
>   if something goes wrong, 0 otherwise.  */

It's more better than mine. I will use it.

>
>> By the way, process_record_dasm is so ugly name.  Do you have some idea with it?
>
> No, sorry, because I don't know what "dasm" means.

Maybe delay it until I post a arch code that use it is better. :)

Thanks for you help.

Hui