From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3578 invoked by alias); 23 Jan 2009 15:55:03 -0000 Received: (qmail 3569 invoked by uid 22791); 23 Jan 2009 15:55:03 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.189) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 23 Jan 2009 15:54:59 +0000 Received: by ti-out-0910.google.com with SMTP id d10so3302101tib.12 for ; Fri, 23 Jan 2009 07:54:56 -0800 (PST) MIME-Version: 1.0 Received: by 10.110.43.18 with SMTP id q18mr1815716tiq.14.1232726096935; Fri, 23 Jan 2009 07:54:56 -0800 (PST) In-Reply-To: <200901231535.17239.pedro@codesourcery.com> References: <200901221324.02225.pedro@codesourcery.com> <200901231535.17239.pedro@codesourcery.com> Date: Fri, 23 Jan 2009 15:55:00 -0000 Message-ID: Subject: Re: [RFA] Submit process record and replay third time, 3/9 From: teawater To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00468.txt.bz2 I see. Thanks Pedro. Hui On Fri, Jan 23, 2009 at 23:35, Pedro Alves wrote: > On Friday 23 January 2009 14:56:03, teawater wrote: > >> Do you think I need change: >> if (record_debug > 1) >> { >> fprintf_unfiltered (gdb_stdlog, >> "Process record: record_arch_list_add 0x%s.\n", >> paddr_nz ((CORE_ADDR)rec)); >> } >> to: >> if (record_debug > 1) >> fprintf_unfiltered (gdb_stdlog, >> "Process record: record_arch_list_add 0x%s.\n", >> paddr_nz ((CORE_ADDR)rec)); > > Yes, thank you, but please be sure to keep correct tab/spacing. > > But..., I just noticed that ``rec'' is a pointer to memory in GDB. > Don't ever cast those to CORE_ADDR, which is *target* address. > > If you think these debug messages are important to keep, then please > change this and all similar cases to use host_address_to_string > instead of paddr*. > > -- > Pedro Alves >