From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20421 invoked by alias); 23 Jan 2009 06:58:07 -0000 Received: (qmail 20413 invoked by uid 22791); 23 Jan 2009 06:58:06 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_93,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.187) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 23 Jan 2009 06:58:02 +0000 Received: by ti-out-0910.google.com with SMTP id d10so3253676tib.12 for ; Thu, 22 Jan 2009 22:57:59 -0800 (PST) MIME-Version: 1.0 Received: by 10.110.43.16 with SMTP id q16mr12701546tiq.55.1232693879619; Thu, 22 Jan 2009 22:57:59 -0800 (PST) In-Reply-To: References: <200901222234.25828.pedro@codesourcery.com> <200901222236.54667.pedro@codesourcery.com> Date: Fri, 23 Jan 2009 06:58:00 -0000 Message-ID: Subject: Re: [RFA] Submit process record and replay third time, 3/9 From: teawater To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=001485f07c62cfc02b046120e828 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00462.txt.bz2 --001485f07c62cfc02b046120e828 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 1711 Hi Pedro, I found that remote.c use signal so I make a patch change sigaction to signal. Do you think I can keep record.c in all place with this patch? Thanks, Hui On Fri, Jan 23, 2009 at 08:00, teawater wrote: > I think my prev mail is not right. > > linux-record.c is not like record.c. It's for the tgt part and it > doesn't have some os-special code. > > I think I will try to put it close to linux-nat.c. > > BTW I really want record.c to be a os-nospecial code. Do you have some > idea with it. I think there just 2 sigaction in there, maybe I can > make it not os-special. > > > And for this record_beneath_to_xxx function pointer, do you agree with I said? > > > Thanks, > Hui > > On Fri, Jan 23, 2009 at 06:36, Pedro Alves wrote: >> On Thursday 22 January 2009 22:34:25, Pedro Alves write: >>> Here's what I propose you try as first step: remove all references to record.o >>> from Makefile.in and configure.tgt. Try building. You'll get link errors. Now, >>> come up with interfaces between the core and record.c that would preserve all >>> functionality if record.o isn't included in the link; but that will still link >>> a gdb executable, if record.o isn't linked in. >> >> Sigh, I said "isn't" when I mean "is". Let me try again, >> >> Here's what I propose you try as first step: remove all references to record.o >> from Makefile.in and configure.tgt. Try building. You'll get link errors. Now, >> come up with interfaces between the core and record.c that would preserve all >> functionality if record.o *is* included in the link; but that will still link >> a gdb executable, if record.o *isn't* linked in. >> >> -- >> Pedro Alves >> > --001485f07c62cfc02b046120e828 Content-Type: text/plain; charset=US-ASCII; name="record-target-remove-sigaction.txt" Content-Disposition: attachment; filename="record-target-remove-sigaction.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fqaics1z0 Content-length: 1822 SW5kZXg6IGdkYi9yZWNvcmQuYwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBnZGIub3JpZy9yZWNvcmQuYwkyMDA5LTAxLTIzIDEwOjQ4OjIzLjAwMDAw MDAwMCArMDgwMAorKysgZ2RiL3JlY29yZC5jCTIwMDktMDEtMjMgMTU6MDQ6 MTEuMDAwMDAwMDAwICswODAwCkBAIC0yMyw2ICsyMyw3IEBACiAjaW5jbHVk ZSAicmVnY2FjaGUuaCIKICNpbmNsdWRlICJpbmZlcmlvci5oIgogI2luY2x1 ZGUgImdkYnRocmVhZC5oIgorI2luY2x1ZGUgImV2ZW50LXRvcC5oIgogI2lu Y2x1ZGUgInJlY29yZC5oIgogCiAjaW5jbHVkZSA8c2lnbmFsLmg+CkBAIC02 MjEsNyArNjIyLDYgQEAKICAgICB9CiAgIGVsc2UKICAgICB7Ci0gICAgICBz dHJ1Y3Qgc2lnYWN0aW9uIGFjdCwgb2xkX2FjdDsKICAgICAgIGludCBuZWVk X2Rhc20gPSAwOwogICAgICAgc3RydWN0IHJlZ2NhY2hlICpyZWdjYWNoZSA9 IGdldF9jdXJyZW50X3JlZ2NhY2hlICgpOwogICAgICAgaW50IGNvbnRpbnVl X2ZsYWcgPSAxOwpAQCAtNjU2LDEzICs2NTYsNyBAQAogCX0KIAogICAgICAg cmVjb3JkX2dldF9zaWcgPSAwOwotICAgICAgYWN0LnNhX2hhbmRsZXIgPSBy ZWNvcmRfc2lnX2hhbmRsZXI7Ci0gICAgICBhY3Quc2FfbWFzayA9IHJlY29y ZF9tYXNrYWxsOwotICAgICAgYWN0LnNhX2ZsYWdzID0gU0FfUkVTVEFSVDsK LSAgICAgIGlmIChzaWdhY3Rpb24gKFNJR0lOVCwgJmFjdCwgJm9sZF9hY3Qp KQotCXsKLQkgIHBlcnJvcl93aXRoX25hbWUgKF8oIlByb2Nlc3MgcmVjb3Jk OiBzaWdhY3Rpb24gZmFpbGVkIikpOwotCX0KKyAgICAgIHNpZ25hbCAoU0lH SU5ULCByZWNvcmRfc2lnX2hhbmRsZXIpOwogICAgICAgLyogSWYgR0RCIGlz IGluIHRlcm1pbmFsX2luZmVyaW9yIG1vZGUsIGl0IHdpbGwgbm90IGdldCB0 aGUgc2lnbmFsLgogICAgICAgICAgQW5kIGluIEdEQiByZXBsYXkgbW9kZSwg R0RCIGRvZXNuJ3QgbmVlZCB0byBiZSBpbiB0ZXJtaW5hbF9pbmZlcmlvcgog ICAgICAgICAgbW9kZSwgYmVjYXVzZSBpbmZlcmlvciB3aWxsIG5vdCBleGVj dXRlZC4KQEAgLTgzMSwxMCArODI1LDcgQEAKIAl9CiAgICAgICB3aGlsZSAo Y29udGludWVfZmxhZyk7CiAKLSAgICAgIGlmIChzaWdhY3Rpb24gKFNJR0FM Uk0sICZvbGRfYWN0LCBOVUxMKSkKLQl7Ci0JICBwZXJyb3Jfd2l0aF9uYW1l IChfKCJQcm9jZXNzIHJlY29yZDogc2lnYWN0aW9uIGZhaWxlZCIpKTsKLQl9 CisgICAgICBzaWduYWwgKFNJR0lOVCwgaGFuZGxlX3NpZ2ludCk7CiAKIHJl cGxheV9vdXQ6CiAgICAgICBpZiAocmVjb3JkX2dldF9zaWcpCg== --001485f07c62cfc02b046120e828--