From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26647 invoked by alias); 22 Jan 2009 09:00:43 -0000 Received: (qmail 26418 invoked by uid 22791); 22 Jan 2009 09:00:41 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_39,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.186) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 22 Jan 2009 09:00:36 +0000 Received: by ti-out-0910.google.com with SMTP id d10so3126934tib.12 for ; Thu, 22 Jan 2009 01:00:33 -0800 (PST) MIME-Version: 1.0 Received: by 10.110.15.19 with SMTP id 19mr12682069tio.6.1232614833868; Thu, 22 Jan 2009 01:00:33 -0800 (PST) Date: Thu, 22 Jan 2009 09:00:00 -0000 Message-ID: Subject: [RFA] Patch to fix "reverse-next" command error From: teawater To: Michael Snyder , Pedro Alves Cc: Marc Khouzam , "gdb-patches@sourceware.org" Content-Type: multipart/mixed; boundary=0016e64e92f05151b404610e8164 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00444.txt.bz2 --0016e64e92f05151b404610e8164 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 668 Hi guys, This patch is for bug in http://sourceware.org/ml/gdb/2009-01/msg00146.html This issue is because sometime the inferior is already in function start address (i.e. plt), set a breakpoint and continue will make "reverse-next" work error. This patch make inferior step if it reverse step and stop at the function start address. It tested OK with process record patch and testsuite gdb.twreverse in branch reverse-20081226-branch. 2009-01-22 Hui Zhu * infrun.c (handle_inferior_event): Make inferior step if it stepping over a function call in reverse , and stop at the start address of the function. OK for mainline? Thanks, Hui --0016e64e92f05151b404610e8164 Content-Type: text/plain; charset=US-ASCII; name="fix-reverse-plt-error.txt" Content-Disposition: attachment; filename="fix-reverse-plt-error.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fq970hkb0 Content-length: 1501 SW5kZXg6IGdkYi9pbmZydW4uYwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBnZGIub3JpZy9pbmZydW4uYwkyMDA5LTAxLTIyIDE0OjU4OjMxLjAwMDAw MDAwMCArMDgwMAorKysgZ2RiL2luZnJ1bi5jCTIwMDktMDEtMjIgMTY6MjY6 NDYuMDAwMDAwMDAwICswODAwCkBAIC0zNDg4LDEwICszNDg4LDIxIEBACiAJ CSAga2VlcF9nb2luZyAoZWNzKTsKIAkJICByZXR1cm47CiAJCX0KLQkgICAg ICAvKiBOb3JtYWwgKHN0YXRpY2x5IGxpbmtlZCkgZnVuY3Rpb24gY2FsbCBy ZXR1cm4uICAqLwotCSAgICAgIGluaXRfc2FsICgmc3Jfc2FsKTsKLQkgICAg ICBzcl9zYWwucGMgPSBlY3MtPnN0b3BfZnVuY19zdGFydDsKLQkgICAgICBp bnNlcnRfc3RlcF9yZXN1bWVfYnJlYWtwb2ludF9hdF9zYWwgKHNyX3NhbCwg bnVsbF9mcmFtZV9pZCk7CisJICAgICAgaWYgKGVjcy0+c3RvcF9mdW5jX3N0 YXJ0ICE9IHN0b3BfcGMpCisJCXsKKwkJICAvKiBOb3JtYWwgKHN0YXRpY2x5 IGxpbmtlZCkgZnVuY3Rpb24gY2FsbCByZXR1cm4uICAqLworCQkgIGluaXRf c2FsICgmc3Jfc2FsKTsKKwkJICBzcl9zYWwucGMgPSBlY3MtPnN0b3BfZnVu Y19zdGFydDsKKwkJICBpbnNlcnRfc3RlcF9yZXN1bWVfYnJlYWtwb2ludF9h dF9zYWwgKHNyX3NhbCwgbnVsbF9mcmFtZV9pZCk7CisJCX0KKwkgICAgICBl bHNlCisJCXsKKwkJICAvKiBXZSBhcmUgc3RlcHBpbmcgb3ZlciBhIGZ1bmN0 aW9uIGNhbGwgaW4gcmV2ZXJzZSwgYW5kCisJICAgICAgICAgICAgIHN0b3Ag YXQgdGhlIHN0YXJ0IGFkZHJlc3Mgb2YgdGhlIGZ1bmN0aW9uLiAgR28gYmFj ayB0bworCSAgICAgICAgICAgICBzaW5nbGUtc3RlcHBpbmcsIHdoaWNoIHNo b3VsZCB0YWtlIHVzIGJhY2sgdG8gdGhlCisJICAgICAgICAgICAgIGZ1bmN0 aW9uIGNhbGwuICAqLworCQkgIGVjcy0+ZXZlbnRfdGhyZWFkLT5zdGVwcGlu Z19vdmVyX2JyZWFrcG9pbnQgPSAxOworCQl9CiAJICAgIH0KIAkgIGVsc2UK IAkgICAgaW5zZXJ0X3N0ZXBfcmVzdW1lX2JyZWFrcG9pbnRfYXRfY2FsbGVy IChnZXRfY3VycmVudF9mcmFtZSAoKSk7Cg== --0016e64e92f05151b404610e8164--