From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2971 invoked by alias); 11 Dec 2008 03:43:26 -0000 Received: (qmail 2958 invoked by uid 22791); 11 Dec 2008 03:43:22 -0000 X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.185) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 11 Dec 2008 03:42:47 +0000 Received: by ti-out-0910.google.com with SMTP id d10so498755tib.12 for ; Wed, 10 Dec 2008 19:42:44 -0800 (PST) Received: by 10.110.47.9 with SMTP id u9mr3022018tiu.51.1228966964572; Wed, 10 Dec 2008 19:42:44 -0800 (PST) Received: by 10.110.68.20 with HTTP; Wed, 10 Dec 2008 19:42:44 -0800 (PST) Message-ID: Date: Thu, 11 Dec 2008 03:43:00 -0000 From: teawater To: "Michael Snyder" , "Pedro Alves" Subject: Re: [RFA] Resubmit process record and replay, 6/10 Cc: "gdb-patches@sourceware.org" In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_74586_15389427.1228966964533" References: <4924C39B.7040101@vmware.com> <492AFD8F.5000800@vmware.com> <492C424A.7020203@vmware.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-12/txt/msg00194.txt.bz2 ------=_Part_74586_15389427.1228966964533 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 2751 Hi, I make a tmp patch to make this idea clear. It test with testsuite is OK. And I still didn't change "record_not_record_set" cause I didn't have idea on it. Thanks, Hui On Wed, Nov 26, 2008 at 10:33, teawater wrote: > Sorry I forget a big part that need it. > When GDB work in replay mode, P record will set regs and memory in > record_wait. All of them can't be record. > > So what about set not_record flag to record_wait in replay mode, > record_insert_breakpoint and record_remove_breakpoint. > > And about the name of this flag, do you have some idea on it? > > > Thanks, > Hui > > > On Wed, Nov 26, 2008 at 02:22, Michael Snyder wrote: >> teawater wrote: >>> >>> On Tue, Nov 25, 2008 at 03:16, Michael Snyder wrote: >>>> >>>> teawater wrote: >>>>> >>>>> Hi Michael, >>>>> >>>>> About "record_not_record_set", It set record_not_record to let P >>>>> record doesn't record the memory and registers control behaviors of >>>>> GDB in function record_store_registers and record_xfer_partial. >>>>> >>>>> So I think the name "record_not_record_set" and >>>>> "record_skip_recording" are not very clear. >>>>> Could you please give me some advices on it? >>>> >>>> Yeah, that's pretty much the way I understood it. >>>> >>>> It sets a one-time flag that says "omit (skip) recording >>>> registers and memory that would otherwise be recorded". >>>> >>>> And if I understand correctly, this is to avoid adding >>>> changes to the record log that are made by gdb when it >>>> resumes the target. It's only called from "proceed()". >>>> >>>> I'm not completely clear on what those changes are. >>>> Is gdb modifying the PC? Or are you perhaps trying to >>>> avoid recording breakpoints? >>> >>> I think avoid recording breakpoints is the main affect. >>> Another function is help deal with displaced step. Of course, P record >>> and displaced step will not work together now. >>> >>> I think I add "record_not_record" function is because I want >>> record_store_registers and record_xfer_partial just record the user >>> level change, not for others. >>> What do you think about it? >> >> OK, so if we ignore displaced stepping for now, then can we >> limit the issue to breakpoints? >> >> Breakpoint writes will all pass through functions called >> memory_insert_breakpoint and memory_remove_breakpoint (mem-break.c). >> >> So what we want to do is get the information from there into >> record.c. I guess you could do pretty much what you are doing >> now, only call the access function from mem-break.c instead of >> from infrun. It would help to localize it and make its meaning >> clear. >> >> Maybe call it "dont_record_memory_breakpoint" or something like that. >> >> > ------=_Part_74586_15389427.1228966964533 Content-Type: text/plain; name=tmp-skip.txt Content-Transfer-Encoding: base64 X-Attachment-Id: f_fokvewbt0 Content-Disposition: attachment; filename=tmp-skip.txt Content-length: 6747 SW5kZXg6IGdkYi9pbmZydW4uYwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBnZGIub3JpZy9pbmZydW4uYwkyMDA4LTEyLTExIDEwOjU3OjIyLjAwMDAw MDAwMCArMDgwMAorKysgZ2RiL2luZnJ1bi5jCTIwMDgtMTItMTEgMTE6MDM6 MTQuMDAwMDAwMDAwICswODAwCkBAIC02MDcsNyArNjA3LDcgQEAKIAkgICAg JiYgbm9uX3N0b3ApCiAJICAgfHwgY2FuX3VzZV9kaXNwbGFjZWRfc3RlcHBp bmcgPT0gY2FuX3VzZV9kaXNwbGFjZWRfc3RlcHBpbmdfb24pCiAJICAmJiBn ZGJhcmNoX2Rpc3BsYWNlZF9zdGVwX2NvcHlfaW5zbl9wIChnZGJhcmNoKQot CSAgJiYgIVJFQ09SRF9JU19VU0VEKTsKKwkgICYmICFUQVJHRVRfSVNfUFJP Q0VTU19SRUNPUkQpOwogfQogCiAvKiBDbGVhbiBvdXQgYW55IHN0cmF5IGRp c3BsYWNlZCBzdGVwcGluZyBzdGF0ZS4gICovCkBAIC0xMzEyLDEyICsxMzEy LDYgQEAKICAgaWYgKHN0ZXAgPCAwKQogICAgIHN0b3BfYWZ0ZXJfdHJhcCA9 IDE7CiAKLSAgIC8qIFdoZW4gR0RCIHJlc3VtZSB0aGUgaW5mZXJpb3IsIHBy b2Nlc3MgcmVjb3JkIHRhcmdldCBkb2Vzbid0IG5lZWQgdG8KLSAgICAgIHJl Y29yZCB0aGUgbWVtb3J5IGFuZCByZWdpc3RlciBzdG9yZSBvcGVyYXRpb24g b2YgR0RCLiBTbyBzZXQKLSAgICAgIHJlY29yZF9ub3RfcmVjb3JkIHRvIDEu ICovCi0gIGlmIChSRUNPUkRfSVNfVVNFRCkKLSAgICByZWNvcmRfbm90X3Jl Y29yZF9zZXQgKCk7Ci0KICAgaWYgKGFkZHIgPT0gKENPUkVfQUREUikgLTEp CiAgICAgewogICAgICAgaWYgKHBjID09IHN0b3BfcGMgJiYgYnJlYWtwb2lu dF9oZXJlX3AgKHBjKSAKQEAgLTIwNTAsNiArMjA0NCwxMCBAQAogICBpZiAo c29mdHdhcmVfYnJlYWtwb2ludF9pbnNlcnRlZF9oZXJlX3AgKGJyZWFrcG9p bnRfcGMpCiAgICAgICB8fCAobm9uX3N0b3AgJiYgbW9yaWJ1bmRfYnJlYWtw b2ludF9oZXJlX3AgKGJyZWFrcG9pbnRfcGMpKSkKICAgICB7CisgICAgICBz dHJ1Y3QgY2xlYW51cCAqb2xkX2NsZWFudXBzOworICAgICAgaWYgKFRBUkdF VF9JU19QUk9DRVNTX1JFQ09SRCkKKwlvbGRfY2xlYW51cHMgPSByZWNvcmRf bm90X3JlY29yZF9zZXQgKCk7CisKICAgICAgIC8qIFdoZW4gdXNpbmcgaGFy ZHdhcmUgc2luZ2xlLXN0ZXAsIGEgU0lHVFJBUCBpcyByZXBvcnRlZCBmb3Ig Ym90aAogCSBhIGNvbXBsZXRlZCBzaW5nbGUtc3RlcCBhbmQgYSBzb2Z0d2Fy ZSBicmVha3BvaW50LiAgTmVlZCB0bwogCSBkaWZmZXJlbnRpYXRlIGJldHdl ZW4gdGhlIHR3bywgYXMgdGhlIGxhdHRlciBuZWVkcyBhZGp1c3RpbmcKQEAg LTIwNzMsNiArMjA3MSw5IEBACiAJICB8fCAhY3VycmVudGx5X3N0ZXBwaW5n IChlY3MtPmV2ZW50X3RocmVhZCkKIAkgIHx8IGVjcy0+ZXZlbnRfdGhyZWFk LT5wcmV2X3BjID09IGJyZWFrcG9pbnRfcGMpCiAJcmVnY2FjaGVfd3JpdGVf cGMgKHJlZ2NhY2hlLCBicmVha3BvaW50X3BjKTsKKworICAgICAgaWYgKFRB UkdFVF9JU19QUk9DRVNTX1JFQ09SRCkKKwlkb19jbGVhbnVwcyAob2xkX2Ns ZWFudXBzKTsKICAgICB9CiB9CiAKSW5kZXg6IGdkYi9yZWNvcmQuYwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBnZGIub3JpZy9yZWNvcmQuYwkyMDA4 LTEyLTExIDEwOjU3OjIyLjAwMDAwMDAwMCArMDgwMAorKysgZ2RiL3JlY29y ZC5jCTIwMDgtMTItMTEgMTE6MDM6NTYuMDAwMDAwMDAwICswODAwCkBAIC0x NzMsNiArMTczLDEzIEBACiBzdGF0aWMgdm9pZAogcmVjb3JkX2FyY2hfbGlz dF9hZGQgKHJlY29yZF90ICogcmVjKQogeworICBpZiAocmVjb3JkX2RlYnVn ID4gMSkKKyAgICB7CisgICAgICBmcHJpbnRmX3VuZmlsdGVyZWQgKGdkYl9z dGRsb2csCisJCQkgICJQcm9jZXNzIHJlY29yZDogcmVjb3JkX2FyY2hfbGlz dF9hZGQgMHglcy5cbiIsCisJCQkgIHBhZGRyX256ICgoQ09SRV9BRERSKXJl YykpOworICAgIH0KKwogICBpZiAocmVjb3JkX2FyY2hfbGlzdF90YWlsKQog ICAgIHsKICAgICAgIHJlY29yZF9hcmNoX2xpc3RfdGFpbC0+bmV4dCA9IHJl YzsKQEAgLTM3MiwxMSArMzc5LDEzIEBACiAgIHJlY29yZF9ub3RfcmVjb3Jk ID0gMDsKIH0KIAotdm9pZAorc3RydWN0IGNsZWFudXAgKgogcmVjb3JkX25v dF9yZWNvcmRfc2V0ICh2b2lkKQogewogICBzdHJ1Y3QgY2xlYW51cCAqb2xk X2NsZWFudXBzID0gbWFrZV9jbGVhbnVwIChyZWNvcmRfbm90X3JlY29yZF9j bGVhbnVwcywgMCk7CiAgIHJlY29yZF9ub3RfcmVjb3JkID0gMTsKKworICBy ZXR1cm4gb2xkX2NsZWFudXBzOwogfQogCiBzdGF0aWMgdm9pZApAQCAtNDA3 LDcgKzQxNiw3IEBACiAgICAgfQogCiAgIC8qIENoZWNrIGlmIHJlY29yZCB0 YXJnZXQgaXMgYWxyZWFkeSBydW5uaW5nICovCi0gIGlmIChSRUNPUkRfSVNf VVNFRCkKKyAgaWYgKFRBUkdFVF9JU19QUk9DRVNTX1JFQ09SRCkKICAgICB7 CiAgICAgICBpZiAoIW5xdWVyeQogCSAgKF8oIlByb2Nlc3MgcmVjb3JkIHRh cmdldCBhbHJlYWR5IHJ1bm5pbmcsIGRvIHlvdSB3YW50IHRvIGRlbGV0ZSB0 aGUgb2xkIHJlY29yZCBsb2c/IikpKQpAQCAtNDgzLDYgKzQ5Miw4IEBACiBz dGF0aWMgcHRpZF90CiByZWNvcmRfd2FpdCAocHRpZF90IHB0aWQsIHN0cnVj dCB0YXJnZXRfd2FpdHN0YXR1cyAqc3RhdHVzKQogeworICBzdHJ1Y3QgY2xl YW51cCAqc2V0X2NsZWFudXBzID0gcmVjb3JkX25vdF9yZWNvcmRfc2V0ICgp OworCiAgIGlmIChyZWNvcmRfZGVidWcpCiAgICAgewogICAgICAgZnByaW50 Zl91bmZpbHRlcmVkIChnZGJfc3RkbG9nLApAQCAtODM1LDYgKzg0Niw3IEBA CiAgICAgICBkaXNjYXJkX2NsZWFudXBzIChvbGRfY2xlYW51cHMpOwogICAg IH0KIAorICBkb19jbGVhbnVwcyAoc2V0X2NsZWFudXBzKTsKICAgcmV0dXJu IGluZmVyaW9yX3B0aWQ7CiB9CiAKQEAgLTEwNzMsNyArMTA4NSwxMiBAQAog ewogICBpZiAoIVJFQ09SRF9JU19SRVBMQVkpCiAgICAgewotICAgICAgcmV0 dXJuIHJlY29yZF9iZW5lYXRoX3RvX2luc2VydF9icmVha3BvaW50IChicF90 Z3QpOworICAgICAgc3RydWN0IGNsZWFudXAgKm9sZF9jbGVhbnVwcyA9IHJl Y29yZF9ub3RfcmVjb3JkX3NldCAoKTsKKyAgICAgIGludCByZXQgPSByZWNv cmRfYmVuZWF0aF90b19pbnNlcnRfYnJlYWtwb2ludCAoYnBfdGd0KTsKKwor ICAgICAgZG9fY2xlYW51cHMgKG9sZF9jbGVhbnVwcyk7CisKKyAgICAgIHJl dHVybiByZXQ7CiAgICAgfQogCiAgIHJldHVybiAwOwpAQCAtMTA4NCw3ICsx MTAxLDEyIEBACiB7CiAgIGlmICghUkVDT1JEX0lTX1JFUExBWSkKICAgICB7 Ci0gICAgICByZXR1cm4gcmVjb3JkX2JlbmVhdGhfdG9fcmVtb3ZlX2JyZWFr cG9pbnQgKGJwX3RndCk7CisgICAgICBzdHJ1Y3QgY2xlYW51cCAqb2xkX2Ns ZWFudXBzID0gcmVjb3JkX25vdF9yZWNvcmRfc2V0ICgpOworICAgICAgaW50 IHJldCA9IHJlY29yZF9iZW5lYXRoX3RvX3JlbW92ZV9icmVha3BvaW50IChi cF90Z3QpOworCisgICAgICBkb19jbGVhbnVwcyAob2xkX2NsZWFudXBzKTsK KworICAgICAgcmV0dXJuIHJldDsKICAgICB9CiAKICAgcmV0dXJuIDA7CkBA IC0xMTQyLDcgKzExNjQsNyBAQAogc3RhdGljIHZvaWQKIGNtZF9yZWNvcmRf ZGVsZXRlIChjaGFyICphcmdzLCBpbnQgZnJvbV90dHkpCiB7Ci0gIGlmIChS RUNPUkRfSVNfVVNFRCkKKyAgaWYgKFRBUkdFVF9JU19QUk9DRVNTX1JFQ09S RCkKICAgICB7CiAgICAgICBpZiAoUkVDT1JEX0lTX1JFUExBWSkKIAl7CkBA IC0xMTY4LDcgKzExOTAsNyBAQAogc3RhdGljIHZvaWQKIGNtZF9yZWNvcmRf c3RvcCAoY2hhciAqYXJncywgaW50IGZyb21fdHR5KQogewotICBpZiAoUkVD T1JEX0lTX1VTRUQpCisgIGlmIChUQVJHRVRfSVNfUFJPQ0VTU19SRUNPUkQp CiAgICAgewogICAgICAgaWYgKCFyZWNvcmRfbGlzdCB8fCAhZnJvbV90dHkg fHwgcXVlcnkgKF8oIkRlbGV0ZSByZWNvcmRlZCBsb2cgYW5kIHN0b3AgcmVj b3JkaW5nPyIpKSkKIAl7CkluZGV4OiBnZGIvcmVjb3JkLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gZ2RiLm9yaWcvcmVjb3JkLmgJMjAwOC0xMi0x MSAxMDo1NzoyMi4wMDAwMDAwMDAgKzA4MDAKKysrIGdkYi9yZWNvcmQuaAky MDA4LTEyLTExIDExOjAzOjMzLjAwMDAwMDAwMCArMDgwMApAQCAtMjAsNyAr MjAsNyBAQAogI2lmbmRlZiBfUkVDT1JEX0hfCiAjZGVmaW5lIF9SRUNPUkRf SF8KIAotI2RlZmluZSBSRUNPUkRfSVNfVVNFRCAgIFwKKyNkZWZpbmUgVEFS R0VUX0lTX1BST0NFU1NfUkVDT1JEICAgXAogICAgICAoY3VycmVudF90YXJn ZXQuYmVuZWF0aCA9PSAmcmVjb3JkX29wcykKICNkZWZpbmUgUkVDT1JEX0lT X1JFUExBWSBcCiAgICAgIChyZWNvcmRfbGlzdC0+bmV4dCB8fCBleGVjdXRp b25fZGlyZWN0aW9uID09IEVYRUNfUkVWRVJTRSkKQEAgLTgwLDcgKzgwLDcg QEAKIGV4dGVybiBpbnQgcmVjb3JkX2FyY2hfbGlzdF9hZGRfbWVtIChDT1JF X0FERFIgYWRkciwgaW50IGxlbik7CiBleHRlcm4gaW50IHJlY29yZF9hcmNo X2xpc3RfYWRkX2VuZCAoaW50IG5lZWRfZGFzbSk7CiBleHRlcm4gdm9pZCBy ZWNvcmRfbWVzc2FnZSAoc3RydWN0IGdkYmFyY2ggKmdkYmFyY2gpOwotZXh0 ZXJuIHZvaWQgcmVjb3JkX25vdF9yZWNvcmRfc2V0ICh2b2lkKTsKK2V4dGVy biBzdHJ1Y3QgY2xlYW51cCAqIHJlY29yZF9ub3RfcmVjb3JkX3NldCAodm9p ZCk7CiAKIGV4dGVybiB2b2lkICgqcmVjb3JkX2JlbmVhdGhfdG9fcmVzdW1l KSAocHRpZF90LCBpbnQsIGVudW0gdGFyZ2V0X3NpZ25hbCk7CiBleHRlcm4g cHRpZF90ICgqcmVjb3JkX2JlbmVhdGhfdG9fd2FpdCkgKHB0aWRfdCwgc3Ry dWN0IHRhcmdldF93YWl0c3RhdHVzICopOwo= ------=_Part_74586_15389427.1228966964533--