From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10703 invoked by alias); 26 Oct 2008 14:15:20 -0000 Received: (qmail 10692 invoked by uid 22791); 26 Oct 2008 14:15:19 -0000 X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.190) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 26 Oct 2008 14:14:29 +0000 Received: by ti-out-0910.google.com with SMTP id d10so965150tib.12 for ; Sun, 26 Oct 2008 07:14:26 -0700 (PDT) Received: by 10.110.46.3 with SMTP id t3mr2725047tit.30.1225030466576; Sun, 26 Oct 2008 07:14:26 -0700 (PDT) Received: by 10.110.42.9 with HTTP; Sun, 26 Oct 2008 07:14:26 -0700 (PDT) Message-ID: Date: Sun, 26 Oct 2008 14:15:00 -0000 From: teawater To: "Joel Brobecker" Subject: Re: [RFA] Handle runtime loader dyn sym resolution in reverse Cc: "Michael Snyder" , "gdb-patches@sourceware.org" In-Reply-To: <20081025160945.GI29998@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <49028B5C.2000508@vmware.com> <20081025160945.GI29998@adacore.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00647.txt.bz2 Hi Joel, This patch fix the bug that I send in http://sourceware.org/ml/gdb-patches/2008-10/msg00485.html Thanks, Hui On Sun, Oct 26, 2008 at 00:09, Joel Brobecker wrote: >> This is for both the main trunk and the record/replay branch >> (so I'd appreciate review by both Hui and a global maintainer). > > I took a look. The patch itself is missing a little bit of context > (in terms of the code), so I wasn't sure whether I was looking at > inserting this hunk at the right place, but I think I found it: > > if (ecs->event_thread->step_over_calls == STEP_OVER_ALL) > { > /* We're doing a "next". > > Normal (forward) execution: set a breakpoint at the > callee's return address (the address at which the caller > will resume). > > Reverse (backward) execution. set the step-resume > breakpoint at the start of the function that we just > stepped into (backwards), and continue to there. When we > get there, we'll need to single-step back to the caller. */ > > if (execution_direction == EXEC_REVERSE) > >> 2008-10-24 Michael Snyder >> >> * infrun.c (handle_inferior_event): Handle dynamic symbol >> resolution in reverse. > > Looks OK to me, but I don't understand why you check that stop_func_start > is zero. If I were to make a guess, it would be to quickly dismiss > the case were we reverse stepped into a function call, and so don't > need to check for trampolines (in other words, a CPU saver). > > -- > Joel >