From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12686 invoked by alias); 22 Oct 2008 03:16:42 -0000 Received: (qmail 12674 invoked by uid 22791); 22 Oct 2008 03:16:41 -0000 X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.188) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 22 Oct 2008 03:16:06 +0000 Received: by ti-out-0910.google.com with SMTP id d10so1358268tib.12 for ; Tue, 21 Oct 2008 20:16:02 -0700 (PDT) Received: by 10.110.16.9 with SMTP id 9mr6529326tip.53.1224645362924; Tue, 21 Oct 2008 20:16:02 -0700 (PDT) Received: by 10.110.42.9 with HTTP; Tue, 21 Oct 2008 20:16:02 -0700 (PDT) Message-ID: Date: Wed, 22 Oct 2008 03:16:00 -0000 From: teawater To: "Pedro Alves" , "Daniel Jacobowitz" , "Eli Zaretskii" , gdb-patches@sourceware.org, "Joel Brobecker" , "Michael Snyder" Subject: Re: [RFA] Displaced stepping just enable in non-stop mode In-Reply-To: <200810160359.09956.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_22751_22824524.1224645362875" References: <200810160107.42525.pedro@codesourcery.com> <20081016023837.GA32668@caradoc.them.org> <200810160359.09956.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00534.txt.bz2 ------=_Part_22751_22824524.1224645362875 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 2330 Hi all, I make a new patch that change "can-use-displaced-stepping" to "displaced-stepping" and change some part according to Eli's idea in doc. 2008-10-22 Hui Zhu Pedro Alves * infrun.c (can_use_displaced_stepping): Change type to const char pointer. (can_use_displaced_stepping_auto): New string. (can_use_displaced_stepping_on): New string. (can_use_displaced_stepping_off): New string. (can_use_displaced_stepping_enum): New array. (show_can_use_displaced_stepping): In auto mode, also show the current effect of the option. (use_displaced_stepping): Return non-zero if displaced stepping is auto, and can be used with GDBARCH, and in non-stop mode. Return non-zero if displaced stepping is on, and can be used with GDBARCH. Return zero otherwise. (_initialize_infrun): Make the "set displaced-stepping" command an enum command. Change its class to class_run. Place it in the top level set list. Extend help to describe the auto mode. 2008-10-22 Hui Zhu Pedro Alves * gdb.texinfo (displaced-stepping): Describe the auto mode setting, and say it's the default. This is now a mainstream setting instead of a maintenance setting. Thanks, Hui On Thu, Oct 16, 2008 at 10:59, Pedro Alves wrote: > On Thursday 16 October 2008 03:38:37, Daniel Jacobowitz wrote: >> On Thu, Oct 16, 2008 at 01:07:42AM +0100, Pedro Alves wrote: > >> > I think Joel's suggestion was a good one: By gaining an "auto" >> > setting, this is as much a maintainer command as >> > "set breakpoint always-inserted" is. So, I believe it's time we move >> > the command to the top level "set" command group. >> > >> > set can-use-displaced-stepping (auto|on|off) >> > >> > Eli, can I ask you to go over the help strings and the documentation in >> > the patch below? Do they look OK-ish? >> >> That's a pretty long name. Do you think there are any other useful >> stepping related settings? If so, maybe we should have a "set step" >> prefix. >> > > Hmm, not offhand. I'd have to think about it. > What would you call the setting then, if not "set step can-use-displaced-stepping" ? > > The name was actually modeled on "set can-use-hw-watchpoints" in the first place. > > -- > Pedro Alves > ------=_Part_22751_22824524.1224645362875 Content-Type: text/plain; name=displaced_step_non_step.txt Content-Transfer-Encoding: base64 X-Attachment-Id: f_fmlebq0x0 Content-Disposition: attachment; filename=displaced_step_non_step.txt Content-length: 7841 LS0tIGEvaW5mcnVuLmMKKysrIGIvaW5mcnVuLmMKQEAgLTU1MywyNiArNTUz LDU1IEBAIHN0YXRpYyBDT1JFX0FERFIgZGlzcGxhY2VkX3N0ZXBfb3JpZ2lu YWwKIC8qIFNhdmVkIGNvbnRlbnRzIG9mIGNvcHkgYXJlYS4gICovCiBzdGF0 aWMgZ2RiX2J5dGUgKmRpc3BsYWNlZF9zdGVwX3NhdmVkX2NvcHk7CiAKLS8q IFdoZW4gdGhpcyBpcyBub24temVybywgd2UgYXJlIGFsbG93ZWQgdG8gdXNl IGRpc3BsYWNlZCBzdGVwcGluZywgaWYKLSAgIHRoZSBhcmNoaXRlY3R1cmUg c3VwcG9ydHMgaXQuICBXaGVuIHRoaXMgaXMgemVybywgd2UgdXNlCi0gICB0 cmFkaXRpb25hbCB0aGUgaG9sZC1hbmQtc3RlcCBhcHByb2FjaC4gICovCi1p bnQgY2FuX3VzZV9kaXNwbGFjZWRfc3RlcHBpbmcgPSAxOworLyogRW51bSBz dHJpbmdzIGZvciAic2V0fHNob3cgZGlzcGxhY2VkLXN0ZXBwaW5nIi4gICov CisKK3N0YXRpYyBjb25zdCBjaGFyIGNhbl91c2VfZGlzcGxhY2VkX3N0ZXBw aW5nX2F1dG9bXSA9ICJhdXRvIjsKK3N0YXRpYyBjb25zdCBjaGFyIGNhbl91 c2VfZGlzcGxhY2VkX3N0ZXBwaW5nX29uW10gPSAib24iOworc3RhdGljIGNv bnN0IGNoYXIgY2FuX3VzZV9kaXNwbGFjZWRfc3RlcHBpbmdfb2ZmW10gPSAi b2ZmIjsKK3N0YXRpYyBjb25zdCBjaGFyICpjYW5fdXNlX2Rpc3BsYWNlZF9z dGVwcGluZ19lbnVtW10gPQoreworICBjYW5fdXNlX2Rpc3BsYWNlZF9zdGVw cGluZ19hdXRvLAorICBjYW5fdXNlX2Rpc3BsYWNlZF9zdGVwcGluZ19vbiwK KyAgY2FuX3VzZV9kaXNwbGFjZWRfc3RlcHBpbmdfb2ZmLAorICBOVUxMLAor fTsKKworLyogSWYgT04sIGFuZCB0aGUgYXJjaGl0ZWN0dXJlIHN1cHBvcnRz IGl0LCBHREIgd2lsbCB1c2UgZGlzcGxhY2VkCisgICBzdGVwcGluZyB0byBz dGVwIG92ZXIgYnJlYWtwb2ludHMuICBJZiBPRkYsIG9yIGlmIHRoZSBhcmNo aXRlY3R1cmUKKyAgIGRvZXNuJ3Qgc3VwcG9ydCBpdCwgR0RCIHdpbGwgaW5z dGVhZCB1c2UgdGhlIHRyYWRpdGlvbmFsCisgICBob2xkLWFuZC1zdGVwIGFw cHJvYWNoLiAgSWYgQVVUTyAod2hpY2ggaXMgdGhlIGRlZmF1bHQpLCBHREIg d2lsbAorICAgZGVjaWRlIHdoaWNoIHRlY2huaXF1ZSB0byB1c2UgdG8gc3Rl cCBvdmVyIGJyZWFrcG9pbnRzIGRlcGVuZGluZyBvbgorICAgd2hpY2ggb2Yg YWxsLXN0b3Agb3Igbm9uLXN0b3AgbW9kZSBpcyBhY3RpdmUgLS0tIGRpc3Bs YWNlZCBzdGVwcGluZworICAgaW4gbm9uLXN0b3AgbW9kZTsgaG9sZC1hbmQt c3RlcCBpbiBhbGwtc3RvcCBtb2RlLiAgKi8KKworc3RhdGljIGNvbnN0IGNo YXIgKmNhbl91c2VfZGlzcGxhY2VkX3N0ZXBwaW5nID0KKyAgY2FuX3VzZV9k aXNwbGFjZWRfc3RlcHBpbmdfYXV0bzsKKwogc3RhdGljIHZvaWQKIHNob3df Y2FuX3VzZV9kaXNwbGFjZWRfc3RlcHBpbmcgKHN0cnVjdCB1aV9maWxlICpm aWxlLCBpbnQgZnJvbV90dHksCiAJCQkJIHN0cnVjdCBjbWRfbGlzdF9lbGVt ZW50ICpjLAogCQkJCSBjb25zdCBjaGFyICp2YWx1ZSkKIHsKLSAgZnByaW50 Zl9maWx0ZXJlZCAoZmlsZSwgXygiXAotRGVidWdnZXIncyB3aWxsaW5nbmVz cyB0byB1c2UgZGlzcGxhY2VkIHN0ZXBwaW5nIHRvIHN0ZXAgb3ZlciAiCi0i YnJlYWtwb2ludHMgaXMgJXMuXG4iKSwgdmFsdWUpOworICBpZiAoY2FuX3Vz ZV9kaXNwbGFjZWRfc3RlcHBpbmcgPT0gY2FuX3VzZV9kaXNwbGFjZWRfc3Rl cHBpbmdfYXV0bykKKyAgICBmcHJpbnRmX2ZpbHRlcmVkIChmaWxlLCBfKCJc CitEZWJ1Z2dlcidzIHdpbGxpbmduZXNzIHRvIHVzZSBkaXNwbGFjZWQgc3Rl cHBpbmcgdG8gc3RlcCBvdmVyIFwKK2JyZWFrcG9pbnRzIGlzICVzIChjdXJy ZW50bHkgJXMpLlxuIiksCisJCSAgICAgIHZhbHVlLCBub25fc3RvcCA/ICJv biIgOiAib2ZmIik7CisgIGVsc2UKKyAgICBmcHJpbnRmX2ZpbHRlcmVkIChm aWxlLCBfKCJcCitEZWJ1Z2dlcidzIHdpbGxpbmduZXNzIHRvIHVzZSBkaXNw bGFjZWQgc3RlcHBpbmcgdG8gc3RlcCBvdmVyIFwKK2JyZWFrcG9pbnRzIGlz ICVzLlxuIiksIHZhbHVlKTsKIH0KIAotLyogUmV0dXJuIG5vbi16ZXJvIGlm IGRpc3BsYWNlZCBzdGVwcGluZyBpcyBlbmFibGVkLCBhbmQgY2FuIGJlIHVz ZWQKLSAgIHdpdGggR0RCQVJDSC4gICovCisvKiBSZXR1cm4gbm9uLXplcm8g aWYgZGlzcGxhY2VkIHN0ZXBwaW5nIGNhbi9zaG91bGQgYmUgdXNlZCB0byBz dGVwCisgICBvdmVyIGJyZWFrcG9pbnRzLiAgKi8KKwogc3RhdGljIGludAog dXNlX2Rpc3BsYWNlZF9zdGVwcGluZyAoc3RydWN0IGdkYmFyY2ggKmdkYmFy Y2gpCiB7Ci0gIHJldHVybiAoY2FuX3VzZV9kaXNwbGFjZWRfc3RlcHBpbmcK KyAgcmV0dXJuICgoKGNhbl91c2VfZGlzcGxhY2VkX3N0ZXBwaW5nID09IGNh bl91c2VfZGlzcGxhY2VkX3N0ZXBwaW5nX2F1dG8KKwkgICAgJiYgbm9uX3N0 b3ApCisJICAgfHwgY2FuX3VzZV9kaXNwbGFjZWRfc3RlcHBpbmcgPT0gY2Fu X3VzZV9kaXNwbGFjZWRfc3RlcHBpbmdfb24pCiAJICAmJiBnZGJhcmNoX2Rp c3BsYWNlZF9zdGVwX2NvcHlfaW5zbl9wIChnZGJhcmNoKSk7CiB9CiAKQEAg LTUxMDcsMTYgKzUxMzYsMjAgQEAgZnVuY3Rpb24gaXMgc2tpcHBlZCBhbmQg dGhlIHN0ZXAgY29tbWFuZAogCQkJICAgc2hvd19zdGVwX3N0b3BfaWZfbm9f ZGVidWcsCiAJCQkgICAmc2V0bGlzdCwgJnNob3dsaXN0KTsKIAotICBhZGRf c2V0c2hvd19ib29sZWFuX2NtZCAoImNhbi11c2UtZGlzcGxhY2VkLXN0ZXBw aW5nIiwgY2xhc3NfbWFpbnRlbmFuY2UsCi0JCQkgICAmY2FuX3VzZV9kaXNw bGFjZWRfc3RlcHBpbmcsIF8oIlwKKyAgYWRkX3NldHNob3dfZW51bV9jbWQg KCJkaXNwbGFjZWQtc3RlcHBpbmciLCBjbGFzc19ydW4sCisJCQljYW5fdXNl X2Rpc3BsYWNlZF9zdGVwcGluZ19lbnVtLAorCQkJJmNhbl91c2VfZGlzcGxh Y2VkX3N0ZXBwaW5nLCBfKCJcCiBTZXQgZGVidWdnZXIncyB3aWxsaW5nbmVz cyB0byB1c2UgZGlzcGxhY2VkIHN0ZXBwaW5nLiIpLCBfKCJcCiBTaG93IGRl YnVnZ2VyJ3Mgd2lsbGluZ25lc3MgdG8gdXNlIGRpc3BsYWNlZCBzdGVwcGlu Zy4iKSwgXygiXAotSWYgemVybywgZ2RiIHdpbGwgbm90IHVzZSBkaXNwbGFj ZWQgc3RlcHBpbmcgdG8gc3RlcCBvdmVyXG5cCi1icmVha3BvaW50cywgZXZl biBpZiBzdWNoIGlzIHN1cHBvcnRlZCBieSB0aGUgdGFyZ2V0LiIpLAotCQkJ ICAgTlVMTCwKLQkJCSAgIHNob3dfY2FuX3VzZV9kaXNwbGFjZWRfc3RlcHBp bmcsCi0JCQkgICAmbWFpbnRlbmFuY2Vfc2V0X2NtZGxpc3QsCi0JCQkgICAm bWFpbnRlbmFuY2Vfc2hvd19jbWRsaXN0KTsKK0lmIG9uLCBnZGIgd2lsbCB1 c2UgZGlzcGxhY2VkIHN0ZXBwaW5nIHRvIHN0ZXAgb3ZlciBicmVha3BvaW50 cyBpZiBpdCBpc1xuXAorc3VwcG9ydGVkIGJ5IHRoZSB0YXJnZXQgYXJjaGl0 ZWN0dXJlLiAgSWYgb2ZmLCBnZGIgd2lsbCBub3QgdXNlIGRpc3BsYWNlZFxu XAorc3RlcHBpbmcgdG8gc3RlcCBvdmVyIGJyZWFrcG9pbnRzLCBldmVuIGlm IHN1Y2ggaXMgc3VwcG9ydGVkIGJ5IHRoZSB0YXJnZXRcblwKK2FyY2hpdGVj dHVyZS4gIElmIGF1dG8gKHdoaWNoIGlzIHRoZSBkZWZhdWx0KSwgZ2RiIHdp bGwgdXNlIGRpc3BsYWNlZCBzdGVwcGluZ1xuXAoraWYgdGhlIHRhcmdldCBh cmNoaXRlY3R1cmUgc3VwcG9ydHMgaXQgYW5kIG5vbi1zdG9wIG1vZGUgaXMg YWN0aXZlLCBidXQgd2lsbCBub3RcblwKK3VzZSBpdCBpbiBhbGwtc3RvcCBt b2RlIChzZWUgaGVscCBzZXQgbm9uLXN0b3ApLiIpLAorCQkJTlVMTCwKKwkJ CXNob3dfY2FuX3VzZV9kaXNwbGFjZWRfc3RlcHBpbmcsCisJCQkmc2V0bGlz dCwgJnNob3dsaXN0KTsKIAogICBhZGRfc2V0c2hvd19lbnVtX2NtZCAoImV4 ZWMtZGlyZWN0aW9uIiwgY2xhc3NfcnVuLCBleGVjX2RpcmVjdGlvbl9uYW1l cywKIAkJCSZleGVjX2RpcmVjdGlvbiwgXygiU2V0IGRpcmVjdGlvbiBvZiBl eGVjdXRpb24uXG5cCi0tLSBhL2dkYi50ZXhpbmZvCisrKyBiL2dkYi50ZXhp bmZvCkBAIC0yNDExMywxOCArMjQxMTMsMzMgQEAgU2hhcmVkIGxpYnJhcnkg ZXZlbnRzLgogCiBAZW5kIHRhYmxlCiAKLUBraW5kZXggbWFpbnQgc2V0IGNh bi11c2UtZGlzcGxhY2VkLXN0ZXBwaW5nCi1Aa2luZGV4IG1haW50IHNob3cg Y2FuLXVzZS1kaXNwbGFjZWQtc3RlcHBpbmcKK0BraW5kZXggc2V0IGRpc3Bs YWNlZC1zdGVwcGluZworQGtpbmRleCBzaG93IGRpc3BsYWNlZC1zdGVwcGlu ZwogQGNpbmRleCBkaXNwbGFjZWQgc3RlcHBpbmcgc3VwcG9ydAogQGNpbmRl eCBvdXQtb2YtbGluZSBzaW5nbGUtc3RlcHBpbmcKLUBpdGVtIG1haW50IHNl dCBjYW4tdXNlLWRpc3BsYWNlZC1zdGVwcGluZwotQGl0ZW14IG1haW50IHNo b3cgY2FuLXVzZS1kaXNwbGFjZWQtc3RlcHBpbmcKK0BpdGVtIHNldCBkaXNw bGFjZWQtc3RlcHBpbmcKK0BpdGVteCBzaG93IGRpc3BsYWNlZC1zdGVwcGlu ZwogQ29udHJvbCB3aGV0aGVyIG9yIG5vdCBAdmFsdWV7R0RCTn0gd2lsbCBk byBAZGZue2Rpc3BsYWNlZCBzdGVwcGluZ30KLWlmIHRoZSB0YXJnZXQgc3Vw cG9ydHMgaXQuICBUaGUgZGVmYXVsdCBpcyBvbi4gIERpc3BsYWNlZCBzdGVw cGluZyBpcwotYSB3YXkgdG8gc2luZ2xlLXN0ZXAgb3ZlciBicmVha3BvaW50 cyB3aXRob3V0IHJlbW92aW5nIHRoZW0gZnJvbSB0aGUKLWluZmVyaW9yLCBi eSBleGVjdXRpbmcgYW4gb3V0LW9mLWxpbmUgY29weSBvZiB0aGUgaW5zdHJ1 Y3Rpb24gdGhhdCB3YXMKLW9yaWdpbmFsbHkgYXQgdGhlIGJyZWFrcG9pbnQg bG9jYXRpb24uICBJdCBpcyBhbHNvIGtub3duIGFzCi1vdXQtb2YtbGluZSBz aW5nbGUtc3RlcHBpbmcuCitpZiB0aGUgdGFyZ2V0IHN1cHBvcnRzIGl0LiAg RGlzcGxhY2VkIHN0ZXBwaW5nIGlzIGEgd2F5IHRvIHNpbmdsZS1zdGVwCitv dmVyIGJyZWFrcG9pbnRzIHdpdGhvdXQgcmVtb3ZpbmcgdGhlbSBmcm9tIHRo ZSBpbmZlcmlvciwgYnkgZXhlY3V0aW5nCithbiBvdXQtb2YtbGluZSBjb3B5 IG9mIHRoZSBpbnN0cnVjdGlvbiB0aGF0IHdhcyBvcmlnaW5hbGx5IGF0IHRo ZQorYnJlYWtwb2ludCBsb2NhdGlvbi4gIEl0IGlzIGFsc28ga25vd24gYXMg b3V0LW9mLWxpbmUgc2luZ2xlLXN0ZXBwaW5nLgorCitAdGFibGUgQGNvZGUK K0BpdGVtIHNldCBkaXNwbGFjZWQtc3RlcHBpbmcgb24KK0lmIHRoZSB0YXJn ZXQgYXJjaGl0ZWN0dXJlIHN1cHBvcnRzIGl0LCBAdmFsdWV7R0RCTn0gd2ls bCB1c2UKK2Rpc3BsYWNlZCBzdGVwcGluZyB0byBzdGVwIG92ZXIgYnJlYWtw b2ludHMuCisKK0BpdGVtIHNldCBkaXNwbGFjZWQtc3RlcHBpbmcgb2ZmCitA dmFsdWV7R0RCTn0gd2lsbCBub3QgdXNlIGRpc3BsYWNlZCBzdGVwcGluZyB0 byBzdGVwIG92ZXIgYnJlYWtwb2ludHMsCitldmVuIGlmIHN1Y2ggaXMgc3Vw cG9ydGVkIGJ5IHRoZSB0YXJnZXQgYXJjaGl0ZWN0dXJlLgorCitAY2luZGV4 IG5vbi1zdG9wIG1vZGUsIGFuZCBAc2FtcHtzZXQgZGlzcGxhY2VkLXN0ZXBw aW5nfQorQGl0ZW0gc2V0IGRpc3BsYWNlZC1zdGVwcGluZyBhdXRvCitUaGlz IGlzIHRoZSBkZWZhdWx0IG1vZGUuICBAdmFsdWV7R0RCTn0gd2lsbCB1c2Ug ZGlzcGxhY2VkIHN0ZXBwaW5nCitvbmx5IGlmIG5vbi1zdG9wIG1vZGUgaXMg YWN0aXZlIChAcHhyZWZ7Tm9uLVN0b3AgTW9kZX0pIGFuZCB0aGUgdGFyZ2V0 CithcmNoaXRlY3R1cmUgc3VwcG9ydHMgZGlzcGxhY2VkIHN0ZXBwaW5nLgor QGVuZCB0YWJsZQogCiBAa2luZGV4IG1haW50IGNoZWNrLXN5bXRhYnMKIEBp dGVtIG1haW50IGNoZWNrLXN5bXRhYnMK ------=_Part_22751_22824524.1224645362875--