From: teawater <teawater@gmail.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"Michael Snyder" <msnyder@vmware.com>
Subject: [RFA] Set stop_pc when TARGET_WAITKIND_NO_HISTORY
Date: Sun, 19 Oct 2008 14:21:00 -0000 [thread overview]
Message-ID: <daef60380810190721g1ef445cq5c0c2ce5fd24ab41@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1202 bytes --]
Hi Michael,
I try the 20080930 branch and got:
(gdb) start
Temporary breakpoint 1 at 0x80483c1: file 1.c, line 20.
Starting program: /home/teawater/rec/a.out
Temporary breakpoint 1, main () at 1.c:20
20 int b = 0;
(gdb) record
(gdb) n
21 int c = 1;
(gdb)
24 printf ("a = %d b = %d c = %d\n", a, b, c);
(gdb)
a = 0 b = 0 c = 1
25 b = cool ();
(gdb) rn
No more reverse-execution history.
main () at 1.c:20
20 int b = 0;
(gdb) n
Cannot find bounds of current function
This is because:
case TARGET_WAITKIND_NO_HISTORY:
/* Reverse execution: target ran out of history info. */
print_stop_reason (NO_HISTORY, 0);
stop_stepping (ecs);
return;
This place doesn't set stop_pc but in step_1:
if (find_pc_partial_function (stop_pc, &name,
&tp->step_range_start,
&tp->step_range_end) == 0)
error (_("Cannot find bounds of current function"));
So I add code to set stop_pc. I think this bug will affect main tree
too. So this patch is for both 20080930 branch and main tree.
2008-10-19 Hui Zhu <teawater@gmail.com>
* infrun.c (handle_inferior_event): Set "stop_pc" when
TARGET_WAITKIND_NO_HISTORY.
Thanks,
Hui
[-- Attachment #2: set_stop_pc.txt --]
[-- Type: text/plain, Size: 612 bytes --]
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2008-10-19 Hui Zhu <teawater@gmail.com>
+
+ * infrun.c (handle_inferior_event): Set "stop_pc" when
+ TARGET_WAITKIND_NO_HISTORY.
+
2008-10-18 Pedro Alves <pedro@codesourcery.com>
* infrun.c (adjust_pc_after_break): Do nothing if executing in
--- a/infrun.c
+++ b/infrun.c
@@ -2237,6 +2237,7 @@ handle_inferior_event (struct execution_
case TARGET_WAITKIND_NO_HISTORY:
/* Reverse execution: target ran out of history info. */
+ stop_pc = read_pc ();
print_stop_reason (NO_HISTORY, 0);
stop_stepping (ecs);
return;
next reply other threads:[~2008-10-19 14:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-19 14:21 teawater [this message]
2008-10-19 22:29 ` Michael Snyder
2008-10-20 2:57 ` teawater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daef60380810190721g1ef445cq5c0c2ce5fd24ab41@mail.gmail.com \
--to=teawater@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox