From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22743 invoked by alias); 16 Oct 2008 02:29:18 -0000 Received: (qmail 22733 invoked by uid 22791); 16 Oct 2008 02:29:17 -0000 X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.191) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 16 Oct 2008 02:28:42 +0000 Received: by ti-out-0910.google.com with SMTP id d10so1944148tib.12 for ; Wed, 15 Oct 2008 19:28:39 -0700 (PDT) Received: by 10.110.84.2 with SMTP id h2mr1420263tib.0.1224124119665; Wed, 15 Oct 2008 19:28:39 -0700 (PDT) Received: by 10.110.42.9 with HTTP; Wed, 15 Oct 2008 19:28:39 -0700 (PDT) Message-ID: Date: Thu, 16 Oct 2008 02:29:00 -0000 From: teawater To: "Pedro Alves" Subject: Re: [RFA] Displaced stepping just enable in non-stop mode Cc: "Eli Zaretskii" , gdb-patches@sourceware.org, "Joel Brobecker" , "Michael Snyder" In-Reply-To: <200810160107.42525.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200810160107.42525.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00389.txt.bz2 Thanks for your help Pedro. :) Hui On Thu, Oct 16, 2008 at 08:07, Pedro Alves wrote: > Hi teawater, > > Thanks again for doing this. I believe your patch is close to being OK. I > took the liberty of adjusting it a bit, mostly re-wording a bit the > comments and the documentation. > > I think Joel's suggestion was a good one: By gaining an "auto" > setting, this is as much a maintainer command as > "set breakpoint always-inserted" is. So, I believe it's time we move > the command to the top level "set" command group. > > set can-use-displaced-stepping (auto|on|off) > > Eli, can I ask you to go over the help strings and the documentation in > the patch below? Do they look OK-ish? > > -- > Pedro Alves >