From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17149 invoked by alias); 14 Oct 2008 07:36:45 -0000 Received: (qmail 17139 invoked by uid 22791); 14 Oct 2008 07:36:44 -0000 X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.188) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 14 Oct 2008 07:36:09 +0000 Received: by ti-out-0910.google.com with SMTP id d10so1262849tib.12 for ; Tue, 14 Oct 2008 00:36:05 -0700 (PDT) Received: by 10.110.10.11 with SMTP id 11mr6413555tij.5.1223969765695; Tue, 14 Oct 2008 00:36:05 -0700 (PDT) Received: by 10.110.42.9 with HTTP; Tue, 14 Oct 2008 00:36:05 -0700 (PDT) Message-ID: Date: Tue, 14 Oct 2008 07:36:00 -0000 From: teawater To: "Pedro Alves" Subject: Re: [RFA] Displaced stepping just enable in non-stop mode Cc: gdb-patches@sourceware.org, "Joel Brobecker" , "Michael Snyder" In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_6289_12244589.1223969765697" References: <20081007121745.GH28138@adacore.com> <200810091549.26712.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00343.txt.bz2 ------=_Part_6289_12244589.1223969765697 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 4477 Fix a little bug in "displaced_step_non_step_doc.txt". On Fri, Oct 10, 2008 at 11:37, teawater wrote: > Hi Pedro, > > Thanks for your example, I make a new patch for infrun.c and other for manual. > > 2008-10-10 Hui Zhu > > Displaced stepping can be set to > auto (enable in non-stop mode), on, off. > > * infrun.c (can_use_displaced_stepping): Change type to const > char pointer. > (can_use_displaced_stepping_auto): New string. > (can_use_displaced_stepping_on): New string. > (can_use_displaced_stepping_off): New string. > (can_use_displaced_stepping_enum): New array. > (show_can_use_displaced_stepping): In auto mode, also show the > current effect of the option. > (use_displaced_stepping): Return non-zero if displaced stepping > is auto, and can be used with GDBARCH, and in non-stop mode. > Return non-zero if displaced stepping is on, and can be used > with GDBARCH. > (_initialize_infrun): "can-use-displaced-stepping" function > change to add_setshow_enum_cmd. > > 2008-10-10 Hui Zhu > > * gdb.texinfo (can-use-displaced-stepping) Describe the auto mode > setting, and make it the default. > > > Thanks, > Hui > > On Thu, Oct 9, 2008 at 22:49, Pedro Alves wrote: >> Hi, >> >> Thanks for doing this. >> >> On Wednesday 08 October 2008 07:10:43, teawater wrote: >> >>> -int can_use_displaced_stepping = 1; >>> +const char can_use_displaced_stepping_auto[] = "auto"; >>> +const char can_use_displaced_stepping_on[] = "on"; >>> +const char can_use_displaced_stepping_off[] = "off"; >>> +const char *can_use_displaced_stepping_enum[] = >>> +{ >>> + can_use_displaced_stepping_auto, >>> + can_use_displaced_stepping_on, >>> + can_use_displaced_stepping_off, >>> + NULL, >>> +}; >>> +const char *can_use_displaced_stepping = can_use_displaced_stepping_auto; >> >> Could you make these static while you're at it, please? It was just missed >> in the old boolean setting. >> >>> static void >>> show_can_use_displaced_stepping (struct ui_file *file, int from_tty, >>> struct cmd_list_element *c, >>> @@ -567,12 +579,16 @@ Debugger's willingness to use displaced >>> "breakpoints is %s.\n"), value); >> >> Could you update this function to show what effect the auto setting >> is currently having? See breakpoint.c:show_always_inserted_mode for >> an example. >> >>> } >>> >>> -/* Return non-zero if displaced stepping is enabled, and can be used >>> +/* Return non-zero if displaced stepping is auto, and can be used >>> + with GDBARCH, and in non-stop mode. >>> + Return non-zero if displaced stepping is on, and can be used >>> with GDBARCH. */ >>> static int >>> use_displaced_stepping (struct gdbarch *gdbarch) >>> { >>> - return (can_use_displaced_stepping >>> + return (((can_use_displaced_stepping == can_use_displaced_stepping_auto >>> + && non_stop) >>> + || can_use_displaced_stepping == can_use_displaced_stepping_on) >>> && gdbarch_displaced_step_copy_insn_p (gdbarch)); >>> } >>> >>> @@ -4857,11 +4873,14 @@ function is skipped and the step command >>> show_step_stop_if_no_debug, >>> &setlist, &showlist); >>> >>> - add_setshow_boolean_cmd ("can-use-displaced-stepping", class_maintenance, >>> + add_setshow_enum_cmd ("can-use-displaced-stepping", class_maintenance, >>> + can_use_displaced_stepping_enum, >>> &can_use_displaced_stepping, _("\ >>> Set debugger's willingness to use displaced stepping."), _("\ >>> Show debugger's willingness to use displaced stepping."), _("\ >>> -If zero, gdb will not use displaced stepping to step over\n\ >>> +If auto, gdb will auto use displaced stepping if it need (in non-stop mode).\n\ >>> +If on, gdb will use displaced stepping if such is supported by the target.\n\ >>> +If off, gdb will not use displaced stepping to step over\n\ >>> breakpoints, even if such is supported by the target."), >> >> This also needs to be updated in the manual. I'd suggest borrowing the text >> from breakpoint.c's "always-inserted" command description to make it a >> bit more descriptive, and mention which mode is the default. Should mostly >> be a matter of copy-paste, I think. >> >> -- >> Pedro Alves >> > ------=_Part_6289_12244589.1223969765697 Content-Type: text/plain; name=displaced_step_non_step_doc.txt Content-Transfer-Encoding: base64 X-Attachment-Id: f_fma83hzi2 Content-Disposition: attachment; filename=displaced_step_non_step_doc.txt Content-length: 2697 LS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDgg QEAKKzIwMDgtMTAtMTAgIEh1aSBaaHUgIDx0ZWF3YXRlckBnbWFpbC5jb20+ CisKKwkqIGdkYi50ZXhpbmZvIChjYW4tdXNlLWRpc3BsYWNlZC1zdGVwcGlu ZykgRGVzY3JpYmUgdGhlIGF1dG8gbW9kZQorCXNldHRpbmcsIGFuZCBtYWtl IGl0IHRoZSBkZWZhdWx0LgorCiAyMDA4LTEwLTA2ICBEb3VnIEV2YW5zICA8 ZGplQGdvb2dsZS5jb20+CiAKIAkqIGdkYi50ZXhpbmZvIChzZXQgZGVidWcg ZHdhcmYyLWRpZSk6IERvY3VtZW50IGl0LgotLS0gYS9nZGIudGV4aW5mbwor KysgYi9nZGIudGV4aW5mbwpAQCAtMjM5MzUsMTYgKzIzOTM1LDI1IEBAIFNo YXJlZCBsaWJyYXJ5IGV2ZW50cy4KIAogQGtpbmRleCBtYWludCBzZXQgY2Fu LXVzZS1kaXNwbGFjZWQtc3RlcHBpbmcKIEBraW5kZXggbWFpbnQgc2hvdyBj YW4tdXNlLWRpc3BsYWNlZC1zdGVwcGluZwotQGNpbmRleCBkaXNwbGFjZWQg c3RlcHBpbmcgc3VwcG9ydAotQGNpbmRleCBvdXQtb2YtbGluZSBzaW5nbGUt c3RlcHBpbmcKLUBpdGVtIG1haW50IHNldCBjYW4tdXNlLWRpc3BsYWNlZC1z dGVwcGluZwotQGl0ZW14IG1haW50IHNob3cgY2FuLXVzZS1kaXNwbGFjZWQt c3RlcHBpbmcKLUNvbnRyb2wgd2hldGhlciBvciBub3QgQHZhbHVle0dEQk59 IHdpbGwgZG8gQGRmbntkaXNwbGFjZWQgc3RlcHBpbmd9Ci1pZiB0aGUgdGFy Z2V0IHN1cHBvcnRzIGl0LiAgVGhlIGRlZmF1bHQgaXMgb24uICBEaXNwbGFj ZWQgc3RlcHBpbmcgaXMKLWEgd2F5IHRvIHNpbmdsZS1zdGVwIG92ZXIgYnJl YWtwb2ludHMgd2l0aG91dCByZW1vdmluZyB0aGVtIGZyb20gdGhlCi1pbmZl cmlvciwgYnkgZXhlY3V0aW5nIGFuIG91dC1vZi1saW5lIGNvcHkgb2YgdGhl IGluc3RydWN0aW9uIHRoYXQgd2FzCi1vcmlnaW5hbGx5IGF0IHRoZSBicmVh a3BvaW50IGxvY2F0aW9uLiAgSXQgaXMgYWxzbyBrbm93biBhcwotb3V0LW9m LWxpbmUgc2luZ2xlLXN0ZXBwaW5nLgorQHRhYmxlIEBjb2RlCitAaXRlbSBt YWludCBzZXQgY2FuLXVzZS1kaXNwbGFjZWQtc3RlcHBpbmcgb24KK0lmIHRo ZSB0YXJnZXQgc3VwcG9ydHMgaXQuICBHZGIgYmVoYXZlcyBhcmUgc2luZ2xl LXN0ZXAgb3ZlcgorYnJlYWtwb2ludHMgd2l0aG91dCByZW1vdmluZyB0aGVt IGZyb20gdGhlIGluZmVyaW9yLCBieSBleGVjdXRpbmcKK2FuIG91dC1vZi1s aW5lIGNvcHkgb2YgdGhlIGluc3RydWN0aW9uIHRoYXQgd2FzIG9yaWdpbmFs bHkgYXQgdGhlCiticmVha3BvaW50IGxvY2F0aW9uLiAgSXQgaXMgYWxzbyBr bm93biBhcyBvdXQtb2YtbGluZSBzaW5nbGUtc3RlcHBpbmcuCisKK0BpdGVt IG1haW50IHNldCBjYW4tdXNlLWRpc3BsYWNlZC1zdGVwcGluZyBvZmYKK0dk YiBiZWhhdmVzIGFyZSBzaW5nbGUtc3RlcCBvdmVyIGJyZWFrcG9pbnRzIHdp dGggcmVtb3ZpbmcgdGhlbSBmcm9tCit0aGUgaW5mZXJpb3IuCisKK0BjaW5k ZXggbm9uLXN0b3AgbW9kZSwgYW5kIEBzYW1we21haW50IHNldCBjYW4tdXNl LWRpc3BsYWNlZC1zdGVwcGluZ30KK0BpdGVtIG1haW50IHNldCBjYW4tdXNl LWRpc3BsYWNlZC1zdGVwcGluZyBhdXRvCitUaGlzIGlzIHRoZSBkZWZhdWx0 IG1vZGUuICBJZiBAdmFsdWV7R0RCTn0gaXMgY29udHJvbGxpbmcgdGhlIGlu ZmVyaW9yCitpbiBub24tc3RvcCBtb2RlIChAcHhyZWZ7Tm9uLVN0b3AgTW9k ZX0pLCBnZGIgYmVoYXZlcyBhcyBpZgorQGNvZGV7Y2FuLXVzZS1kaXNwbGFj ZWQtc3RlcHBpbmd9IG1vZGUgaXMgb24uICBJZiBAdmFsdWV7R0RCTn0gaXMK K2NvbnRyb2xsaW5nIHRoZSBpbmZlcmlvciBpbiBhbGwtc3RvcCBtb2RlLCBA dmFsdWV7R0RCTn0gYmVoYXZlcyBhcyBpZgorQGNvZGV7Y2FuLXVzZS1kaXNw bGFjZWQtc3RlcHBpbmd9IG1vZGUgaXMgb2ZmLgorQGVuZCB0YWJsZQogCiBA a2luZGV4IG1haW50IGNoZWNrLXN5bXRhYnMKIEBpdGVtIG1haW50IGNoZWNr LXN5bXRhYnMK ------=_Part_6289_12244589.1223969765697--