From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 416 invoked by alias); 8 Oct 2008 06:11:23 -0000 Received: (qmail 406 invoked by uid 22791); 8 Oct 2008 06:11:22 -0000 X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.188) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 08 Oct 2008 06:10:47 +0000 Received: by ti-out-0910.google.com with SMTP id d10so2438745tib.12 for ; Tue, 07 Oct 2008 23:10:43 -0700 (PDT) Received: by 10.110.105.10 with SMTP id d10mr8877886tic.18.1223446243858; Tue, 07 Oct 2008 23:10:43 -0700 (PDT) Received: by 10.110.42.9 with HTTP; Tue, 7 Oct 2008 23:10:43 -0700 (PDT) Message-ID: Date: Wed, 08 Oct 2008 06:11:00 -0000 From: teawater To: "Joel Brobecker" , "Michael Snyder" , "Pedro Alves" Subject: Re: [RFA] Displaced stepping just enable in non-stop mode Cc: "gdb-patches@sourceware.org" In-Reply-To: <20081007121745.GH28138@adacore.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_54273_32623548.1223446243852" References: <20081007121745.GH28138@adacore.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00244.txt.bz2 ------=_Part_54273_32623548.1223446243852 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 1539 Hi Joel, According to your mail, I make a new patch. 2008-10-08 Hui Zhu Displaced stepping can be set to auto (enable in non-stop mode), on, off. * infrun.c (can_use_displaced_stepping): Change type to const char pointer. (can_use_displaced_stepping_auto): New string. (can_use_displaced_stepping_on): New string. (can_use_displaced_stepping_off): New string. (can_use_displaced_stepping_enum): New array. (use_displaced_stepping): Return non-zero if displaced stepping is auto, and can be used with GDBARCH, and in non-stop mode. Return non-zero if displaced stepping is on, and can be used with GDBARCH. (_initialize_infrun): "can-use-displaced-stepping" function change to add_setshow_enum_cmd. Thanks, Hui On Tue, Oct 7, 2008 at 20:17, Joel Brobecker wrote: >> 2008-10-07 Hui Zhu >> >> * infrun.c (use_displaced_stepping): Displaced stepping just >> enable in non-stop mode. > > There is still a piece missing. Namely, allow the user to force > displaced-stepping in a mode that is not non-stop. Pedro suggested that > we either change the maint command, or add a new one. How about changing > the maint command into a mainstream command that's a tri-state: > > set use-displaced-stepping (auto|on|off) > > By default, it's "auto" which means that the debugger tries to determine > from the situation whether it's necessary or not (basically if non-stop). > But the user can then override the decision either way. > > -- > Joel > ------=_Part_54273_32623548.1223446243852 Content-Type: text/plain; name=displaced_step_non_step.txt Content-Transfer-Encoding: base64 X-Attachment-Id: f_fm1keed50 Content-Disposition: attachment; filename=displaced_step_non_step.txt Content-length: 4876 LS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDA4LTEwLTA4ICBIdWkgWmh1ICA8dGVhd2F0ZXJAZ21haWwuY29t PgorCisJRGlzcGxhY2VkIHN0ZXBwaW5nIGNhbiBiZSBzZXQgdG8KKwlhdXRv IChlbmFibGUgaW4gbm9uLXN0b3AgbW9kZSksIG9uLCBvZmYuCisKKwkqIGlu ZnJ1bi5jIChjYW5fdXNlX2Rpc3BsYWNlZF9zdGVwcGluZyk6IENoYW5nZSB0 eXBlIHRvIGNvbnN0CisJY2hhciBwb2ludGVyLgorCShjYW5fdXNlX2Rpc3Bs YWNlZF9zdGVwcGluZ19hdXRvKTogTmV3IHN0cmluZy4KKwkoY2FuX3VzZV9k aXNwbGFjZWRfc3RlcHBpbmdfb24pOiBOZXcgc3RyaW5nLgorCShjYW5fdXNl X2Rpc3BsYWNlZF9zdGVwcGluZ19vZmYpOiBOZXcgc3RyaW5nLgorCShjYW5f dXNlX2Rpc3BsYWNlZF9zdGVwcGluZ19lbnVtKTogTmV3IGFycmF5LgorCSh1 c2VfZGlzcGxhY2VkX3N0ZXBwaW5nKTogUmV0dXJuIG5vbi16ZXJvIGlmIGRp c3BsYWNlZCBzdGVwcGluZworIAlpcyBhdXRvLCBhbmQgY2FuIGJlIHVzZWQg d2l0aCBHREJBUkNILCBhbmQgaW4gbm9uLXN0b3AgbW9kZS4KKwlSZXR1cm4g bm9uLXplcm8gaWYgZGlzcGxhY2VkIHN0ZXBwaW5nIGlzIG9uLCBhbmQgY2Fu IGJlIHVzZWQKKwl3aXRoIEdEQkFSQ0guCisJKF9pbml0aWFsaXplX2luZnJ1 bik6ICJjYW4tdXNlLWRpc3BsYWNlZC1zdGVwcGluZyIgZnVuY3Rpb24KKwlj aGFuZ2UgdG8gYWRkX3NldHNob3dfZW51bV9jbWQuCisKIDIwMDgtMTAtMDYg IERvdWcgRXZhbnMgIDxkamVAZ29vZ2xlLmNvbT4KIAogCSogZHdhcmYycmVh ZC5jIChkd2FyZjJfZGllX2RlYnVnKTogTmV3IHN0YXRpYyBnbG9iYWwuCi0t LSBhL2luZnJ1bi5jCisrKyBiL2luZnJ1bi5jCkBAIC01NTMsMTAgKzU1Mywy MiBAQCBzdGF0aWMgQ09SRV9BRERSIGRpc3BsYWNlZF9zdGVwX29yaWdpbmFs CiAvKiBTYXZlZCBjb250ZW50cyBvZiBjb3B5IGFyZWEuICAqLwogc3RhdGlj IGdkYl9ieXRlICpkaXNwbGFjZWRfc3RlcF9zYXZlZF9jb3B5OwogCi0vKiBX aGVuIHRoaXMgaXMgbm9uLXplcm8sIHdlIGFyZSBhbGxvd2VkIHRvIHVzZSBk aXNwbGFjZWQgc3RlcHBpbmcsIGlmCi0gICB0aGUgYXJjaGl0ZWN0dXJlIHN1 cHBvcnRzIGl0LiAgV2hlbiB0aGlzIGlzIHplcm8sIHdlIHVzZQorLyogV2hl biB0aGlzIGlzIGF1dG8sIHdlIGFyZSBhbGxvd2VkIHRvIHVzZSBkaXNwbGFj ZWQgc3RlcHBpbmcsCisgICBJZiB0aGUgYXJjaGl0ZWN0dXJlIHN1cHBvcnRz IGl0IGFuZCBpbiBub24tc3RvcCBtb2RlLgorICAgV2hlbiB0aGlzIGlzIG9u LCB3ZSBhcmUgYWxsb3dlZCB0byB1c2UgZGlzcGxhY2VkIHN0ZXBwaW5nLCBp ZgorICAgdGhlIGFyY2hpdGVjdHVyZSBzdXBwb3J0cyBpdC4gIFdoZW4gdGhp cyBpcyBvZmYsIHdlIHVzZQogICAgdHJhZGl0aW9uYWwgdGhlIGhvbGQtYW5k LXN0ZXAgYXBwcm9hY2guICAqLwotaW50IGNhbl91c2VfZGlzcGxhY2VkX3N0 ZXBwaW5nID0gMTsKK2NvbnN0IGNoYXIgY2FuX3VzZV9kaXNwbGFjZWRfc3Rl cHBpbmdfYXV0b1tdID0gImF1dG8iOworY29uc3QgY2hhciBjYW5fdXNlX2Rp c3BsYWNlZF9zdGVwcGluZ19vbltdID0gIm9uIjsKK2NvbnN0IGNoYXIgY2Fu X3VzZV9kaXNwbGFjZWRfc3RlcHBpbmdfb2ZmW10gPSAib2ZmIjsKK2NvbnN0 IGNoYXIgKmNhbl91c2VfZGlzcGxhY2VkX3N0ZXBwaW5nX2VudW1bXSA9Cit7 CisgIGNhbl91c2VfZGlzcGxhY2VkX3N0ZXBwaW5nX2F1dG8sCisgIGNhbl91 c2VfZGlzcGxhY2VkX3N0ZXBwaW5nX29uLAorICBjYW5fdXNlX2Rpc3BsYWNl ZF9zdGVwcGluZ19vZmYsCisgIE5VTEwsCit9OworY29uc3QgY2hhciAqY2Fu X3VzZV9kaXNwbGFjZWRfc3RlcHBpbmcgPSBjYW5fdXNlX2Rpc3BsYWNlZF9z dGVwcGluZ19hdXRvOwogc3RhdGljIHZvaWQKIHNob3dfY2FuX3VzZV9kaXNw bGFjZWRfc3RlcHBpbmcgKHN0cnVjdCB1aV9maWxlICpmaWxlLCBpbnQgZnJv bV90dHksCiAJCQkJIHN0cnVjdCBjbWRfbGlzdF9lbGVtZW50ICpjLApAQCAt NTY3LDEyICs1NzksMTYgQEAgRGVidWdnZXIncyB3aWxsaW5nbmVzcyB0byB1 c2UgZGlzcGxhY2VkIAogImJyZWFrcG9pbnRzIGlzICVzLlxuIiksIHZhbHVl KTsKIH0KIAotLyogUmV0dXJuIG5vbi16ZXJvIGlmIGRpc3BsYWNlZCBzdGVw cGluZyBpcyBlbmFibGVkLCBhbmQgY2FuIGJlIHVzZWQKKy8qIFJldHVybiBu b24temVybyBpZiBkaXNwbGFjZWQgc3RlcHBpbmcgaXMgYXV0bywgYW5kIGNh biBiZSB1c2VkCisgICB3aXRoIEdEQkFSQ0gsIGFuZCBpbiBub24tc3RvcCBt b2RlLgorICAgUmV0dXJuIG5vbi16ZXJvIGlmIGRpc3BsYWNlZCBzdGVwcGlu ZyBpcyBvbiwgYW5kIGNhbiBiZSB1c2VkCiAgICB3aXRoIEdEQkFSQ0guICAq Lwogc3RhdGljIGludAogdXNlX2Rpc3BsYWNlZF9zdGVwcGluZyAoc3RydWN0 IGdkYmFyY2ggKmdkYmFyY2gpCiB7Ci0gIHJldHVybiAoY2FuX3VzZV9kaXNw bGFjZWRfc3RlcHBpbmcKKyAgcmV0dXJuICgoKGNhbl91c2VfZGlzcGxhY2Vk X3N0ZXBwaW5nID09IGNhbl91c2VfZGlzcGxhY2VkX3N0ZXBwaW5nX2F1dG8K KwkgICAgJiYgbm9uX3N0b3ApCisJICAgfHwgY2FuX3VzZV9kaXNwbGFjZWRf c3RlcHBpbmcgPT0gY2FuX3VzZV9kaXNwbGFjZWRfc3RlcHBpbmdfb24pCiAJ ICAmJiBnZGJhcmNoX2Rpc3BsYWNlZF9zdGVwX2NvcHlfaW5zbl9wIChnZGJh cmNoKSk7CiB9CiAKQEAgLTQ4NTcsMTEgKzQ4NzMsMTQgQEAgZnVuY3Rpb24g aXMgc2tpcHBlZCBhbmQgdGhlIHN0ZXAgY29tbWFuZAogCQkJICAgc2hvd19z dGVwX3N0b3BfaWZfbm9fZGVidWcsCiAJCQkgICAmc2V0bGlzdCwgJnNob3ds aXN0KTsKIAotICBhZGRfc2V0c2hvd19ib29sZWFuX2NtZCAoImNhbi11c2Ut ZGlzcGxhY2VkLXN0ZXBwaW5nIiwgY2xhc3NfbWFpbnRlbmFuY2UsCisgIGFk ZF9zZXRzaG93X2VudW1fY21kICgiY2FuLXVzZS1kaXNwbGFjZWQtc3RlcHBp bmciLCBjbGFzc19tYWludGVuYW5jZSwKKwkJCSAgIGNhbl91c2VfZGlzcGxh Y2VkX3N0ZXBwaW5nX2VudW0sCiAJCQkgICAmY2FuX3VzZV9kaXNwbGFjZWRf c3RlcHBpbmcsIF8oIlwKIFNldCBkZWJ1Z2dlcidzIHdpbGxpbmduZXNzIHRv IHVzZSBkaXNwbGFjZWQgc3RlcHBpbmcuIiksIF8oIlwKIFNob3cgZGVidWdn ZXIncyB3aWxsaW5nbmVzcyB0byB1c2UgZGlzcGxhY2VkIHN0ZXBwaW5nLiIp LCBfKCJcCi1JZiB6ZXJvLCBnZGIgd2lsbCBub3QgdXNlIGRpc3BsYWNlZCBz dGVwcGluZyB0byBzdGVwIG92ZXJcblwKK0lmIGF1dG8sIGdkYiB3aWxsIGF1 dG8gdXNlIGRpc3BsYWNlZCBzdGVwcGluZyBpZiBpdCBuZWVkIChpbiBub24t c3RvcCBtb2RlKS5cblwKK0lmIG9uLCBnZGIgd2lsbCB1c2UgZGlzcGxhY2Vk IHN0ZXBwaW5nIGlmIHN1Y2ggaXMgc3VwcG9ydGVkIGJ5IHRoZSB0YXJnZXQu XG5cCitJZiBvZmYsIGdkYiB3aWxsIG5vdCB1c2UgZGlzcGxhY2VkIHN0ZXBw aW5nIHRvIHN0ZXAgb3ZlclxuXAogYnJlYWtwb2ludHMsIGV2ZW4gaWYgc3Vj aCBpcyBzdXBwb3J0ZWQgYnkgdGhlIHRhcmdldC4iKSwKIAkJCSAgIE5VTEws CiAJCQkgICBzaG93X2Nhbl91c2VfZGlzcGxhY2VkX3N0ZXBwaW5nLAo= ------=_Part_54273_32623548.1223446243852--