From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13496 invoked by alias); 3 Oct 2008 00:20:45 -0000 Received: (qmail 13448 invoked by uid 22791); 3 Oct 2008 00:20:44 -0000 X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.185) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 03 Oct 2008 00:20:09 +0000 Received: by ti-out-0910.google.com with SMTP id d10so775882tib.12 for ; Thu, 02 Oct 2008 17:20:06 -0700 (PDT) Received: by 10.110.95.15 with SMTP id s15mr381386tib.40.1222993206293; Thu, 02 Oct 2008 17:20:06 -0700 (PDT) Received: by 10.110.42.9 with HTTP; Thu, 2 Oct 2008 17:20:06 -0700 (PDT) Message-ID: Date: Fri, 03 Oct 2008 00:20:00 -0000 From: teawater To: "Michael Snyder" Subject: Re: [RFA record/replay branch] Eliminate a global variable Cc: "gdb-patches@sourceware.org" In-Reply-To: <48E56450.2030803@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <48E56450.2030803@vmware.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00073.txt.bz2 Looks good. Please check it in. Thanks, Hui On Fri, Oct 3, 2008 at 08:16, Michael Snyder wrote: > Seems like we can use target_can_async_p() here > instead of relying on a global variable. > > > 2008-10-02 Michael Snyder > > * record.c (record_open): Call target_can_async_p() instead > of relying on a global variable. > * record.h (record_linux_async_permitted): Delete. > * linux-nat.h (record_linux_async_permitted): Delete reference. > > Index: record.c > =================================================================== > RCS file: /cvs/src/src/gdb/Attic/record.c,v > retrieving revision 1.1.2.14 > diff -u -p -r1.1.2.14 record.c > --- record.c 22 Sep 2008 17:43:11 -0000 1.1.2.14 > +++ record.c 3 Oct 2008 00:12:38 -0000 > @@ -48,7 +48,6 @@ static int record_insn_num = 0; > struct target_ops record_ops; > int record_resume_step = 0; > enum exec_direction_kind record_execdir = EXEC_FORWARD; > -int record_linux_async_permitted = 0; > static int record_get_sig = 0; > static sigset_t record_maskall; > static int record_not_record = 0; > @@ -423,7 +422,7 @@ record_open (char *name, int from_tty) > { > error (_("Record: record target can't debug inferior in non-stop mode > (non-stop).")); > } > - if (record_linux_async_permitted) > + if (target_can_async_p ()) > { > error (_("Record: record target can't debug the GNU/Linux inferior in > asynchronous mode (linux-async).")); > } > Index: record.h > =================================================================== > RCS file: /cvs/src/src/gdb/Attic/record.h,v > retrieving revision 1.1.2.4 > diff -u -p -r1.1.2.4 record.h > --- record.h 2 Sep 2008 09:18:28 -0000 1.1.2.4 > +++ record.h 3 Oct 2008 00:12:38 -0000 > @@ -77,7 +77,6 @@ extern struct target_ops record_ops; > extern int record_resume_step; > extern int record_regcache_raw_write_regnum; > extern enum exec_direction_kind record_execdir; > -extern int record_linux_async_permitted; > > extern int record_arch_list_add_reg (int num); > extern int record_arch_list_add_mem (CORE_ADDR addr, int len); > Index: linux-nat.c > =================================================================== > RCS file: /cvs/src/src/gdb/linux-nat.c,v > retrieving revision 1.94.2.3 > diff -u -p -r1.94.2.3 linux-nat.c > --- linux-nat.c 2 Sep 2008 09:18:28 -0000 1.94.2.3 > +++ linux-nat.c 3 Oct 2008 00:12:38 -0000 > @@ -4126,7 +4126,6 @@ set_maintenance_linux_async_permitted (c > } > > linux_async_permitted = linux_async_permitted_1; > - record_linux_async_permitted = linux_async_permitted; > linux_nat_set_async_mode (linux_async_permitted); > } > > >