From: Keith Seitz <keiths@redhat.com>
To: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 1/3] Handle custom completion match prefix / LCD
Date: Tue, 28 Nov 2017 01:42:00 -0000 [thread overview]
Message-ID: <dac82f21-be90-62f0-7b66-f50f62ddeab9@redhat.com> (raw)
In-Reply-To: <1511802824-643-2-git-send-email-palves@redhat.com>
On 11/27/2017 09:13 AM, Pedro Alves wrote:
> In v2:
>
> - Addresses Keith's review. The main change is that it adds a
> convenience method to completion_match_result to set both regular
> match and the match for LCD. This is the new
> completion_match_result::set_match method.
That looks okay to me.
Thanks!
Keith
next prev parent reply other threads:[~2017-11-28 1:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 17:13 [PATCH v2 0/3] C++ debugging improvements: wild matching and ABI tags Pedro Alves
2017-11-27 17:13 ` [PATCH v2 1/3] Handle custom completion match prefix / LCD Pedro Alves
2017-11-28 1:42 ` Keith Seitz [this message]
2017-11-27 17:13 ` [PATCH v2 3/3] Breakpoints in symbols with ABI tags (PR c++/19436) Pedro Alves
2017-11-28 3:47 ` Keith Seitz
2017-11-27 17:14 ` [PATCH v2 2/3] Make "break foo" find "A::foo", A::B::foo", etc. [C++ and wild matching] Pedro Alves
2017-11-27 17:47 ` Eli Zaretskii
2017-11-28 0:01 ` Pedro Alves
2017-11-28 0:14 ` [PATCH v2.1 " Pedro Alves
2017-11-28 2:50 ` Keith Seitz
2017-11-28 12:39 ` Pedro Alves
2017-11-28 17:35 ` Keith Seitz
2017-11-29 19:52 ` Pedro Alves
2017-11-27 17:33 ` [PATCH v2 0/3] C++ debugging improvements: wild matching and ABI tags Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dac82f21-be90-62f0-7b66-f50f62ddeab9@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox