From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Remove a cleanup from scm-frame.c
Date: Mon, 23 Apr 2018 01:40:00 -0000 [thread overview]
Message-ID: <daa6c48acfffc5ca6f3c76a5c48fc97b@polymtl.ca> (raw)
On 2018-04-22 19:47, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
>
> Simon> This looks good to me at first glance. Do you know if scm
> exceptions
> Simon> (scm_throw) play well with C++, the destructors of the objects
> in the
> Simon> exited scopes will correctly be called?
>
> I don't believe so, which is why this patch introduces a new scope.
>
> Tom
Ahh, I didn't catch that initially, and it makes sense with the comment.
LGTM then!
Simon
next reply other threads:[~2018-04-23 1:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 1:40 Simon Marchi [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-04-21 22:39 Tom Tromey
2018-04-22 14:21 ` Simon Marchi
2018-04-22 23:47 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daa6c48acfffc5ca6f3c76a5c48fc97b@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox