From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YKp7ENEhA2Z8QhcAWB0awg (envelope-from ) for ; Tue, 26 Mar 2024 15:28:17 -0400 Received: by simark.ca (Postfix, from userid 112) id 3A8941E0C0; Tue, 26 Mar 2024 15:28:17 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 237FA1E08C for ; Tue, 26 Mar 2024 15:28:15 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A4984385840E for ; Tue, 26 Mar 2024 19:28:14 +0000 (GMT) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by sourceware.org (Postfix) with ESMTPS id 17E1E3858CD1 for ; Tue, 26 Mar 2024 19:27:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 17E1E3858CD1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 17E1E3858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711481277; cv=none; b=c4MsIAtCpbUE+gAZg1ZlQKcwbJ2AS4o5IFQetcQeAPTASXjW4/fCjKItGoK+WkweM7tORXuiajaoATIS+jiENEyijucf1eWx7URjf7kIsE5Av9zVPlpiqVJkVeGms+V4bWo0ijuqowgEgNky6ad5F94m13N3uXNz4JlQPFZIiFs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711481277; c=relaxed/simple; bh=xIXf0pZaiUfhMjLOi0WuhBmesEqP/jvb6m/3zxYKW9o=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=J8HTE8hS3NGWE3pWrvOh3K/s/6r0HCfFkGI/0QURCW+YkhublFv1nnkpCmCUJbinCFNZAZJ+VkXWXkFQdQ0dZdBtTrXT2gknqUl4ZBcgF6XAk12khUqoeD1qaUsxzXiYzKNdQIFlt5EDZ7fH+fXrpMnbKe+oc+ICT+iMEvgP0rs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-341d381d056so1068630f8f.0 for ; Tue, 26 Mar 2024 12:27:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711481274; x=1712086074; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GUtJCw8qfwX+SpgIUlkIo1WnBbENrc4x8xeElm+sQHM=; b=kZqNMo50H1aM80tw/vdedMsWVT5vTguBB9S1fobeYCkXm1RzvW/Ku9ScDxiEP0vg7D 5FhSYO6DNCkicJQ8UWcO6KNdv45GmCikap3GvdSrSCbHPhdZrwX9GhGpJY9J41aN40CN 5N7rXIxjthyOvQk+BQJATNb6aBsW+DYZ67+P6mW9IXFCBe9xMfG2BSamJ+jYlvuZTnn9 1gFeJtATDhfTIYmWACuB/cA5uhD/IS/gyu0Qr4vxgjqX0UBcRxwf4niEEIXQAk+NQCgM r4rTWWuDmSE25wyTo9XQN7cT9WdIEJipZAUgM0i0JWCMIPKVJA45mSeU7SkU+d/BTT5L ND6g== X-Gm-Message-State: AOJu0Yx5iWxI/tBXpQuAvYtbPDfwJPK0MD4JPGDzKEK7JlWENdfOnfz1 B0xlfUFzw/LYgTdg6R0UGHJoXtlo4BsbFCmuWUaRz+OEiofb5uTE X-Google-Smtp-Source: AGHT+IEHthWQ4gSkoDtOQkEtYAg4LVbe8vGHnHiuMJXmY4vpr3VIW9p3J+VFsOnZjLbdOMewjuaA8w== X-Received: by 2002:a05:6000:1d89:b0:341:cfa4:6076 with SMTP id bk9-20020a0560001d8900b00341cfa46076mr4957321wrb.25.1711481273484; Tue, 26 Mar 2024 12:27:53 -0700 (PDT) Received: from ?IPV6:2001:8a0:f918:ab00:a3cb:34d8:f2e6:d08? ([2001:8a0:f918:ab00:a3cb:34d8:f2e6:d08]) by smtp.gmail.com with ESMTPSA id z6-20020a5d4406000000b0033cf60e268fsm12859738wrq.116.2024.03.26.12.27.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Mar 2024 12:27:53 -0700 (PDT) Message-ID: Date: Tue, 26 Mar 2024 19:27:51 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] New testcase gdb.threads/leader-exit-attach.exp (PR threads/8153) Content-Language: en-US To: Tom Tromey Cc: "gdb-patches@sourceware.org" , Eli Zaretskii References: <20240322193030.1235342-1-pedro@palves.net> <86wmptzc2f.fsf@gnu.org> <2544bf99-997c-4065-8ae9-4dfb0b07d17b@palves.net> <87h6gtc8v9.fsf@tromey.com> From: Pedro Alves In-Reply-To: <87h6gtc8v9.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 2024-03-26 15:26, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> Here's said testcase. Only two decades between original fix and testcase, > Pedro> not too bad. :-) > > Does this mean that the phony process stuff is needed and so it should > be ported to gdbserver as well? At least on Windows 10, it isn't needed. The jury is still out on whether it is needed on any Windows version we claim to support (Windows XP and up). I was hoping we could drop all that hacky stuff from gdb instead of adding it to gdbserver. I can't run Cygwin tests against gdbserver atm for the some reason I can't explain, but if I try it manually, GDBserver attaches to the process just fine. If I run the new test on native Cygwin with this: --- c/gdb/windows-nat.c +++ w/gdb/windows-nat.c @@ -1360,6 +1360,8 @@ windows_nat_target::windows_continue (DWORD continue_status, int id, DWORD windows_nat_target::fake_create_process () { + gdb_assert (0); + ... it still passes. I only tripped on the bad ptid in the phony process code path because I had a bug in the non-stop series that happened to result in that path being incorrectly taken. Pedro Alves > > Maybe we need another new bug. > > Tom