Re: [PATCH 1/4] gdb/testsuite: Remove build paths from test names

Simon Marchi
2020-04-24T14:00:44Z

On 2020-04-23 1:53 p.m., Andrew Burgess wrote:
> Having paths in test names makes it harder to compare results from
> different builds of GDB.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.btrace/multi-inferior.exp: Avoid paths in test names.
> ---
> gdb/testsuite/ChangeLog | 4 ++++
> gdb/testsuite/gdb.btrace/multi-inferior.exp | 6 ++++--
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/testsuite/gdb.btrace/multi-inferior.exp b/gdb/testsuite/gdb.btrace/multi-inferior.exp
> index 87a99332e03..fdf889f5ed8 100644
> --- a/gdb/testsuite/gdb.btrace/multi-inferior.exp
> +++ b/gdb/testsuite/gdb.btrace/multi-inferior.exp
> @@ -40,7 +40,8 @@ with_test_prefix "inferior 1" {
> }
>
> with_test_prefix "inferior 2" {
> - gdb_test "add-inferior -exec ${binfile}" "Added inferior 2.*"
> + gdb_test "add-inferior -exec ${binfile}" "Added inferior 2.*" \
> + "add second inferior"
> gdb_test "inferior 2" "Switching to inferior 2.*"
>
> if ![runto_main] {
> @@ -59,7 +60,8 @@ with_test_prefix "inferior 1" {
> }
>
> with_test_prefix "inferior 3" {
> - gdb_test "add-inferior -exec ${binfile}" "Added inferior 3.*"
> + gdb_test "add-inferior -exec ${binfile}" "Added inferior 3.*" \
> + "add third inferior"
> gdb_test "inferior 3" "Switching to inferior 3.*"
>
> if ![runto_main] {
> --
> 2.25.3
>

This LGTM, regardless of the rest of the series.

Simon