Re: [PATCH 0/4] Automatic detection of test name problems

Keith Seitz
2020-04-23T20:25:38Z

On 4/23/20 10:53 AM, Andrew Burgess wrote:
> So, this series extends our testing framework so that Dejagnu will now
> produce two new result types, these are:
>
> # of paths in test names
> # of duplicate test names

[snip]

> I'll merge the first patch in this series (the
> gdb.btrace/multi-inferior.exp fix) relatively soon as obvious.
>
> Feedback and thoughts welcome.

This has been a constant source of annoyance and is long overdue. Bravo!

I've looked over the series, sending queries as required. Overall, my
only general comment is, "Why didn't *I* think of this?!?"

Otherwise LGTM.

Going one step further (maybe you've already considered this),
maybe we can [bug Sergio to?] add something to the buildbot so that when it
detects duplicates or pathnames, it emails the list as for regressions?

Keith