From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86756 invoked by alias); 9 Feb 2018 13:11:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 86729 invoked by uid 89); 9 Feb 2018 13:10:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Andre X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Feb 2018 13:10:59 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A9831404084A; Fri, 9 Feb 2018 13:10:57 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 311B22166BAE; Fri, 9 Feb 2018 13:10:57 +0000 (UTC) Subject: Re: [RFA 7/9] Use std::vector in find_source_lines To: Tom Tromey References: <20180207220434.6045-1-tom@tromey.com> <20180207220434.6045-8-tom@tromey.com> <876076wc67.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Fri, 09 Feb 2018 13:11:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <876076wc67.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-02/txt/msg00155.txt.bz2 On 02/09/2018 01:00 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom Tromey writes: > > Tom> + end = &data[size]; > > Andre pointed out that this is possibly fishy, so I think perhaps the > appended should go in. Ok? OK. Thanks, Pedro Alves