From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MpH2N9sp8WnItQEAWB0awg (envelope-from ) for ; Tue, 28 Apr 2026 17:42:51 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tN1KNEVp; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=VjRUYWHc; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tN1KNEVp; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=VjRUYWHc; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D29901E0BA; Tue, 28 Apr 2026 17:42:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A0EFB1E093 for ; Tue, 28 Apr 2026 17:42:50 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id A3E894BA23E8 for ; Tue, 28 Apr 2026 21:42:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A3E894BA23E8 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tN1KNEVp; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=VjRUYWHc; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tN1KNEVp; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=VjRUYWHc Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 129C24BA2E0D for ; Tue, 28 Apr 2026 21:42:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 129C24BA2E0D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 129C24BA2E0D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777412539; cv=none; b=wqNcHZ9HoDuIf6mhIqA7XvePWBdMos+xFRUYgmi+YYUgm9dOpx8FRwOK8mxIgQc12EP0AtyWjQHF0MjoeB1Kt+BIVhsUO4hSZksXDrnSfuU88VZDJF07Sjq7Jroijdn9ITqZex7a2Xk3d+psE6d56pWx284oF6t2J0sXDMGMQ30= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777412539; c=relaxed/simple; bh=9InGNBEFyqqoVrjJqGPLvG/ZdRSx3amWu1fG6tzkDLM=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=EWGtKKcXXfwvZa2QVWvbiO2nNe0W1inDPFTtL5CZNwPEnDNg2VMIYLLx24+m7KmJp7tkA1XuOee2vyrxF0ZG0abL13PahUu/8X+hoYEUvHIaUZO6XdMALDjwtXdVTr5fVbHvk4IX9jJzOUqnOY5Q6QO1Kpm3kCdstwCraLoR05U= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 129C24BA2E0D Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 404D36A880; Tue, 28 Apr 2026 21:42:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777412537; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I0CuMtjREvrczeGPzL15yZdpF/ch1Rj5R3skNRNbqCs=; b=tN1KNEVpLLmPLFhyKicM8mBuFkGDeROJ5ilH/A34mgFJ6BRvcaSWScpqoAzxaKThcY59K+ +6R81RMUlAS6gz6N78PjNohQGtS6hJP4Wxf7tRTTGWEDDoaiPm/+B228ayUj6YqPaOE1Za 2vn155hmd2kipT9VW0QGKnlFWYZOaxg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777412537; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I0CuMtjREvrczeGPzL15yZdpF/ch1Rj5R3skNRNbqCs=; b=VjRUYWHcvfJNcDV189rj19iXq19/dHu8I3X2sQl494Qp6+ACL4o5v24eJ/JJVfnST/QJCb zF36G98oMN1wPTCA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=tN1KNEVp; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=VjRUYWHc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777412537; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I0CuMtjREvrczeGPzL15yZdpF/ch1Rj5R3skNRNbqCs=; b=tN1KNEVpLLmPLFhyKicM8mBuFkGDeROJ5ilH/A34mgFJ6BRvcaSWScpqoAzxaKThcY59K+ +6R81RMUlAS6gz6N78PjNohQGtS6hJP4Wxf7tRTTGWEDDoaiPm/+B228ayUj6YqPaOE1Za 2vn155hmd2kipT9VW0QGKnlFWYZOaxg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777412537; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I0CuMtjREvrczeGPzL15yZdpF/ch1Rj5R3skNRNbqCs=; b=VjRUYWHcvfJNcDV189rj19iXq19/dHu8I3X2sQl494Qp6+ACL4o5v24eJ/JJVfnST/QJCb zF36G98oMN1wPTCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2B2B1593B0; Tue, 28 Apr 2026 21:42:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 9p8RCbkp8WlyVQAAD6G6ig (envelope-from ); Tue, 28 Apr 2026 21:42:17 +0000 Message-ID: Date: Tue, 28 Apr 2026 23:42:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/tui] Handle error in tui_enable To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260424154942.50673-1-tdevries@suse.de> <874ikvnpkq.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <874ikvnpkq.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: 404D36A880 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/28/26 4:10 PM, Tom Tromey wrote: > Tom> IWBN to fix this in a way that allows the second "tui enable" to succeed. I > Tom> tried this for a bit, but didn't get it to work. > > If this can occur due to some user problem (say a bad layout or bad > window implementation) then gdb ideally should be more robust somehow. OK, I've got a theory why I had difficulty getting this to work. The problem is probably that after endwin "Refreshing a window resumes program mode" and I suppose that got triggered by "tui_batch_rendering defer". So using an explicit reset_shell_mode instead of endwin makes this work for me. Thanks, - Tom